Giter Site home page Giter Site logo

ngcable's People

Contributors

joehany avatar wazery avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

ngcable's Issues

Errors on ping messages.

I use rails-5.0.0beta4.
I've got this error:
Uncaught TypeError: Cannot read property 'received' of undefined
in
Cable.Subscriptions.Subscriptions.notify - action-cable.js:353
message - action-cable.js:122

I happens probably when server send messages with ping but there is no channel identifier in data property (i checked 'MessageEvent' object).

Failed to execute removeEventListener error

Cause WebSocket inherits from EventTarget, webSocket.removeEventListener need to be called with at least 2 required parameters: event type and event handler (according to https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/removeEventListener).

In this case, when Cable call uninstallEventHandlers, it throws an error: Uncaught TypeError: Failed to execute 'removeEventListener' on 'EventTarget': 2 arguments required, but only 1 present.

Source:
https://github.com/wazery/ngCable/blob/dev/src/action-cable.js#L108

    Connection.prototype.uninstallEventHandlers = function() {
      var eventName, results;
      results = [];
      for (eventName in this.events) {
        results.push(this.webSocket.removeEventListener(eventName));
      }
      return results;
    };

Roadmap and TODO

TODO List for v.0.3.0

  1. Write unit tests
  2. Write e2e tests
  3. Add more API methods

Aside Note: Propose CableDash gem for Rails' core team. This gem will be a dashboard showing all of the data (channels, events, etc) that got sent to the cable server, much like Pusher's one, that can be installed in both dev and production environments.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.