wazery/ngcable

Power your Angular application with Rails' ActionCable

ngcable's Issues

Annotate the angular code.

Roadmap and TODO

TODO List for v.0.3.0

1. Write unit tests
2. Write e2e tests
3. Add more API methods

Aside Note: Propose CableDash gem for Rails' core team. This gem will be a dashboard showing all of the data (channels, events, etc) that got sent to the cable server, much like Pusher's one, that can be installed in both dev and production environments.

Broken link to demo

When you visit https://cabe-app.herokuapp.com (link for the demo app), Heroku says:

There is no app configured at that hostname.
Perhaps the app owner has renamed it, or you mistyped the URL.

Errors on ping messages.

I use rails-5.0.0beta4.
I've got this error:
Uncaught TypeError: Cannot read property 'received' of undefined
in
Cable.Subscriptions.Subscriptions.notify - action-cable.js:353
message - action-cable.js:122

I happens probably when server send messages with ping but there is no channel identifier in data property (i checked 'MessageEvent' object).

Failed to execute removeEventListener error

Cause WebSocket inherits from EventTarget, webSocket.removeEventListener need to be called with at least 2 required parameters: event type and event handler (according to https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/removeEventListener).

In this case, when Cable call uninstallEventHandlers, it throws an error: Uncaught TypeError: Failed to execute 'removeEventListener' on 'EventTarget': 2 arguments required, but only 1 present.

Source:
https://github.com/wazery/ngCable/blob/dev/src/action-cable.js#L108

    Connection.prototype.uninstallEventHandlers = function() {
      var eventName, results;
      results = [];
      for (eventName in this.events) {
        results.push(this.webSocket.removeEventListener(eventName));
      }
      return results;
    };