wbrefvem/python-jolokia

Python client for Jolokia, an HTTP-JMX bridge

python-jolokia's Issues

Rewrite set_attribute to explicitly accept list of attribute-value pairs

Currently, the set_attribute method can perform a bulk write if passed a list of attributes and :

def set_attribute(self, mbean=None, attribute=None, value=None, path=None, *args, **kwargs):
        """Sets the value of an MBean's attribute"""

        if not mbean or not attribute or not value:
            raise IllegalArgumentException('set_attribute method has 3 required parameters: mbean, attribute, and value')

        if type(attribute) is list and type(value) is dict:
            return self._bulk_write(mbean, attribute, value, **kwargs)
        elif (type(attribute) is list and type(value) is not dict) or (type(attribute) is not list and type(value) is dict):
            raise IllegalArgumentException('Bulk writes must include an attribute list and an attribute map')

This clunky and unintuitive. set_attribute should take an optional boolean called bulk and a list of attribute-value tuples as a co-requirement if bulk = True.

Cleanup CI build, setup Jenkins to do Codeship preliminaries

Multiple attributes in get_attribute returns only the first one

When passing in a list of attributes into get_attribute only the first attribute is returned. Looking in the source I see that a list of individual json payloads are generated and then sent.

I dont know if things have changed for jolokia since the birth of this project but this doesn't work as the return is only the first attribute supplied in the list. According to jolokia docs a json array of attributes is to be passed in, not a list of separate individual payloads of each attribute. I'm not sure if this is an in general thing or just because I'm dealing with AMQ and its a bit different.

In any case if you pass a comma separated string of your list as the attribute that also works and returns the bulk listing of all your attributes.

Authentication to Jolokia endpoint

Hi,
I looked both in documentation and source but can't seem to find how to do an authenticated call to the Jolokia endpoint. Is it a missing feature or does it have an implicit syntax?
Thanks,

Marco

DRY out tests

Currently, mock methods used to monkey patch requests.Session are repetitive¹ and should be refactored according to the DRY principle.²

Flesh out and publish docs

Documentation should be completed, built with sphinx, and hosted somewhere.