Giter Site home page Giter Site logo

wceu / contributor-orientation-tool Goto Github PK

View Code? Open in Web Editor NEW
13.0 13.0 9.0 154 KB

A WordPress plugin aiming to help new contributors decide which make team/s to contribute to or join at Contributor Day.

License: GNU General Public License v3.0

PHP 72.55% JavaScript 13.42% SCSS 14.03%

contributor-orientation-tool's People

Contributors

2ndkauboy avatar aleksandarpredic avatar dependabot[bot] avatar epascalc avatar timiwahalahti avatar zzap avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

contributor-orientation-tool's Issues

Sort teams by rating

Instead of showing all the teams that someone is qualified to contribute, we could give points to each team based on the user's choices, and then sort the 3 teams that are more suitable.

We could still put a "View all" button, so the users would be able to see all teams sorted from the most suitable one to the less suitable one.

In this case, it also could make sense put a "fit percentage", so it would be clear to the user how suitable they are.

Add option for users to display default discription so they have already prepared text before shortcode on frontend

Add option for user to display this text before shortcode (this make it easier for the user to start with plugin usage out of the box):

Hello,

Thank you for your interest in contributing to WordPress project.
Even though this tool is created by WordCamp Europe organising team, it is meant to help you decide in less than 1 minute which team to join at any WordCamp Contributor Day in order to start contributing. As a matter of fact, you don’t even have to use it specifically for Contributor Day.

We are not collecting nor storing any data from this form. It is completely anonymous and purely informative nature. This means that you can use it any time and as many times you want. Only you will know your results and these results are, by no means, obligatory for you to join recommended teams.

Please note that this survey will not register you for any Contributor Day. You still need to do that if you want to attend Contributor Day. For more info on that please visit the website for WordCamp you are planning to attend and/or contact its organizers.

Fix capability in options page

For options page we should use manage_options capability rather than administrator role.

src/src/WPCOTool/Admin/Settings.php:21

Apply new skills matrix

For the WCEU 2020, the contributing team will prepare the Skills matrix, google sheets document that will represent which team is appliable per skill/role. When we have this ready, we need to refactor the sections in this repository src/src/WPCOTool/config folder. There we will need to modify labels and assigned teams.

This will be on hold until we have the Skills matrix ready.

Point Polyglot users to local communities

If the user is suitable to the Polyglots team, so we could also ask their locale, and point them out to the local community (if available). If their locale is not available, so we could point them out to create a new one.

Apply new design and make it responsive

Apply new design.

Basically all structure is there, only the section with arrows (steps) is missing and it need to be connected with active section index.

Also, currently we have fixed width that was used to support only desktop for prototype, we need to make it responsive to support all common breakpoints. Bootstrap breakpoints are fine :)

Checkboxes already made

https://codepen.io/vbaimas/pen/ROWqMG

Icon if needed, but you can get all from Codepen

fa-check http://fa2png.io/

Colors:

Main Color : rgba(0,0,0,.75)
#8E1254
#DB0577
#E8F5F6
#1B646C

  • Warning : background - color : #FF3838

Design notes

CT_D1_notes

Errors displayed

CT_D1_error

About incorporation of Japanese translation files

Hi! I'm a Gutenberg contributor from Japan.
Shusei, a Japanese community member, suggested that we could make use of this tool in Japan, and he has created a translation file for us.

I have built an environment and tried to incorporate the translation file, but I just couldn't get the translation to work. I may be doing something wrong, but could you please incorporate this translation file?

Here are the po and mo files for Japanese generated from the pot file:

ja-po-mo.zip

Perhaps it would be better to do so after the build process by #62 is complete.

If you have any questions, please contact me 👍

Design fixes for 1.1.0

From Vasilis Baimas in Trello

  • The site buttons have rounded corners, so the checkboxes controls are nice to have rounded corners as well.
  • Instead of green or red, I use yellow color for the step control. Red and Green are colors that have been used on the site as Call to action and links. So the user will confused with this option.
  • The color in the checked option should have a “default” color. Even if the green is used in the palette of colors, it gives the feeling that the user has chosen the right choice, since the green color in the selection is correct.
  • I add the steps with some description, which represents the content of each step.

Form :
border-radius : .1875rem;

Selected step :
Step: font-weight:700
Description : font-weight:400 (normal)

Unselected step :
Step : font-weight:700, text-transform:uppercase
Description : font-weight:400 (normal)
Color : rgba (0,0,0,0, 0.60);

Next button
Default: font-weight:700;, background color : rgba(229, 43, 138, 1);

Hover : font-weight:700;, background-color : rgba(142, 18, 84, 1);

Go-back
Color : rgba (0,0,0,0, .85);
Font-weight: normal

Separate line
Color : rgba (0,0,0,0, .85);

Array alignment - WPCS

Just to make sure we apply WordPress Coding Standards in every way, let's align all array item keys and values. For example, array in WPCOTool/config/teams.php would be more readable if values were aligned as well.

Improve question accessibility

Currently, there are a few ways question accessibility could be improved. Noted some details below.

  1. Since this is to be used within a page, the question title should be a heading 2 as most page titles are heading 1.
  2. There is not proper form markup. Need to use <fieldset> and <legend> tags to ensure the wrapping question is read when the answer choices are interacted with via tab or other navigational keys.
  3. After pressing Next or Go back, focus should be placed on the step currently selected. You can do this by adding tabindex="-1" on the <li> element I believe. This should work fine but might be worth testing to be sure.

Add feedback option

We need to add:

  • In last section: Textarea which user can use to send us a feedback
  • New option to enter email to send feedback to
  • Checkbox so user can check to send us all form data anonymously or if not checked just feedback

Plugin fatal errors under PHP 5.6

Issue

The following fatal error occurs when the activated plugin's environment is switched to PHP 5.6, which as of this writing is still supported by WordPress.

Catchable fatal error: Argument 1 passed to WPCOTool\Plugin::__construct() must be an instance of WPCOTool\string, string given, called in .../contributor-orientation-tool/contributor-orientation-tool.php on line 32 and defined in .../contributor-orientation-tool/src/WPCOTool/Plugin.php on line 74

The error stems from use of the string scalar type declaration in class constructors, support for which was added in PHP 7.0.

I came across this issue after switching PHP versions to test a PHP-version-specific WordPress core patch.

PHP Support

I understand that the plugin is marked as requiring a minimum of PHP 7.0, however, the source of this fatal error may not be apparent to some users. Preventing the occurrence of the resultant white screen of death would be a preferable alternative 😂 ...at least until PHP 5.6 support is officially dropped.

Improve steps accessibility

Currently, the steps are not really as accessible as they could be. These suggestions could bring much better functionality for all.

  1. The ":" should be after the step number, not prepended to the word.
    Wrong: STEP 1 :Use of WordPress
    Right: STEP 1: Use of WordPress
    Details like this can make a world of difference in how screen readers speak.
  2. The steps should have some type of indicator to screen readers about which one is currently selected/in view. You could try adding aria-current to the active step <li> tag.
    https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-current

Make Accessibility more visible and add it also for Designers

If I select every role (Developer, Designer, ...) I see these options:

Bildschirmfoto 2019-06-03 um 12 04 22

I would love to select "Accessibility" here, cause I'm super passionate about it. But I can't see it.

Only if I select

  • "I'm a Developer"
  • and I am Passionate about "Web development, backend development etc."
  • and I have experience in "Implementing accessibility standards"

I get the Team "Accessibility"- Which only attract people who already now stuff about it. But it would be great also to have contributers on the A11y-Table who are new to Accessibility but are intresting in learning it (in fact, thats typical for the a11y table on a contributor day).

It would be also great to not only make it possible for developers, but also for designers and other skills, as Accessibility needs a wide range of skills.

For example, I am a Designer and still contribute to Accessibility, so I would suggest to make "Accessibility" a selected item on the screen "what are you passionate about".

Update the orientation.wp-europe.org with the new WCEU 2020 theme

This task is not related to coding anything within this plugin.

In order to match the orientation site design with the WCEU 2020 site design, we need to have the same theme applied at orientation.wp-europe.org. So when the new design for this tool is ready, user of the tool can relate to the new WordCamp Europe theme while using this tool.

Change last section headline

Change Based on your answers, we recommend that you join some of teams below! to Based on your answers, we recommend that you join some of teams below:

Last characher ! => :

Restructure results accessibility

Currently, the results could use refactoring for better accessibility. For example, instead of having two links that go to the same place, you could accomplish it this way.

<a href="https://make.wordpress.org/core">About Core: The core team makes WordPress. Whether you’re a seasoned PHP developer or are just learning to code, we’d love to have you on board. You can write code, fix bugs, debate decisions, and help with development.</a>

WP default theme Twenty nineteen bugs

Few bugs detected:

  • There is a bug where next section input groups are not marked as it need to be. Results are not correct.
  • Button style. (We need to add padding: 12px 30px; line-height: 1;)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.