wching/android-indefinite-pager-indicator

A lightweight, plug-and-play indefinite pager indicator for RecyclerViews & ViewPagers.

android-indefinite-pager-indicator's Issues

RecyclerView with reverseLayout enabled

When the reverseLayout flag is enabled the indicator doesn't behave properly

feature request

i'd love to add drawables instead of colors for the dots 💃

Missing file

Hi there,

I just clone the project, tried to open it with AS and I got this error:

Error:Could not read script 'C:\Users\xxxx\Documents\xxx\Android-Indefinite-Pager-Indicator\gradle\bintray_installer.gradle' as it does not exist.

It's been used in line 62 in library gradle, but I couldn't find it.

Indicator position

Is it possible to keep the indicators centered instead of moving with the viewpager/recyclerview which ends up finding the view in the left or the right of the screen

I love this pager indicator!!! Any chance it could support custom layout manager?

Any chance it could support custom layout manager, I'm using a custom layout manager, and it throws an error telling me my LayoutManager can not be cast to LinearLayoutManager.

Decouple From Concrete Classes

Literally all you need here is total postilions and current position. There's no reason you need a view pager or a recycler view for this and it limits it's uses.

Crash when RecyclerView data is empty and RecyclerView invisible.

Crash when RecyclerView data is empty and RecyclerView invisible.

Indicator count

Seems like not working when having only few items, dots are multiplying, also you have some count!! which causes crashes, should prob be changed to count?:0 which will provide a null safe case.

NPE when set ViewPager null (in java context) (version 1.0.9)

getting a KotlinNullPointerException:
kotlin.KotlinNullPointerException at com.rbrooks.indefinitepagerindicator.IndefinitePagerIndicator.attachToViewPager(IndefinitePagerIndicator.kt:220)

When using in java code
indefinitePagerIndicator.attachToViewPager(null);

Could it be an issue with java in combination with kotlin?

Current work around is using:
indefinitePagerIndicator.attachToRecyclerView(null);

Library crashes if recyclerview's item's rootview contains "layout_margin" attribute.

Library crashes if recyclerview's item's rootview contains "layout_margin" attribute.

Below is the crash log ::

01-19 17:02:50.296 18167-18167/? E/AndroidRuntime: FATAL EXCEPTION: main
Process: com.lrm.emark, PID: 18167
java.lang.RuntimeException: Unable to start activity ComponentInfo{com.lrm.emark/com.lrm.emark.MainActivity}: java.lang.IllegalStateException: An instance of OnFlingListener already set.
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2927)
at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2988)
at android.app.ActivityThread.-wrap14(ActivityThread.java)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1631)
at android.os.Handler.dispatchMessage(Handler.java:102)
at android.os.Looper.loop(Looper.java:154)
at android.app.ActivityThread.main(ActivityThread.java:6682)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1520)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1410)
Caused by: java.lang.IllegalStateException: An instance of OnFlingListener already set.
at android.support.v7.widget.SnapHelper.setupCallbacks(SnapHelper.java:115)
at android.support.v7.widget.SnapHelper.attachToRecyclerView(SnapHelper.java:103)
at com.lrm.emark.feed.FeedbackFragment.onCreateView(FeedbackFragment.java:131)
at android.support.v4.app.Fragment.performCreateView(Fragment.java:2354)
at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1419)
at android.support.v4.app.FragmentManagerImpl.moveFragmentToExpectedState(FragmentManager.java:1740)
at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1809)
at android.support.v4.app.BackStackRecord.executeOps(BackStackRecord.java:799)
at android.support.v4.app.FragmentManagerImpl.executeOps(FragmentManager.java:2580)
at android.support.v4.app.FragmentManagerImpl.executeOpsTogether(FragmentManager.java:2367)
at android.support.v4.app.FragmentManagerImpl.removeRedundantOperationsAndExecute(FragmentManager.java:2322)
at android.support.v4.app.FragmentManagerImpl.execPendingActions(FragmentManager.java:2229)
at android.support.v4.app.FragmentManagerImpl.dispatchStateChange(FragmentManager.java:3221)
at android.support.v4.app.FragmentManagerImpl.dispatchActivityCreated(FragmentManager.java:3171)
at android.support.v4.app.FragmentController.dispatchActivityCreated(FragmentController.java:192)
at android.support.v4.app.FragmentActivity.onStart(FragmentActivity.java:560)
at android.support.v7.app.AppCompatActivity.onStart(AppCompatActivity.java:177)
at android.app.Instrumentation.callActivityOnStart(Instrumentation.java:1256)
at android.app.Activity.performStart(Activity.java:6959)
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2890)
at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2988) 
at android.app.ActivityThread.-wrap14(ActivityThread.java) 
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1631) 
at android.os.Handler.dispatchMessage(Handler.java:102) 
at android.os.Looper.loop(Looper.java:154) 
at android.app.ActivityThread.main(ActivityThread.java:6682) 
at java.lang.reflect.Method.invoke(Native Method) 
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1520) 
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1410) 

Missing screenshot

Hi,

Can you put a screenshot to we understand the component UI and appearance?

Thanks.

space between recycler view and indicator

There is space showing between horizontal recycler view indicator in high density pixel devices.

Dependencies update!

Topic
Dependencies update!

Expected behavior
The library keeps working :)

Screenshots
No screenshots.

Additional context
No Additional context

Setting viewpager index programmatically doesn't update indicator

Calling viewPager.setCurrentItem(int index, boolean smoothScroll) doesn't update the indicator position.

viewpager2 support

see #36

Programmatically customization

How can I customize this view when it's creating programmatically? How to change dots colors, size, count, for example?

Missing tests

We would like to add tests to ensure the library keeps working when someone proposes/wants to:

• Develop a new feature
• Fix a bug

No transparent background when using Theme.MaterialComponents.Light.DarkActionBar

Describe the bug

First thanks for your great code.
I recently switched to use "Theme.MaterialComponents.Light.DarkActionBar" and when doing so the background of the pager indicator is always white. I did not find a way to make it back transparent which is as far as i understood the default.

With the former "Theme.AppCompat.Light.DarkActionBar" all is fine

Using version 1.5 on targetSDK 31

Smartphone (please complete the following information):

• OS: [Android]
• Version [13]

I want to select 4 dots at a time

I want to select 4 dots at a time. Like you see the image in the link below. Currently, only one dot is selected. I want to select 4 at a time.

https://drive.google.com/file/d/1hG6PvoL9qxbHZr3BqtqbZVDBOl37On3C/view?usp=sharing

[suggestion]It will be useful if there is an "Orignal style" option

In the existing Git project, there is just a few Pager indicator which is supporting PagerHelper with RecyclerView.
Truly, this project makes people easy to enjoy the result.
But it will be useful if there is an option to change back the style from Instagram to Normal.
(PS: Orignal style means..... when the pager is on the first page, the first bubble should located at the left of center, not at the excel center)

Thank you

Support for Vertical Layout

As a user of the library, I would like to have the possibility to have the vertical layout support on the awesome indefinite pager indicator,
so that I can have the possibility to use it on the left or right side of a Recycler/Viewpager.

🌮 🌮

There is no anti-aliasing on dot view.

There is no anti-aliasing on dot view.

minSdk slightly too high

are there any specific reasons why it has to be min sdk 21? i need at least 16 for compatibility reasons: https://developer.android.com/about/dashboards/index.html