wdjungst/create-repack-app

A cli to build a rails application with create-react-app

create-repack-app's Issues

[FULL][REDUX] Move action types to constants

I would like to move action types into constants for the pre-loaded actions.

Devise Secret key

Devise Secret gets lost when cloning a built repo. This is because of the Devise Gem and we should generate a Devise config with a generated key for development and ENV key for production

App.js inconsistent quotes

We should use " in JSX.

[FULL] Initial 401

We try to validate the token on every request including the initial request before a user is logged in.

The browser default is to send back a 401 which it should. This causes the lighthouse score to drop slightly due to console errors.

We need a more graceful way to handle validating the token when you land on a page for the first time or token has expired

Listen console warning

Listen generates a console warning on MacOS due to deep linking. We can suppress this warning by overwriting the duplicate directory warning in config/environments/development.rb

creating unnecessary files inside the project

inside the app folder it creates the config/routes.rb file

also in the root file theres an extra controller/static_controller.rb

Auto Update

I would like to move the code in index.js to its own module and when a new app is created the latest code is pulled down from NPM this would allow auto-updating.

Opt out of CSS framework

Been looking into creating a flag to opt out of using a css framework. This would require basically creating an alternate client setup consisting of components that don't use semantic for their styling. Wondering if anyone else has interest in this use case, if there is interest I would be happy to start poking through it.

For a new computer without rails or spring on it, we should gem install those before running the commands

with no api modules devise fails to register

We are authenticating users for any controller in the API folder by default with the full flag. If a controller doesn't exist in the API folder this causes devise registration to attempt to authenticate a user. Creating a generic API controller would solve this.

[FULL] Login and registration form

The login and registration forms are intended to be very generic and unstyled(ish) similar to the original devise authentication flow.

I am all for not styling them but since they are styled already with semantic we should make them a little easier to look at.

confirmable in user model since 1.7.0

The confirmable module stays in user model and it's not intuitive that you need to set up a mail server to get the app working.

[FULL] -y flag

A frequent user should be able to skip all questions using the full flag with a -y flag which would default the first question about create-react-app to yes and assume the server will be running on port 3001

If bundle takes too long script crashes

Installation is broken for both --full and normal installs

Brennicks-MacBook-Air:Projects biosci$ create-repack-app vertical-coop-app --full
Welcome To Create Repack App.

? Do you have create-react-app installed and globally available? Yes

Writing Server Code...
Writing Client Code...

Please Wait, This Could Take A Few Minutes...

? Rails server port 3001

Performing A Full Install. (Rails, React, React Router, Redux, Devise, Devise Token Auth, Authentication Components)

Please Wait, This Could Take A Few Minutes...

(node:22043) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: ENOENT: no such file or directory, open 'vertical-coop-app/client/package.json'
(node:22043) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Project Built Successfully!

GETTING STARTED:
cd vertical-coop-app
rails s -p 3001
cd client
yarn start or npm run start

PRODUCTION:
If deploying to heroku:
heroku buildpacks:clear
heroku buildpacks:set heroku/nodejs
heroku buildpacks:add heroku/ruby --index 2

If not deploying to heroku:
From root folder: yarn build && yarn deploy

---

The following json package file does not get created: /client/package.json

Remove semantic . Syntax

Semantic UI React is moving away from <Thing.Stuff> to

Option to use TypeScript

Would be nice to do something like:

create-repack-app my-app --typescript.

[BUG] Check for numeric input when prompting for port

The user can type anything in at the port prompt which causes the app to not correctly proxy to the server.

Update Login and Registration forms

In the full flag we use semantic but the forms do not.

Not changing the proxy port in client/package.json when change the default Rails port.

When running process and change the default Rails port, proxy in client/package.json will be 3001.

https://github.com/wdjungst/create-repack-app/blob/master/index.js#L176

[FULL][REDUX] Duck pattern

In most of my personal projects, I have moved to the DUCK pattern. Perhaps we should have a flag for this or a console option.

[FULL] Auth actions should take an object instead of params

Using the --full flag with, login and register should take an object so that a user may extend the registration columns from devise, for example, allowing name and username on registration.

Issues for users running on Linux Subsystem for Windows:

Issue affects users running on Linux subsystem for Windows (and others with strict settings related to creating roles on their local server)

You need to be able to put your own postgres user name BEFORE devise:install runs because users running on Linux subsystem have an unrelated issue with the default role parameter not being an accepted role, and therefore devise install will not work, when running "create-repack-app project_name --full -y". Theoretically, ANYONE with strict settings related to creating new roles on their local server, will have this same issue. Perhaps the user may have the option of passing in their "role" name as an argument, to be inserted into the database.yml?