webadvanced/orchard-sitemap

SiteMap module for Orchard CMS

orchard-sitemap's Issues

NAT private port number appended

Thank you for your product.

I'm using Orchard 1.5.1, Advanced Sitemap 1.3.2, IIS7 on w2k8r2.

The site <PublicIP>:80 is NATted to <PrivateIP>:81 and IIS app is listening to <hostname> header at 81. But instead of using http://<hostname>:80 both sitemap.xml and "Add Custom Route" functions are appending private port to the public hostname http://<hostname>:81
This seems to be a behavior by design.
Is there a way to force hostname and port?

Content type indexing labelled as "Custom Routes"

The label "Custom Routes" above the content type indexing settings should be changed to something more appropriate.

Sitemap.xml only updates after app restart

Not after settings or content is updated.

Sitemap.xml delayed update

I noticed the sitemap.xml doesn't automatically get updated when new pages are added or the url to existing pages are modified. When creating a few tenant sites and then coming back to look at the sitemap.xml for all of them, the ones that are a few hours old have accurate sitemap.xmls, but the newest sites created only minutes before do not reflect an accurate sitemap. They always have just the single root path. It takes me disabling the module, then re-enabling it to refresh. Using In Orchard 1.4.2.

For instance, when I create 10 tenant sites and each site takes 30 minutes to setup. When they're all setup and I check the sitemap.xml for each tenant, they all show all the pages except that last tenant which only shows the single root site path, for which I have to disable and re-enable. This is a regular pattern I run into.

Rebuilt for Orchard 1.10

Donald Boulton version Orchard-SiteMap

Exception when accessing Sitemap dashboard page.

I'm getting this error using the latest source from the orchard-sitemap repo, with Orchard 1.6 RC.

2012-10-23 12:57:07,663 [6] Orchard.Exceptions.DefaultExceptionPolicy - An unexpected exception was caught
System.NotSupportedException: Boolean Exists(System.Predicate1[Orchard.ContentManagement.MetaData.Models.ContentTypeDefinition]) at NHibernate.Linq.Visitors.HqlGeneratorExpressionTreeVisitor.VisitMethodCallExpression(MethodCallExpression expression) at NHibernate.Linq.Visitors.HqlGeneratorExpressionTreeVisitor.VisitExpression(Expression expression) at NHibernate.Linq.Visitors.HqlGeneratorExpressionTreeVisitor.VisitUnaryExpression(UnaryExpression expression) at NHibernate.Linq.Visitors.HqlGeneratorExpressionTreeVisitor.VisitExpression(Expression expression) at NHibernate.Linq.Visitors.QueryModelVisitor.VisitWhereClause(WhereClause whereClause, QueryModel queryModel, Int32 index) at Remotion.Linq.Clauses.WhereClause.Accept(IQueryModelVisitor visitor, QueryModel queryModel, Int32 index) at Remotion.Linq.QueryModelVisitorBase.VisitBodyClauses(ObservableCollection1 bodyClauses, QueryModel queryModel)
at Remotion.Linq.QueryModelVisitorBase.VisitQueryModel(QueryModel queryModel)
at NHibernate.Linq.Visitors.QueryModelVisitor.GenerateHqlQuery(QueryModel queryModel, VisitorParameters parameters, Boolean root)
at NHibernate.Linq.NhLinqExpression.Translate(ISessionFactoryImplementor sessionFactory)
at NHibernate.Hql.Ast.ANTLR.ASTQueryTranslatorFactory.CreateQueryTranslators(String queryIdentifier, IQueryExpression queryExpression, String collectionRole, Boolean shallow, IDictionary2 filters, ISessionFactoryImplementor factory) at NHibernate.Engine.Query.QueryPlanCache.GetHQLQueryPlan(IQueryExpression queryExpression, Boolean shallow, IDictionary2 enabledFilters)
at NHibernate.Impl.AbstractSessionImpl.GetHQLQueryPlan(IQueryExpression queryExpression, Boolean shallow)
at NHibernate.Impl.AbstractSessionImpl.CreateQuery(IQueryExpression queryExpression)
at NHibernate.Linq.DefaultQueryProvider.PrepareQuery(Expression expression, IQuery& query, NhLinqExpression& nhQuery)
at NHibernate.Linq.DefaultQueryProvider.Execute(Expression expression)
at NHibernate.Linq.DefaultQueryProvider.Execute[TResult](Expression expression)
at Remotion.Linq.QueryableBase1.GetEnumerator() at System.Collections.Generic.List1..ctor(IEnumerable1 collection) at System.Linq.Enumerable.ToList[TSource](IEnumerable1 source)
at Orchard.Utility.Extensions.ReadOnlyCollectionExtensions.ToReadOnlyCollection[T](IEnumerable1 enumerable) in c:\projects\OrchardEnlistments\orchard-azure\src\Orchard\Utility\Extensions\ReadOnlyCollectionExtensions.cs:line 8 at Orchard.Data.Repository1.Orchard.Data.IRepository.Fetch(Expression1 predicate) in c:\projects\OrchardEnlistments\orchard-azure\src\Orchard\Data\Repository.cs:line 72 at WebAdvanced.Sitemap.Services.AdvancedSitemapService.<GetIndexSettings>b__3(AcquireContext1 ctx)
at Orchard.Caching.Cache2.CreateEntry(TKey k, Func2 acquire) in c:\projects\OrchardEnlistments\orchard-azure\src\Orchard\Caching\Cache.cs:line 57
at Orchard.Caching.Cache2.AddEntry(TKey k, Func2 acquire) in c:\projects\OrchardEnlistments\orchard-azure\src\Orchard\Caching\Cache.cs:line 27
at Orchard.Caching.Cache2.<>c__DisplayClass2.<Get>b__0(TKey k) in c:\projects\OrchardEnlistments\orchard-azure\src\Orchard\Caching\Cache.cs:line 19 at System.Collections.Concurrent.ConcurrentDictionary2.AddOrUpdate(TKey key, Func2 addValueFactory, Func3 updateValueFactory)
at Orchard.Caching.Cache2.Get(TKey key, Func2 acquire) in c:\projects\OrchardEnlistments\orchard-azure\src\Orchard\Caching\Cache.cs:line 17
at Orchard.Caching.DefaultCacheManager.Get[TKey,TResult](TKey key, Func2 acquire) in c:\projects\OrchardEnlistments\orchard-azure\src\Orchard\Caching\DefaultCacheManager.cs:line 33 at WebAdvanced.Sitemap.Services.AdvancedSitemapService.GetIndexSettings() at WebAdvanced.Sitemap.Controllers.AdminController.Indexing() at lambda_method(Closure , ControllerBase , Object[] ) at System.Web.Mvc.ActionMethodDispatcher.Execute(ControllerBase controller, Object[] parameters) at System.Web.Mvc.ReflectedActionDescriptor.Execute(ControllerContext controllerContext, IDictionary2 parameters)
at System.Web.Mvc.ControllerActionInvoker.InvokeActionMethod(ControllerContext controllerContext, ActionDescriptor actionDescriptor, IDictionary2 parameters) at System.Web.Mvc.ControllerActionInvoker.<>c__DisplayClass13.<InvokeActionMethodWithFilters>b__10() at System.Web.Mvc.ControllerActionInvoker.InvokeActionMethodFilter(IActionFilter filter, ActionExecutingContext preContext, Func1 continuation)
at System.Web.Mvc.ControllerActionInvoker.<>c__DisplayClass13.<>c__DisplayClass15.b__12()
at System.Web.Mvc.ControllerActionInvoker.InvokeActionMethodFilter(IActionFilter filter, ActionExecutingContext preContext, Func1 continuation) at System.Web.Mvc.ControllerActionInvoker.<>c__DisplayClass13.<>c__DisplayClass15.<InvokeActionMethodWithFilters>b__12() at System.Web.Mvc.ControllerActionInvoker.InvokeActionMethodFilter(IActionFilter filter, ActionExecutingContext preContext, Func1 continuation)

Output Cache module bug

Hi!

I checked my Modules/Features page at my Orchard installation before install Advanced Sitemap but I couldn't find any module with this name neither the Dashboard nor Modules folder... maybe I'm confusing something, has this module another name?

Despite it looks like I haven't this module installed, if I install Advanced Sitemap, the disable/enable link at every module in Features desapear untill I rename AS folder!

So I suspect I haven't all information about this Cache-thing or I'm missing something.

Regards.

Module not available via Orchard feed service...

I've noticed that the WebAdvanced Sitemap module isn't being returned in the list of modules from the Orchard Gallery feed service (http://packages.orchardproject.net/FeedService.svc/). This means when updates to the module are published, the update notification in Orchard is not showing that an update is available (via the Package Updates feature in Orchard).

Is this module available on an alternative feed service, or should it be in the standard list?

Unable to reposition routes on the Display page

I'm running the AdvancesSitemap 1.4.0 module on Orchard 1.6 and I can't reposition any of the routes on the Display tab of the SiteMap's settings page. Upon checking for errors I found that javascript is encountering an error.

Uncaught TypeError: Object function (a,b){return new p.fn.init(a,b,c)} has no method 'curCSS' jquery-ui-1.8.17.custom.min.js:9

Upon searching for a solution I came across this link in the jQuery bug tracker.
http://bugs.jquery.com/ticket/11921

Looks like the method curCSS() is obsolete has been causing compatibility issues between a few different versions of jQueryUI. Can the AdvancedSitemap project be modified to use css() instead or something that hasn't been marked as obsolete?

500 error on calling sitemap

Hi - I believe my Orchard version is 1.6. I've tried both versions 1.5 and 1.6 of advanced sitemap and both produce a 500 error for /sitemap and /sitemap.xml.

My Orchard install is customised and maybe this is the problem, I just wondered if anyone had any bright ideas for me to try or a place I should be looking to resolve this issue.

I don't seem to have the Output Cache module installed.

I have found this log entry which I guess is related to my issue:
2013-10-17 13:21:21,029 [28] Orchard.Exceptions.DefaultExceptionPolicy - An unexpected exception was caught
System.NullReferenceException: Object reference not set to an instance of an object.
at WebAdvanced.Sitemap.Services.AdvancedSitemapService.b__1f(AcquireContext1 ctx) in d:\Websites\***********.co.uk\htdocs\Modules\WebAdvanced.Sitemap\Services\AdvancedSitemapService.cs:line 210 at Orchard.Caching.Cache2.CreateEntry(TKey k, Func2 acquire) in E:\Docs\Visual Studio 2010\Orchard\src\Orchard\Caching\Cache.cs:line 57 at Orchard.Caching.Cache2.<>c__DisplayClass2.b__0(TKey k) in E:\Docs\Visual Studio 2010\Orchard\src\Orchard\Caching\Cache.cs:line 19
at System.Collections.Concurrent.ConcurrentDictionary2.AddOrUpdate(TKey key, Func2 addValueFactory, Func3 updateValueFactory) at Orchard.Caching.Cache2.Get(TKey key, Func2 acquire) in E:\Docs\Visual Studio 2010\Orchard\src\Orchard\Caching\Cache.cs:line 17 at Orchard.Caching.DefaultCacheManager.Get[TKey,TResult](TKey key, Func2 acquire) in E:\Docs\Visual Studio 2010\Orchard\src\Orchard\Caching\DefaultCacheManager.cs:line 33
at WebAdvanced.Sitemap.Services.AdvancedSitemapService.GetRoutes() in d:\Websites**************.co.uk\htdocs\Modules\WebAdvanced.Sitemap\Services\AdvancedSitemapService.cs:line 197
at WebAdvanced.Sitemap.Services.AdvancedSitemapService.GetSitemapRoot() in d:\Websites****************.co.uk\htdocs\Modules\WebAdvanced.Sitemap\Services\AdvancedSitemapService.cs:line 271
at WebAdvanced.Sitemap.Controllers.HomeController.Index() in d:\Websites***************.co.uk\htdocs\Modules\WebAdvanced.Sitemap\Controllers\HomeController.cs:line 109
at lambda_method(Closure , ControllerBase , Object[] )
at System.Web.Mvc.ActionMethodDispatcher.Execute(ControllerBase controller, Object[] parameters)
at System.Web.Mvc.ReflectedActionDescriptor.Execute(ControllerContext controllerContext, IDictionary2 parameters) at System.Web.Mvc.ControllerActionInvoker.InvokeActionMethod(ControllerContext controllerContext, ActionDescriptor actionDescriptor, IDictionary2 parameters)
at System.Web.Mvc.ControllerActionInvoker.<>c__DisplayClass13.b__10()
at System.Web.Mvc.ControllerActionInvoker.InvokeActionMethodFilter(IActionFilter filter, ActionExecutingContext preContext, Func1 continuation) at System.Web.Mvc.ControllerActionInvoker.<>c__DisplayClass13.<>c__DisplayClass15.<InvokeActionMethodWithFilters>b__12() at System.Web.Mvc.ControllerActionInvoker.InvokeActionMethodFilter(IActionFilter filter, ActionExecutingContext preContext, Func1 continuation)
at System.Web.Mvc.ControllerActionInvoker.<>c__DisplayClass13.<>c__DisplayClass15.b__12()
at System.Web.Mvc.ControllerActionInvoker.InvokeActionMethodFilter(IActionFilter filter, ActionExecutingContext preContext, Func`1 continuation)

Any help appreciated.

Thanks

naming custom routes

Need to be able to give a name to a custom route. The name attribute exists in the XML and is unused.

sitemap.xml is not updated

Hi, I have removed all links from Active Routes in Sitemap->Display, and in /sitemap correctly I cannot see any links but in sitemap.xml the links are not changed. Also in Sitemap->Indexing->Content Type Settings only Page has Index for display checked. I am using Advanced Sitemap - Version: 1.3.2. Can you please advice what might be the issue?

Thanks in advance.

Refresh Sitemap Cache results in a 404 error

I wend back to 1.4 and confirmed this issue is only in 1.5.

Server Error in '/' Application.

The resource cannot be found.
Description: HTTP 404. The resource you are looking for (or one of its dependencies) could have been removed, had its name changed, or is temporarily unavailable. Please review the following URL and make sure that it is spelled correctly.

Requested URL: /Admin/WebAdvanced.Sitemap/RefreshXmlCache

when building site with recipe the following attributes are not used

Display Column does not get inserted when building from recipe

Sitemaps not working on Orchard 1.7 RC

Hello,

I'm using your plug-in on Orchard 1.7RC on my site. I can access the sitemap.xml from a browser, but when I use Fiddler to ping it, or try to hit any other sitemap validating service, it returns a 200OK with no payload.

You can try it for yourself at http://advancedrei.com/sitemap.xml.

Any ideas?

Thanks!

-Robert McLaws

Minor issue with JQuery

I was getting scrip errors and the Display Setting page (admin) was not rendering correctly. It seems that I am getting $ is undefined, which I have seen when Jquery is not the 1st script declared. I made the fix in 2 cshtml files and appears to be working correctly.

DisplaySettings.cshtml
@model WebAdvanced.Sitemap.ViewModels.DisplaySettingsPageModel
@{
Script.Require("JQuery").AtHead();

IndexSettingsModel.cshtml
@model WebAdvanced.Sitemap.ViewModels.IndexSettingsModel
@{
Script.Require("JQuery").AtHead();

Null Exception when BaseUrl is empty

When the BaseUrl site setting is empty a null exception is thrown in the AdvancedSitemapService.cs (Master) or HomeController.cs (Orchard-1.3x Tag v1.6.0).

    private string GetRootPath()
    {
        var baseUrl = _siteService.GetSiteSettings().BaseUrl;
        if (!baseUrl.EndsWith("/"))
            baseUrl += "/";
        return baseUrl;
    }

baseUrl should be checked for null or empty. if empty, then use ApplicationRootUrl (Orchard.Utility.Extensions)

    private string GetRootPath() {
        var baseUrl = _siteService.GetSiteSettings().BaseUrl;

        // If Base Url is not set, use the Request Application Root Url
        if (string.IsNullOrEmpty(baseUrl))
        {
            baseUrl = HttpContext.Request.ToApplicationRootUrlString();
        }

        if (!baseUrl.EndsWith("/"))
            baseUrl += "/";
        return baseUrl;
    }

I am using the Module from the Orchard Gallery, which looks like it is on branch Orchard-1.3x tag v1.6.0