webdriverio-boneyard / wdio-sync Goto Github PK

View Code? Open in Web Editor NEW

17.0 17.0 31.0 314 KB

A WebdriverIO v4 plugin. Helper module to run WebdriverIO commands synchronously.

Home Page: http://v4.webdriver.io

License: MIT License

JavaScript 100.00%

wdio-sync's People

Contributors

Stargazers

Watchers

wdio-sync's Issues

Make sure reporter doesn't fail for it('d');

see webdriverio/webdriverio#1343

It should mark test as pending

An in-range update of eslint is breaking the build 🚨

Version 4.7.1 of eslint just got published.

Branch	Build failing 🚨
Dependency	eslint
Current Version	4.7.0
Type	devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As eslint is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Status Details

❌ continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details

Release Notes

v4.7.1

08656db Fix: Handle nested disable directive correctly (fixes #9318) (#9322) (Gyandeep Singh)
9226495 Revert "Chore: rewrite parseListConfig for a small perf gain." (#9325) (薛定谔的猫)

Commits

The new version differs by 4 commits.

2f064d9 4.7.1
0d0bd7b Build: changelog update for 4.7.1
08656db Fix: Handle nested disable directive correctly (fixes #9318) (#9322)
9226495 Revert "Chore: rewrite parseListConfig for a small perf gain." (#9325)

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.

Your Greenkeeper Bot 🌴

An in-range update of sinon is breaking the build 🚨

Version 4.0.1 of sinon just got published.

Branch	Build failing 🚨
Dependency	sinon
Current Version	4.0.0
Type	devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As sinon is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Status Details

❌ continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details

Commits

The new version differs by 16 commits.

ec9126c Update docs/changelog.md and set new release id in docs/_config.yml
1222a0f Add release documentation for v4.0.1
1bf1f2d 4.0.1
1545c26 Update History.md and AUTHORS for new release
e9fab2d Merge pull request #1579 from fatso83/upgrade-deps
f2252b4 Upgrade nise and lolex versions
d81a937 Fix doc typo: scenarious -> scenarios
af3a645 Merge pull request #1577 from evan-007/fix_doc_typo
7c9c881 Remove extra backtick from fake-xhr-and-server docs
cf9bf05 Merge pull request #1575 from mroderick/tidy-up-docs
2e8abad Remove obsoleted lib/sinon/sandbox-stub.js
28e70d1 Use an include for migration guides
3c68adc Move migration guides to new section
6197ff3 Merge pull request #1565 from fatso83/patch-docs
dfb9ee6 Add migration guide for 4.0

There are 16 commits in total.

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.

Your Greenkeeper Bot 🌴

NPM version still does not have last Fibers update

Hello,

When retrieving the last version of this package through NPM, we don't have the [email protected]

"dependencies": {
    "babel-runtime": "6.23.0",
    "fibers": "~1.0.15",
    "object.assign": "^4.0.3"
  },

Do I do something wrong or should a new version be uploaded to NPM?

Thanks

should hooks be getting called before/after async commands?

If I understand the code correctly, hooks won't get run around async commands.

wrapCommand is basically the identity function for async commands: https://github.com/webdriverio/wdio-sync/blob/master/index.js#L153

But for sync commands it calls hooks:
https://github.com/webdriverio/wdio-sync/blob/master/index.js#L199

Is this right? I'm trying to work on an async-only version, and this seemed odd to me.

An in-range update of mocha is breaking the build 🚨

Version 3.5.3 of mocha just got published.

Branch	Build failing 🚨
Dependency	mocha
Current Version	3.5.2
Type	devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As mocha is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Status Details

❌ continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details

Release Notes

v3.5.3

3.5.3 / 2017-09-11

🐛 Fixes

#3003: Fix invalid entities in xUnit reporter first appearing in v3.5.1 (@jkrems)

Commits

The new version differs by 3 commits.

e838a77 Release v3.5.3
4727367 update changelog for v3.5.3 [ci skip]
45c870d Use safer XML escaping

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.

Your Greenkeeper Bot 🌴

An in-range update of should is breaking the build 🚨

Version 13.1.3 of should was just published.

Branch	Build failing 🚨
Dependency	should
Current Version	13.1.2
Type	devDependency

This version is covered by your current version range and after updating it in your project the build failed.

should is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

❌ continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details

Release Notes

13.1.3

Fix #157

Commits

The new version differs by 5 commits.

cc2f68b Release 13.1.3
76ed8ce Merge pull request #160 from shouldjs/deps
1e7b1d0 Merge pull request #159 from shouldjs/fix-157
82c1683 Update deps
6a7989f Fix #157

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of eslint is breaking the build 🚨

Version 4.9.0 of eslint was just published.

Branch	Build failing 🚨
Dependency	eslint
Current Version	4.8.0
Type	devDependency

This version is covered by your current version range and after updating it in your project the build failed.

eslint is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

❌ continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details

Release Notes

v4.9.0

85388fb Fix: Correct error and test messages to fit config search path (#9428) (Jonathan Pool)
62a323c Fix: Add class options for lines-around-comment (fixes #8564) (#8565) (Ed Lee)
8eb4aae New: multiline-comment-style rule (fixes #8320) (#9389) (薛定谔的猫)
db41408 Chore: avoid applying eslint-env comments twice (#9278) (Teddy Katz)
febb897 Chore: avoid loose equality assertions (#9415) (Teddy Katz)
2247efa Update: Add FunctionExpression to require-jsdoc (fixes #5867) (#9395) (Kai Cataldo)
6791d18 Docs: Corrected noun to verb. (#9438) (Jonathan Pool)
b02fbb6 Update: custom messages for no-restricted-* (refs #8400) (Maja Wichrowska)
02732bd Docs: Reorganized to avoid misunderstandings. (#9434) (Jonathan Pool)
d9466b8 Docs: Correct time forecast for tests. (#9432) (Jonathan Pool)
f7ed84f Docs: Add instruction re home-directory config files (refs #7729) (#9426) (Jonathan Pool)
30d018b Chore: Add Aladdin-ADD & VictorHom to README (#9424) (Kai Cataldo)
2d8a303 Docs: fix examples for prefer-numeric-literals (#9155) (Lutz Lengemann)
d7610f5 Docs: Add jquery warning to prefer-destructuring (#9409) (Thomas Grainger)
e835dd1 Docs: clarify no-mixed-operators (fixes #8051) (Ruxandra Fediuc)
51360c8 Docs: update block-spacing details (fixes #8743) (#9375) (Victor Hom)
6767857 Update: fix ignored nodes in indent rule when using tabs (fixes #9392) (#9393) (Robin Houston)
37dde77 Chore: Refactor SourceCode#getJSDocComment (#9403) (Kai Cataldo)
9fedd51 Chore: Add missing space in blog post template (#9407) (Kevin Partington)
7654c99 Docs: add installing prerequisites in readme. (#9401) (薛定谔的猫)
786cc73 Update: Add "consistent" option to array-bracket-newline (fixes #9136) (#9206) (Ethan Rutherford)
e171f6b Docs: add installing prerequisites. (#9394) (薛定谔的猫)
74dfc87 Docs: update doc for class-methods-use-this (fixes #8910) (#9374) (Victor Hom)
b4a9dbf Docs: show console call with no-restricted-syntax (fixes #7806) (#9376) (Victor Hom)
8da525f Fix: recognise multiline comments as multiline arrays (fixes #9211) (#9369) (Phil Quinn)
c581b77 Chore: Error => TypeError (#9390) (薛定谔的猫)
ee99876 New: lines-between-class-members rule (fixes #5949) (#9141) (薛定谔的猫)
9d3f5ad Chore: report unused eslint-disable directives in ESLint codebase (#9371) (Teddy Katz)
1167638 Update: add allowElseIf option to no-else-return (fixes #9228) (#9229) (Thomas Grainger)
4567ab1 New: Add the fix-dry-run flag (fixes #9076) (#9073) (Rafał Ruciński)

Commits

The new version differs by 32 commits.

235c7dd 4.9.0
b6f31a9 Build: changelog update for 4.9.0
85388fb Fix: Correct error and test messages to fit config search path (#9428)
62a323c Fix: Add class options for lines-around-comment (fixes #8564) (#8565)
8eb4aae New: multiline-comment-style rule (fixes #8320) (#9389)
db41408 Chore: avoid applying eslint-env comments twice (#9278)
febb897 Chore: avoid loose equality assertions (#9415)
2247efa Update: Add FunctionExpression to require-jsdoc (fixes #5867) (#9395)
6791d18 Docs: Corrected noun to verb. (#9438)
b02fbb6 Update: custom messages for no-restricted-* (refs #8400)
02732bd Docs: Reorganized to avoid misunderstandings. (#9434)
d9466b8 Docs: Correct time forecast for tests. (#9432)
f7ed84f Docs: Add instruction re home-directory config files (refs #7729) (#9426)
30d018b Chore: Add Aladdin-ADD & VictorHom to README (#9424)
2d8a303 Docs: fix examples for prefer-numeric-literals (#9155)

There are 32 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

applyPrototype corrupts prototype chain of native objects

Return value of saveScreenshot (Buffer) is incorrect due to adding an object to the prototype chain via Object.create. This makes all the native methods on Buffer fail, including the writeFileSync example in the docs. Adding Buffer.isBuffer(result) to the early-return condition fixes this case, though avoiding Object.create might be more robust. :-p

Async custom commands don't work

See webdriverio-boneyard/wdio-mocha-framework#6
Example:

        // ...but this fails with `AssertionError: expected 0 to be above 990` (i.e. it doesn't wait):
        browser.addCommand('customWrapWdio', function async (a) {
            return browser.customWdio(a)
            .then((b) => {
                return b + 1
            })
        })

Using jasmine, "done.fail" is never called (missing try catch block)

Hi,

we are using "wdio-sync" 0.4.8 combined with jasmine testrunner and the junit-reporter.

We've become aware of the following problem:

If some (waitFor) timeout occurs in a test suite, the exception is logged to stdout but not catched in "wdio-sync" and not catched in jasmine or wdio too.

So the junit report doesn't notice of those failed test-cases! Only the number of executed tests is reduced by errors / fails.

Furthermore none of the following test-cases is executed.

So we've debugged wdio-sync to find some "breadcrumbs", leading us to the source of this problem.

We've changed the wdio-sync/index.js for debugging purposes from (line 336):

return origFn(specTitle, function (done) {
            Fiber(() => {
                **specFn.call(this)
                done()**
            }).run()
        })

to:

return origFn(specTitle, function (done) {
            Fiber(() => {
                **try{
                    specFn.call(this)
                    done()
                }catch(e){
                    done.fail(e)
                }**
            }).run()
        })

This solves the problem.

While debugging the "wdio-sync" code we found some similar places, where "done" function is passed as an error callback parameter:

For instance line 359 in wdio-sync/index.js:

}).then(() => done(), **done**)

Is that running for jasmine?!?

We think there must be passed the done.fail function.

Best regards
Dominic Graulich

An in-range update of eslint is breaking the build 🚨

Version 4.7.0 of eslint just got published.

Branch	Build failing 🚨
Dependency	eslint
Current Version	4.6.1
Type	devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As eslint is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Status Details

❌ continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details

Release Notes

v4.7.0

787b78b Upgrade: Espree v3.5.1 (fixes #9153) (#9314) (Brandon Mills)
1488b51 Update: run rules after node.parent is already set (fixes #9122) (#9283) (Teddy Katz)
4431d68 Docs: fix wrong config in max-len example. (#9309) (薛定谔的猫)
7d24dde Docs: Fix code snippet to refer to the correct option (#9313) (Ruben Tytgat)
12388d4 �Chore: rewrite parseListConfig for a small perf gain. (#9300) (薛定谔的猫)
ce1f084 Update: fix MemberExpression handling in no-extra-parens (fixes #9156) (jackyho112)
0c720a3 Update: allow autofixing when using processors (fixes #7510) (#9090) (Teddy Katz)
838df76 Chore: upgrade deps. (#9289) (薛定谔的猫)
f12def6 Update: indent flatTernary option to handle return (fixes #9285) (#9296) (Teddy Katz)
e220687 Fix: remove autofix for var undef inits (fixes #9231) (#9288) (Victor Hom)
002e199 Docs: fix no-restricted-globals wrong config. (#9305) (薛定谔的猫)
fcfe91a Docs: fix wrong config in id-length example. (#9303) (薛定谔的猫)
2731f94 Update: make newline-per-chained-call fixable (#9149) (João Granado)
61f1093 Chore: avoid monkeypatching Linter instances in RuleTester (#9276) (Teddy Katz)
28929cb Chore: remove Linter#reset (refs #9161) (#9268) (Teddy Katz)
abc8634 Build: re-run browserify when generating site (#9275) (Teddy Katz)
7685fed Fix: IIFE and arrow functions in no-invalid-this (fixes #9126) (#9258) (Toru Nagashima)
2b1eba2 Chore: enable eslint-plugin/no-deprecated-context-methods (#9279) (Teddy Katz)
981f933 Fix: reuse the AST of source code object in verify (#9256) (Toru Nagashima)
cd698ba Docs: move RuleTester documentation to Node.js API page (#9273) (Teddy Katz)
4ae7ad3 Docs: fix inaccuracy in npm run perf description (#9274) (Teddy Katz)
cad45bd Docs: improve documentation for rule contexts (#9272) (Teddy Katz)
3b0c6fd Chore: remove extraneous linter properties (refs #9161) (#9267) (Teddy Katz)
c3231b3 Docs: Fix typo in array-bracket-newline.md (#9269) (宋文强)
51132d6 Fix: Formatters keep trailing '.' if preceded by a space (fixes #9154) (#9247) (i-ron-y)
88d5d4d Chore: remove undocumented Linter#markVariableAsUsed method (refs #9161) (#9266) (Teddy Katz)
09414cf Chore: remove internal Linter#getDeclaredVariables method (refs #9161) (#9264) (Teddy Katz)
f31f59d Chore: prefer smaller scope for variables in codebase (#9265) (Teddy Katz)
3693e4e Chore: remove undocumented Linter#getScope method (#9253) (Teddy Katz)
5d7eb81 Chore: refactor config hash caching in CLIEngine (#9260) (Teddy Katz)
1a76c4d Chore: remove SourceCode passthroughs from Linter.prototype (refs #9161) (#9263) (Teddy Katz)
40ae27b Chore: avoid relying on Linter#getScope/markVariableAsUsed in tests (#9252) (Teddy Katz)
b383d81 Chore: make executeOnFile a pure function in CLIEngine (#9262) (Teddy Katz)
5e0e579 Chore: avoid internal SourceCode methods in Linter tests (refs #9161) (#9223) (Teddy Katz)
adab827 Chore: remove unused eslint-disable comment (#9251) (Teddy Katz)
31e4ec8 Chore: use consistent names for apply-disable-directives in tests (#9246) (Teddy Katz)
7ba46e6 Fix: shebang error in eslint-disable-new-line; add tests (fixes #9238) (#9240) (i-ron-y)
8f6546c Chore: remove undocumented defaults() method (refs #9161) (#9237) (Teddy Katz)
82d8b73 Docs: Fix error in example code for sort-imports (fixes #8734) (#9245) (i-ron-y)
a32ec36 Update: refactor eslint-disable comment processing (#9216) (Teddy Katz)
583f0b8 Chore: avoid using globals in CLIEngine tests (#9242) (Teddy Katz)
c8bf687 Chore: upgrade [email protected] (#9234) (薛定谔的猫)
3c41a05 Chore: always normalize rules to new API in rules.js (#9236) (Teddy Katz)
c5f4227 Chore: move logic for handling missing rules to rules.js (#9235) (Teddy Katz)
bf1e344 Chore: create report translators lazily (#9221) (Teddy Katz)
2eedc1f Chore: remove currentFilename prop from Linter instances (refs #9161) (#9219) (Teddy Katz)
5566e94 Docs: Replace misleading CLA links (#9133) (#9232) (i-ron-y)
c991630 Chore: remove ConfigOps.normalize in favor of ConfigOps.getRuleSeverity (#9224) (Teddy Katz)
171962a Chore: remove internal Linter#getAncestors helper (refs #9161) (#9222) (Teddy Katz)
a567499 Chore: avoid storing list of problems on Linter instance (refs #9161) (#9214) (Teddy Katz)
ed6d088 Chore: avoid relying on undocumented Linter#getFilename API in tests (#9218) (Teddy Katz)

Commits

The new version differs by 55 commits.

439e8e6 4.7.0
2ec62f9 Build: changelog update for 4.7.0
787b78b Upgrade: Espree v3.5.1 (fixes #9153) (#9314)
1488b51 Update: run rules after node.parent is already set (fixes #9122) (#9283)
4431d68 Docs: fix wrong config in max-len example. (#9309)
9d1df92 Chore: Revert "avoid handling Rules instances in config-validator" (#9295)
7d24dde Docs: Fix code snippet to refer to the correct option (#9313)
12388d4 �Chore: rewrite parseListConfig for a small perf gain. (#9300)
ce1f084 Update: fix MemberExpression handling in no-extra-parens (fixes #9156)
0c720a3 Update: allow autofixing when using processors (fixes #7510) (#9090)
838df76 Chore: upgrade deps. (#9289)
f12def6 Update: indent flatTernary option to handle return (fixes #9285) (#9296)
e220687 Fix: remove autofix for var undef inits (fixes #9231) (#9288)
002e199 Docs: fix no-restricted-globals wrong config. (#9305)
fcfe91a Docs: fix wrong config in id-length example. (#9303)

There are 55 commits in total.

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.

Your Greenkeeper Bot 🌴

Show more informative stack trace

From @monolithed on January 25, 2017 10:54

The problem

test.js

let page = require('./page');

describe('test', () => {
	it('test', () => page());
});

page.js

module.exports = () => {
	browser.url('https://e.mail.ru/login');
	browser.alertText();
};

Actual

[chrome #0-0] Session ID: ec6a556d-0074-4b8d-9f28-537090c1fd7d
[chrome #0-0] Spec: /test.js
[chrome #0-0] Running: chrome
[chrome #0-0]
[chrome #0-0]   test
[chrome #0-0]
[chrome #0-0]   test
[chrome #0-0]       1) test
[chrome #0-0]
[chrome #0-0]
[chrome #0-0] 1 failing (6s)
[chrome #0-0]
[chrome #0-0] 1) test test:
[chrome #0-0] Timeout of 3000ms exceeded. Try to reduce the run time or increase your timeout for test specs (http://webdriver.io/guide/testrunner/timeouts.html); if returning a Promise, ensure it resolves.
[chrome #0-0] Error: Timeout of 3000ms exceeded. Try to reduce the run time or increase your timeout for test specs (http://webdriver.io/guide/testrunner/timeouts.html); if returning a Promise, ensure it resolves.
[chrome #0-0]     at Timeout.<anonymous> (/node_modules/mocha/lib/runnable.js:232:19)
[chrome #0-0]     at ontimeout (timers.js:365:14)
[chrome #0-0]     at tryOnTimeout (timers.js:237:5)
[chrome #0-0]     at Timer.listOnTimeout (timers.js:207:5)
[chrome #0-0]

Expected

[chrome #0-0] Session ID: ec6a556d-0074-4b8d-9f28-537090c1fd7d
[chrome #0-0] Spec: /tests/1788/test.js
[chrome #0-0] Running: chrome
[chrome #0-0]
[chrome #0-0]   test
[chrome #0-0]
[chrome #0-0]   test
[chrome #0-0]       1) test
[chrome #0-0]
[chrome #0-0]
[chrome #0-0] 1 failing (6s)
[chrome #0-0]
[chrome #0-0] 1) test test:
[chrome #0-0] Something about its real error and place
[chrome #0-0]     at module.exports (/page.js:3:8) 
[chrome #0-0]     at Context.it (/test.js:4:19)

assert

assert(0, 'Something went wrong');

[chrome #0-0] Something went wrong
[chrome #0-0] AssertionError: Something went wrong
[chrome #0-0]     at module.exports (/page.js:6:2)
[chrome #0-0]     at Context.it (/test.js:4:19)
[chrome #0-0]

throw

throw new Error('Something went wrong');

[chrome #0-0] Something went wrong
[chrome #0-0]     at module.exports (/page.js:3:8) 
[chrome #0-0]     at Context.it (/test.js:4:19)
[chrome #0-0]

webdriverio api

browser.alertText();

[chrome #0-0]     at Timeout.<anonymous> (/tests/1788/node_modules/mocha/lib/runnable.js:232:19)
[chrome #0-0]     at ontimeout (timers.js:365:14)
[chrome #0-0]     at tryOnTimeout (timers.js:237:5)
[chrome #0-0]     at Timer.listOnTimeout (timers.js:207:5)

Environment

WebdriverIO version: 4.0.0-4.6.2
Selenium version: any
Node.js version: 6-7
Mocha version: 2-3

Code To Reproduce Issue

test.zip

Copied from original issue: webdriverio/webdriverio#1842

An in-range update of mocha is breaking the build 🚨

Version 4.0.1 of mocha was just published.

Branch	Build failing 🚨
Dependency	mocha
Current Version	4.0.0
Type	devDependency

This version is covered by your current version range and after updating it in your project the build failed.

mocha is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

❌ continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details

Release Notes

v4.0.1

4.0.1 / 2017-10-05

🐛 Fixes

#3051: Upgrade Growl to v1.10.3 to fix its peer dep problems (@dpogue)

Commits

The new version differs by 6 commits.

eb8bf8d Release v4.0.1
3b485ea update CHANGELOG.md for v4.0.1 [ci skip]
96e5c1a upgrade eslint to v4.8.0
d7cff37 Update growl to 1.10.3
0cdd921 remove preversion script; test on publish; closes #2999
f49c0ce Fix changelog issues/pr URLs (#3047)

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of mocha is breaking the build 🚨

Version 3.5.1 of mocha just got published.

Branch	Build failing 🚨
Dependency	mocha
Current Version	3.5.0
Type	devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As mocha is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Status Details

❌ continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details

Release Notes

v3.5.1

3.5.1 / 2017-09-09

📰 News

📣 Mocha is now sponsoring PDXNode! If you're in the Portland area, come check out the monthly talks and hack nights!

🐛 Fixes

#2997: Fix missing xit export for "require" interface (@solodynamo)
#2957: Fix unicode character handling in XUnit reporter failures (@jkrems)

🔩 Other

#2986: Add issue and PR templates (@kungapal)
#2918: Drop bash dependency for glob-related tests (@ScottFreeCode)
#2922: Improve --compilers coverage (@ScottFreeCode)
#2981: Fix tpyos and spelling errors (@jsoref)

Commits

The new version differs by 14 commits.

4070a44 Release v3.5.1
466ba73 update CHANGELOG.md for v3.5.1 [ci skip]
1cc0fc0 import/require xit, fixes #2972
74fa66f update nyc to latest; remove workaround in travis script
aa52933 update coveralls strategy; closes #2984
73a5338 Spelling (#2981)
9f403bf Add utils.escape tests and fix unicode escaping
800acbc whitelist "developer-experience" tag for stalebot [ci skip]
5895671 Added issue, pull request templates. (#2869)
075bd51 Merge pull request #2918 from mochajs/no-shell-test
8710438 Work around Node 0.10 Windows flake when testing
13b8340 Ensure that compiler lookup works and not just that transpilation works (#2922)
26d337a Add tests for double-star behavior
c0e6b68 Eliminate glob.sh

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.

Your Greenkeeper Bot 🌴

Array.prototype.includes shim

Array.prototype.includes is not supported in a couple of nodejs versions. We need to add a polyfil

An in-range update of eslint-plugin-node is breaking the build 🚨

Version 5.2.1 of eslint-plugin-node was just published.

Branch	Build failing 🚨
Dependency	eslint-plugin-node
Current Version	5.2.0
Type	devDependency

This version is covered by your current version range and after updating it in your project the build failed.

eslint-plugin-node is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

❌ continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details

Commits

The new version differs by 3 commits.

ad1f15a 5.2.1
2aaa994 Fix: support negative patterns in files field
155f714 Chore: fix a small misspelling. (#95)

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of eslint-plugin-node is breaking the build 🚨

Version 5.2.0 of eslint-plugin-node just got published.

Branch	Build failing 🚨
Dependency	eslint-plugin-node
Current Version	5.1.1
Type	devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As eslint-plugin-node is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Status Details

❌ continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details

Release Notes

v5.2.0

Bug fixes

e7878e9 fixed no-deprecated-api that has overlooked GLOBAL and root global variables which are deprecated in Node.js 6.0.0. (#92)

Commits

The new version differs by 5 commits.

7189722 5.2.0
e7878e9 Update: fix missing deprecated APIs in v6 (fixes #92)
52ceb11 Chore: rm superfluous argument. (#93)
69dc50a Chore: update .travis.yml
effdd10 Fix: fix tests for linter.reset

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.

Your Greenkeeper Bot 🌴

An in-range update of eslint is breaking the build 🚨

Version 4.10.0 of eslint was just published.

Branch	Build failing 🚨
Dependency	eslint
Current Version	4.9.0
Type	devDependency

This version is covered by your current version range and after updating it in your project the build failed.

Status Details

❌ continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details

Release Notes

v4.10.0

bb6e60a Fix: Improve the doc for no-restricted-modules rule (fixes #9437) (#9495) (vibss2397)
c529de9 Docs: Amend rule document to correct and complete it (refs #6251). (#9498) (Jonathan Pool)
f9c6673 Chore: Add tests to cover array and object values and leading commas. (#9502) (Jonathan Pool)
9169258 Chore: remove npm run check-commit script (#9513) (Teddy Katz)
7d390b2 Docs: Revise contributor documentation on issue labels. (#9469) (Jonathan Pool)
d80b9d0 Fix: no-var don't fix globals (fixes #9520) (#9525) (Toru Nagashima)
b8aa071 Fix: allow linting the empty string from stdin (fixes #9515) (#9517) (Teddy Katz)
350a72c Chore: regex.test => string.startsWith (#9518) (薛定谔的猫)
de0bef4 Chore: remove obsolete eslintbot templates (#9512) (Teddy Katz)
720b6d5 Docs: Update ISSUE_TEMPLATE.md (#9504) (薛定谔的猫)
2fa64b7 Fix: should not convert non-consecutive line comments to a single blo… (#9475) (薛定谔的猫)
9725146 Fix: multiline-comment-style fix produces invalid code (fixes #9461). (#9463) (薛定谔的猫)
b12cff8 Fix: Expected order of jsdoc tags (fixes #9412) (#9451) (Orlando Wenzinger)
f054ab5 Docs: add .md to link (for github users) (#9501) (薛定谔的猫)
5ed9cfc Docs: Correct violations of “Variable Declarations” in Code Conventions (#9447) (Jonathan Pool)
3171097 Docs: Clears confusion on usage of global and local plugins.(#9492) (Vasili Sviridov)
3204773 Chore: enable max-len. (#9414) (薛定谔的猫)
0f71fef Docs: Unquote booleans in lines-between-class-members docs (#9497) (Brandon Mills)
b3d7532 Docs: use consistent terminology & fix link etc. (#9490) (薛定谔的猫)
87db8ae Docs: Fix broken links (#9488) (gpiress)
51bdb2f Docs: Incorrect link to related rule (#9477) (Gavin King)
1a962e8 Docs: Add FAQ for when ESLint cannot find plugin (#9467) (Kevin Partington)
8768b2d Fix: multiline-comment-style autofixer added trailing space (#9454) (Teddy Katz)
e830aa1 Fix: multiline-comment-style reports block comments followed by code (#9450) (Teddy Katz)
b12e5fe Docs: Repair broken links and add migration links. (#9473) (Jonathan Pool)
eca01ed Docs: Add missing info about special status of home-dir config files. (#9472) (Jonathan Pool)
eb8cfb1 Fix: change err report in constant condition (fixes #9398) (#9436) (Victor Hom)
da77eb4 Chore: Revise no-config-file test to prevent false failure. (#9443) (Jonathan Pool)
47e5f6f Docs: ensure "good commit message" examples actually follow guidelines (#9466) (Teddy Katz)
ebb530d Update: Don't ignore comments (no-trailing-spaces) (#9416) (Chris van Marle)
5012661 Build: fix npm run profile script (fixes #9397) (#9455) (Teddy Katz)
ecac0fd Docs: Remove blockBindings references (#9446) (Jan Pilzer)
0b89865 Chore: ensure tests for internal rules get run (#9453) (Teddy Katz)
052c504 Docs: suggest deleting branches after merging PRs (#9449) (Teddy Katz)
b31e55a Chore: move internal rules out of lib/ (#9448) (Teddy Katz)
a7521e3 Docs: improve examples for multiline-comment-style (#9440) (Teddy Katz)

Commits

The new version differs by 38 commits.

9deb1b1 4.10.0
6d19001 Build: changelog update for 4.10.0
bb6e60a Fix: Improve the doc for no-restricted-modules rule (fixes #9437) (#9495)
c529de9 Docs: Amend rule document to correct and complete it (refs #6251). (#9498)
f9c6673 Chore: Add tests to cover array and object values and leading commas. (#9502)
9169258 Chore: remove npm run check-commit script (#9513)
7d390b2 Docs: Revise contributor documentation on issue labels. (#9469)
d80b9d0 Fix: no-var don't fix globals (fixes #9520) (#9525)
b8aa071 Fix: allow linting the empty string from stdin (fixes #9515) (#9517)
350a72c Chore: regex.test => string.startsWith (#9518)
de0bef4 Chore: remove obsolete eslintbot templates (#9512)
720b6d5 Docs: Update ISSUE_TEMPLATE.md (#9504)
2fa64b7 Fix: should not convert non-consecutive line comments to a single blo… (#9475)
9725146 Fix: multiline-comment-style fix produces invalid code (fixes #9461). (#9463)
b12cff8 Fix: Expected order of jsdoc tags (fixes #9412) (#9451)

There are 38 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of eslint-plugin-promise is breaking the build 🚨

Version 3.6.0 of eslint-plugin-promise was just published.

Branch	Build failing 🚨
Dependency	eslint-plugin-promise
Current Version	3.5.0
Type	devDependency

This version is covered by your current version range and after updating it in your project the build failed.

eslint-plugin-promise is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

❌ continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of np is breaking the build 🚨

Version 2.16.1 of np was just published.

Branch	Build failing 🚨
Dependency	np
Current Version	2.16.0
Type	devDependency

This version is covered by your current version range and after updating it in your project the build failed.

np is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

❌ continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details

Commits

The new version differs by 4 commits.

b6c7a91 2.16.1
bc0b536 Freeze rxjs version (#195)
0e89383 Try out CodeSponsor
8613ba4 Add signed Git tag instructions for Yarn (#172)

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

Unhandled promise rejection in index.js:348:63 (Stacktrace inside)

Context

I use selenium automation scripts written in webdriverio where it runs a few commands and it stops waiting for all elements (in a CSS selector) to disappear. This used to randomly kill my node process with UnhandledPromiseRejection and no stacktrace, I couldn't make headway in fixing this error at all and used to encounter it every few minutes and I used to restart my wdio tests. Now I've gotten the stacktrace, I'm posting it while I myself investigate this further.

This code got me the stacktrace

process.on('unhandledRejection', function(err, promise) {
    console.error('Unhandled rejection (promise: ', promise, ', reason: ', err, ').');
});

Stactrace

Unhandled rejection (promise:  Promise {
  <rejected> TypeError: Cannot read property 'ELEMENT' of undefined
    at is$$Result (C:\my-home\AutomationProjects\WebdriverioProjects\chimp-nedb\node_modules\wdio-
sync\build\index.js:348:63)
    at Object.applyPrototype (C:\my-home\AutomationProjects\WebdriverioProjects\chimp-nedb\node_mo
dules\wdio-sync\build\index.js:363:199)
    at Object.<anonymous> (C:\my-home\AutomationProjects\WebdriverioProjects\chimp-nedb\node_modul
es\wdio-sync\build\index.js:322:63)
    at Object.exec (C:\my-home\AutomationProjects\WebdriverioProjects\chimp-nedb\node_modules\webd
riverio\build\lib\helpers\safeExecute.js:28:24)
    at Object.resolve (C:\my-home\AutomationProjects\WebdriverioProjects\chimp-nedb\node_modules\w
ebdriverio\build\lib\webdriverio.js:193:29)
    at C:\my-home\AutomationProjects\WebdriverioProjects\chimp-nedb\node_modules\webdriverio\build
\lib\webdriverio.js:503:32
    at _fulfilled (C:\my-home\AutomationProjects\WebdriverioProjects\chimp-nedb\node_modules\q\q.j
s:834:54)
    at self.promiseDispatch.done (C:\my-home\AutomationProjects\WebdriverioProjects\chimp-nedb\nod
e_modules\q\q.js:863:30)
    at Promise.promise.promiseDispatch (C:\my-home\AutomationProjects\WebdriverioProjects\chimp-ne
db\node_modules\q\q.js:796:13)
    at C:\my-home\AutomationProjects\WebdriverioProjects\chimp-nedb\node_modules\q\q.js:604:44 } ,
 reason:  TypeError: Cannot read property 'ELEMEN
T' of undefined
    at is$$Result (C:\my-home\AutomationProjects\WebdriverioProjects\chimp-nedb\node_modules\wdio-
sync\build\index.js:348:63)
    at Object.applyPrototype (C:\my-home\AutomationProjects\WebdriverioProjects\chimp-nedb\node_mo
dules\wdio-sync\build\index.js:363:199)
    at Object.<anonymous> (C:\my-home\AutomationProjects\WebdriverioProjects\chimp-nedb\node_modul
es\wdio-sync\build\index.js:322:63)
    at Object.exec (C:\my-home\AutomationProjects\WebdriverioProjects\chimp-nedb\node_modules\webd
riverio\build\lib\helpers\safeExecute.js:28:24)
    at Object.resolve (C:\my-home\AutomationProjects\WebdriverioProjects\chimp-nedb\node_modules\w
ebdriverio\build\lib\webdriverio.js:193:29)
    at C:\my-home\AutomationProjects\WebdriverioProjects\chimp-nedb\node_modules\webdriverio\build
\lib\webdriverio.js:503:32
    at _fulfilled (C:\my-home\AutomationProjects\WebdriverioProjects\chimp-nedb\node_modules\q\q.j
s:834:54)
    at self.promiseDispatch.done (C:\my-home\AutomationProjects\WebdriverioProjects\chimp-nedb\nod
e_modules\q\q.js:863:30)
    at Promise.promise.promiseDispatch (C:\my-home\AutomationProjects\WebdriverioProjects\chimp-ne
db\node_modules\q\q.js:796:13)
    at C:\my-home\AutomationProjects\WebdriverioProjects\chimp-nedb\node_modules\q\q.js:604:44 ).

[Feature Request] Support wrapping of elements in the value array with prototype methods

From @gregorskii on October 26, 2016 21:48

The problem

When querying for elements via client.elements() in sync mode the response includes a WebDriver JSON object that contains a field values as an array. Each element of this array does not have the prototype methods .click .isVisible etc. There is also no way to query the DOM for the original WebDriver JSON element via the ID returned by the elements call.

Environment

WebdriverIO version: https://github.com/xolvio/sync-webdriverio v5.1.0
Node.js version: 6.5.0
Standalone mode, I believe

Details

When querying the DOM for elements through a selector the Webdriver JSON Object returned includes an array in its values field:

{ sessionId: '4a8763ec-9c6e-42c1-90a9-e64a2508c0d6',
  state: 'success',
  value: [ { ELEMENT: '204' } ],
  class: 'org.openqa.selenium.remote.Response',
  hCode: 886205991,
  selector: 'SELECTOR',
  _status: 0 }

There is not currently a way to use the prototype methods .click(), .element(), .elements() etc directly with a single item in the array. The docs state that these prototype methods will apply to the first element in the array, an example of which is click:

element to click on. If it matches with more than one DOM-element it automatically clicks on the first element

There are convenience methods to do these actions against an ELEMENT ID in the DOM via the elementIDMETHOD functions ex click.

However under certain use cases it would be helpful to have the ability to have the prototype methods applied to each element in the array, or to be able to query the DOM by ID and get the prototype methods.

An example use case of this would be in a map method after a elements query:

Direct form:

const items = this.instance.elements('SELECTOR');

return items.value.each((element) => {
   element.elements('a').isVisible();
  // ... any other actions against this element
});

Function form:

const items = this.instance.elements('SELECTOR');

return items.value.map((webJSONElement) => {
  return webJSONElement.ELEMENT;
}).each((id) => {
  const element = client.elementID(id);
  element.elements('a').isVisible();
  // ... any other actions against this element
});

This functionality is being used primarily with ChimpJS which uses a sync form of Webdriverio, or forces it to be sync.

Copied from original issue: webdriverio/webdriverio#1672

browser.debug() times out

In theory you should be able to call brower.debug() to manually inspect the browser state continue when you are ready by pressing enter at the console.

This works fine using the async api in a standalone js file, but calling debug in a test runner will timeout and fail the test without waiting for user to press enter at the console.

http://webdriver.io/api/utility/debug.html

Is there a way to prevent this command from timing out?

An in-range update of eslint-plugin-import is breaking the build 🚨

Version 2.8.0 of eslint-plugin-import was just published.

Branch	Build failing 🚨
Dependency	eslint-plugin-import
Current Version	2.7.0
Type	devDependency

This version is covered by your current version range and after updating it in your project the build failed.

eslint-plugin-import is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

❌ continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details

Commits

The new version differs by 35 commits.

95b1ba6 disable AppVeyor coveralls
4071379 #842/#944 changelog note
8702af7 #744 changelog note
91c5318 #886 / #891 changelog notes
1b3f544 bump v2.8.0
cef88f2 Merge pull request #944 from alexgorbatchev/alexgorbatchev/issue-842
c246b9e #842 Fixes Cannot read property 'some' of undefined
1958e0b [Tests] fix broken test on master
68f63f5 forgot @k15a's user link 😅
5f5fbf6 changelog notes for #620 + #632
92dd662 Merge pull request #632 from k15a/master
1ba1c3a removing changelog note, will re-add
146f87f changelog notes for #720 + #858
57527c7 Merge pull request #858 from laysent/master
006ddeb Merge remote-tracking branch 'refs/remotes/benmosher/master'

There are 35 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of should is breaking the build 🚨

Version 13.1.2 of should was just published.

Branch	Build failing 🚨
Dependency	should
Current Version	13.1.1
Type	devDependency

This version is covered by your current version range and after updating it in your project the build failed.

Status Details

❌ continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details

Commits

The new version differs by 2 commits.

ff0877a Release 13.1.2
6c8cb39 Revert typings to use = instead of default export. Fixes #155

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of mocha is breaking the build 🚨

Version 3.5.2 of mocha just got published.

Branch	Build failing 🚨
Dependency	mocha
Current Version	3.5.1
Type	devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As mocha is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Status Details

❌ continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details

Release Notes

v3.5.2

3.5.2 / 2017-09-10

🐛 Fixes

#3001: Fix AMD-related failures first appearing in v3.5.1 (@boneskull)

Commits

The new version differs by 5 commits.

72622ab Release v3.5.2
ac4c39f fix version in CHANGELOG.md [ci skip]
f06d969 update CHANGELOG for 3.5.2 [ci skip]
9a3ddeb fix AMD bundle by hacking around check in he module; closes #3000
337d317 fix broken links in CHANGELOG.md [ci skip]

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.

Your Greenkeeper Bot 🌴

An in-range update of sinon is breaking the build 🚨

Version 4.1.0 of sinon was just published.

Branch	Build failing 🚨
Dependency	sinon
Current Version	4.0.2
Type	devDependency

This version is covered by your current version range and after updating it in your project the build failed.

sinon is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

❌ continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details

Commits

The new version differs by 22 commits.

c0a71c6 Update docs/changelog.md and set new release id in docs/_config.yml
a2b873a Add release documentation for v4.1.0
0a6a660 4.1.0
3b36972 Update History.md and AUTHORS for new release
201a652 Issue 1598 (Feature Request): Implemented sandbox.createStubInstance, tests, and documentation.
d49180d Merge pull request #1603 from mroderick/fix-more-markdown
2d2631c Docs: fix pre commit hook
9fa87e7 Docs: remove trailing quote from heading
46ffad3 Docs: verify documentation using markdownlint
aa10bb7 Docs: remove use of element
294ada0 Docs: remove use of
```
 tag
```
77e5d31 Docs: reduce unnecessary inline HTML
b14a261 Docs: fix invalid syntax of backticks in headers
579e029 Docs: fix trailing punctuation in headers
7b04012 Docs: remove extraneous blank lines

There are 22 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

does not work with webdriver 4.0

see webdriverio/webdriverio#1063 for some background. it appears this line:

runInFiberContext(
                INTERFACES[this.config.mochaOpts.ui][2],
                this.config.beforeHook,
                this.config.afterHook,
                fnName
            )

is preventing tests promise chaining from working correctly

An in-range update of eslint-plugin-import is breaking the build 🚨

Version 2.4.0 of eslint-plugin-import just got published.

Branch	Build failing 🚨
Dependency	eslint-plugin-import
Current Version	2.3.0
Type	devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As eslint-plugin-import is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Status Details

❌ continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details

Commits

The new version differs by 10 commits.

44ca158 update utils changelog
a3728d7 bump eslint-module-utils to v2.1.0
3e29169 bump v2.4.0
ea9c92c Merge pull request #737 from kevin940726/master
8f9b403 fix typos, enforce type of array of strings in allow option
95315e0 update CHANGELOG.md
28e1623 eslint-module-utils: filePath in parserOptions (#840)
2f690b4 update CI to build on Node 6+7 (#846)
7d41745 write doc, add two more tests
dedfb11 add allow glob for rule no-unassigned-import, fix #671

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.

Your Greenkeeper Bot 🌴

Publish package with updated dependencies

Looks like the greenkeeper bot has been updating dependencies (specifically fibers), but these changes have not been published. Could you publish this to make these package changes available?

sanitizeErrorMessage fails

https://github.com/webdriverio/wdio-sync/blob/master/index.js#L38

When running browser-automation tests with Chimp, which depends on wdio-sync, the above line is producing an exception:

 Uncaught TypeError: Cannot read property 'trim' of undefined
      at sanitizeErrorMessage (/usr/local/lib/node_modules/chimp/node_modules/wdio-sync/build/index.js:87:34)
      at Object.<anonymous> (/usr/local/lib/node_modules/chimp/node_modules/wdio-sync/build/index.js:337:53)
      at Context.<anonymous> (tests/e-suite.js:48:13)
      at /usr/local/lib/node_modules/chimp/dist/lib/utils/fiberize.js:24:12

The wdio-sync code assumes that the call stack is an Array with some element that can be shifted off. That condition is apparently not guaranteed.

Fibers not being installed under node v8.1.2

Complains about node-gyp not being found.

Error in custom function causes it to be run a second time

As mentioned in #12:

        browser.addCommand('mycustomfunc', function () {
            console.log('mycustomfunc running now', Error().stack);
            throw Error('mycustomfunc error');
        });

prints:

mycustomfunc running now Error
    at Error (native)
    at Object.<anonymous> (/Users/george/Shell/sandboxes/ft-app-webdriverio/build/test/specs/startup.js:43:37)
    at /Users/george/Sites/Git/wdio-sync/build/index.js:187:29
mycustomfunc running now Error
    at Error (native)
    at Object.<anonymous> (/Users/george/Shell/sandboxes/ft-app-webdriverio/build/test/specs/startup.js:43:37)
    at /Users/george/Sites/Git/wdio-sync/build/index.js:187:29

(two calls here: https://github.com/webdriverio/wdio-sync/blob/master/index.js#L60). Also note the stack trace isn't very useful here, and should be improved if possible.

An async custom function is similarly called twice:

mycustomfunc running now Error
    at Error (native)
    at Object.async (/Users/george/Shell/sandboxes/ft-app-webdriverio/build/test/specs/startup.js:43:37)
    at Object.<anonymous> (/Users/george/Sites/Git/wdio-sync/build/index.js:348:30)
    at /Users/george/Sites/Git/wdio-sync/build/index.js:250:23
    at process._tickCallback (node.js:379:9)
mycustomfunc running now Error
    at Error (native)
    at Object.async (/Users/george/Shell/sandboxes/ft-app-webdriverio/build/test/specs/startup.js:43:37)
    at Object.<anonymous> (/Users/george/Sites/Git/wdio-sync/build/index.js:348:30)
    at Object.mycustomfunc (/Users/george/Sites/Git/wdio-sync/build/index.js:273:23)
    at Context.<anonymous> (/Users/george/Shell/sandboxes/ft-app-webdriverio/build/test/specs/startup.js:78:11)
    at /Users/george/Sites/Git/wdio-sync/build/index.js:401:24

(first call here: https://github.com/webdriverio/wdio-sync/blob/master/index.js#L115, second call here: https://github.com/webdriverio/wdio-sync/blob/master/index.js#L143).

Whichever way we handle failures when calling a future, I don't think the custom function should be called twice - I think that's unexpected from a user's point of view.

Unhandled Rejection

Happens when running a custom command that's returning a promise that resolves undefined.

Stacktrace:

TypeError: Cannot read property 'ELEMENT' of undefined
    at is$$Result (/Users/jmnsf/Code/conversio-app/node_modules/wdio-sync/build/index.js:348:63)
    at Promise.applyPrototype (/Users/jmnsf/Code/conversio-app/node_modules/wdio-sync/build/index.js:363:199)
    at /Users/jmnsf/Code/conversio-app/node_modules/wdio-sync/build/index.js:322:63
    at process._tickDomainCallback (internal/process/next_tick.js:129:7)

Array contents:

[ undefined,
  undefined,
  undefined,
  undefined,
  undefined,
  undefined,
  undefined,
  undefined,
  undefined,
  undefined,
  undefined,
  undefined,
  undefined ]

webdriverio: 4.6.2
wdio-sync: 0.6.3
wdio-mocha-framework: 0.5.9

Cannot read property 'split' of undefined

The following test:

browser.addCommand('test', function () {
  throw {
    errorMessage: 'some error'
  };
});

describe('test', () => {
  it('It should work', () => {
    browser.test();
  });
});

Results in a Cannot read property 'split' of undefined error:

[chrome 54.0 #0a] Running: chrome (v54.0)
[chrome 54.0 #0a]
[chrome 54.0 #0a]   test
[chrome 54.0 #0a]       1) it should work
[chrome 54.0 #0a]
[chrome 54.0 #0a]
[chrome 54.0 #0a] 1 failing (5s)
[chrome 54.0 #0a]
[chrome 54.0 #0a] 1) test it should work:
[chrome 54.0 #0a] Cannot read property 'split' of undefined
[chrome 54.0 #0a] TypeError: Cannot read property 'split' of undefined
[chrome 54.0 #0a]     at Context.<anonymous> (/some/path/to/test.spec.js:7:18)

From the stacktrace, it isn't apparent where the error actually occurs. It also swallows the actual error that was thrown. Instead of Cannot read property 'split' of undefined, it would be helpful if the error message was the thrown { errorMessage: 'some error' } object.

(Digging deeper, it looks like the error is thrown at this line. It is trying to parse a stacktrace that doesn't exist because an object was thrown instead of an Error.)

webdriverio getAttribute crashes when attribute is not set

Reproduction steps

<input type="checkbox">
<input type="checkbox">

$$('input[type=checkbox]').getAttribute('checked');

crashes with

UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1):
TypeError: Cannot read property 'ELEMENT' of null

Debugging

By catching unhandled rejections in my code with

process.on('unhandledRejection', (reason, p) => {
  console.log('Unhandled Rejection at: Promise', p, 'reason:', reason);
});

I got a stack trace of

Unhandled Rejection at: Promise Promise {
  <rejected> TypeError: Cannot read property 'ELEMENT' of null
    at is$$Result (/usr/src/app/node_modules/wdio-sync/build/index.js:506:63)
    at Object.applyPrototype (/usr/src/app/node_modules/wdio-sync/build/index.js:535:105)
    at Object.<anonymous> (/usr/src/app/node_modules/wdio-sync/build/index.js:452:58)
    at Object.exec (/usr/src/app/node_modules/webdriverio/build/lib/helpers/safeExecute.js:28:24)
    at Object.resolve (/usr/src/app/node_modules/webdriverio/build/lib/webdriverio.js:193:29)
    at /usr/src/app/node_modules/webdriverio/build/lib/webdriverio.js:503:32
    at _fulfilled (/usr/src/app/node_modules/q/q.js:834:54)
    at self.promiseDispatch.done (/usr/src/app/node_modules/q/q.js:863:30)
    at Promise.promise.promiseDispatch (/usr/src/app/node_modules/q/q.js:796:13)
    at /usr/src/app/node_modules/q/q.js:604:44 }

That leads us to is$$Result which checks if the result is an array of objects that have an .ELEMENT property. The problem is that getAttribute will return null when the attribute is not set, hence the Cannot read property 'ELEMENT' of null error.

Does not save custom commands to command list

browser.addCommand('george', function() {
    browser.url('/');
})
browser.george();
console.log(browser.getCommandHistory())

// gives:

[ { name: 'init', args: [] },
  { name: 'windowHandleMaximize', args: [] },
  { name: 'timeoutsAsyncScript', args: [ 5000 ] },
  { name: 'url', args: [ '/' ] } ]

Custom commands in v4.0 are somehow not added to the commandList, so obviously bypass https://github.com/webdriverio/webdriverio/blob/v4.0/lib/webdriverio.js#L169-L172 somehow.

An in-range update of should is breaking the build 🚨

Version 13.1.1 of should was just published.

Branch	Build failing 🚨
Dependency	should
Current Version	13.1.0
Type	devDependency

This version is covered by your current version range and after updating it in your project the build failed.

Status Details

❌ continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details

Commits

The new version differs by 2 commits.

f8ab675 Release 13.1.1
e65ccf0 Add missing return type

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of sinon is breaking the build 🚨

Version 4.0.2 of sinon was just published.

Branch	Build failing 🚨
Dependency	sinon
Current Version	4.0.1
Type	devDependency

This version is covered by your current version range and after updating it in your project the build failed.

Status Details

❌ continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details

Commits

The new version differs by 21 commits.

39e5737 Update docs/changelog.md and set new release id in docs/_config.yml
c2bd7b1 Add release documentation for v4.0.2
da24e94 4.0.2
cea60e8 Update History.md and AUTHORS for new release
d4dcfca Document the stub.reset breaking change (#1590)
aab1917 Merge pull request #1596 from mroderick/fix-preversion-to-use-history.md
5dbe685 Update 'nise' to latest version (#1593)
578b9ea Update History.md and AUTHORS for new release
499b698 Fix preversion.sh to stage History.md
1e5fd0f Remove unneeded characters
2a69d51 fix typo in contributing
6cc71ec Document how to trigger progress events (#1585)
e49fcf1 Fix broken test-coverage task
527086a Use supports-color module to test if system supports colors
78782b4 Merge pull request #1580 from mroderick/dependency-hygeine

There are 21 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of sinon is breaking the build 🚨

Version 3.3.0 of sinon just got published.

Branch	Build failing 🚨
Dependency	sinon
Current Version	3.2.1
Type	devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As sinon is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Status Details

❌ continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details

Commits

The new version differs by 24 commits.

e9f40a2 Rename Changelog.txt to History.md
40edb3e Update docs/changelog.md and set new release id in docs/_config.yml
27986c8 Add release documentation for v3.3.0
85f30b5 3.3.0
7d45683 Update Changelog.txt and AUTHORS for new release
10906a7 Merge pull request #1560 from servel333/nested_property_matcher
a54b38c Fixes docs for error.
04ba963 Adds sinon.match.hasNested
5fbd9ee Merge pull request #1549 from killmenot/fix-1442
0a34cf5 Merge pull request #1550 from kuba-orlik/patch-1
a90f3ce Merge pull request #1558 from fatso83/fix-eslint-error
32e4516 Update code to stricter linting
212e91d Fix eslint peerDependencies error
5606815 Fix double backticks in inline code examples
af30213 fix #1442

There are 24 commits in total.

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.

Your Greenkeeper Bot 🌴

An in-range update of eslint is breaking the build 🚨

Version 4.7.2 of eslint just got published.

Branch	Build failing 🚨
Dependency	eslint
Current Version	4.7.1
Type	devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As eslint is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Status Details

❌ continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details

Release Notes

v4.7.2

4f87732 Fix: Revert setting node.parent early (fixes #9331) (#9336) (Teddy Katz)

Commits

The new version differs by 3 commits.

e164397 4.7.2
b7818ba Build: changelog update for 4.7.2
4f87732 Fix: Revert setting node.parent early (fixes #9331) (#9336)

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.

Your Greenkeeper Bot 🌴

An in-range update of eslint is breaking the build 🚨

Version 4.8.0 of eslint just got published.

Branch	Build failing 🚨
Dependency	eslint
Current Version	4.7.2
Type	devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As eslint is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Status Details

❌ continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details

Release Notes

v4.8.0

3f2b908 New: add option to report unused eslint-disable directives (fixes #9249) (#9250) (Teddy Katz)
ff2be59 Fix: dot notation rule failing to catch string template (fixes #9350) (#9357) (Phil Quinn)
b1372da Chore: remove sourceCode property from Linter (refs #9161) (#9363) (Teddy Katz)
cef6f8c Docs: remove line about removing rules from semver policy (#9367) (Teddy Katz)
06efe87 Fix: Add meta element with charset attribute. (#9365) (H1Gdev)
458ca67 Docs: update architecture page (fixes #9337) (#9345) (Victor Hom)
1c6bc67 Fix: special EventEmitter keys leak information about other rules (#9328) (Teddy Katz)
d593e61 Docs: update eslint.org links to use https (#9358) (Teddy Katz)
38d0cb2 Fix: fix wrong code-path about try-for-in (fixes #8848) (#9348) (Toru Nagashima)
434d9e2 Fix: Invalid font-size property value issue. (#9341) (H1Gdev)
a7668c2 Chore: Remove unnecessary slice from logging utility (#9343) (Gyandeep Singh)
2ff6fb6 Chore: remove unused arguments in codebase (#9340) (Teddy Katz)

Commits

The new version differs by 14 commits.

8ebb034 4.8.0
916a2d7 Build: changelog update for 4.8.0
3f2b908 New: add option to report unused eslint-disable directives (fixes #9249) (#9250)
ff2be59 Fix: dot notation rule failing to catch string template (fixes #9350) (#9357)
b1372da Chore: remove sourceCode property from Linter (refs #9161) (#9363)
cef6f8c Docs: remove line about removing rules from semver policy (#9367)
06efe87 Fix: Add meta element with charset attribute. (#9365)
458ca67 Docs: update architecture page (fixes #9337) (#9345)
1c6bc67 Fix: special EventEmitter keys leak information about other rules (#9328)
d593e61 Docs: update eslint.org links to use https (#9358)
38d0cb2 Fix: fix wrong code-path about try-for-in (fixes #8848) (#9348)
434d9e2 Fix: Invalid font-size property value issue. (#9341)
a7668c2 Chore: Remove unnecessary slice from logging utility (#9343)
2ff6fb6 Chore: remove unused arguments in codebase (#9340)

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.

Your Greenkeeper Bot 🌴

An in-range update of should is breaking the build 🚨

Version 13.1.0 of should just got published.

Branch	Build failing 🚨
Dependency	should
Current Version	13.0.1
Type	devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As should is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Status Details

❌ continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details

Release Notes

13.1.0

New

Now all zero argument assertions throw TypeError in case any argument passed to them.
Aliased .fulfill/.fulfilledWith to .resolve/.resolvedWith`

Fixes

TS definition fixed to allow such imports:

import should from 'should';

Commits

The new version differs by 6 commits.

c807e9d Release 13.1.0
8acfba1 Merge pull request #154 from citizensas/master
c12afd0 chore: should has no default export
4a846b1 Fill history
f5c9cc3 Added check for zero argument assertions.
fe6b136 Added .resolved, .resolvedWith as aliases to .fulfilled, .fulfilledWith

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.

Your Greenkeeper Bot 🌴

If fiber fails, command result does not get prototype applied

When this happens, commandPromise does not get prototype applied to the result.

https://github.com/webdriverio/wdio-sync/blob/master/index.js#L197

An in-range update of babel-eslint is breaking the build 🚨

Version 8.0.1 of babel-eslint just got published.

Branch	Build failing 🚨
Dependency	babel-eslint
Current Version	8.0.0
Type	devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As babel-eslint is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Status Details

❌ continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details

Release Notes

v8.0.1

v8.0.1

Handle optionalCatchBinding: #521

Commits

The new version differs by 2 commits.

6c7e3d0 8.0.1
5742b71 Adding optionalCatchBinding to plugins. (#521)

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.

Your Greenkeeper Bot 🌴

0.5.10: executeHooksWithArgs(...).finally is not a function

The following test was working when I had wdio-sync 0.5.8. I think 0.5.10 broke it.

import {expect} from 'chai'
import Promise from 'bluebird'
import 'core-js'
import 'regenerator-runtime/runtime'

describe('integration test setup', () => {
  it('page loads with correct title', function () {
    browser.url(process.env.APP_URL)
    const title = browser.getTitle()
    expect(title).to.equal('jcore.io')
  })
})

Now with wdio-sync 0.5.10 I get the following error:

1) integration test setup page loads with correct title:
executeHooksWithArgs(...).finally is not a function
running phantomjs
TypeError: executeHooksWithArgs(...).finally is not a function
    at Context.<anonymous> (index.js:8:13)
    at new Promise (/usr/src/app/node_modules/core-js/modules/es6.promise.js:191:7)

setup build process for PRs

If someone proposed a PR we should ensure linting and unit tests as well as coverage is covered. This requires to write initial unit tests of course.

Allow easier upgrade procedure by using method names to differentiate between sync and async behavior

sync mode:

it('...', function () {
    // ...
});

async mode:

it('...', function async () {
   // ...
});

Renamed `*Async` commands conflict with those already defined

I noticed that wrapAsync in https://github.com/webdriverio/webdriverio/blob/562db5d1b90b2f7d34d4c6b282f087c9eb07a79e/lib/helpers/wrapAsync.js#L22 moves a synchronous command into the main commandName space, but copies the async equivalent to commandName + 'Async'. This doesn't work where there's already an equivalent - the executeAsync command thereafter uses the asynchronous version of execute, which is not what's desired.

I think the exact problem is replicated in this repo, at https://github.com/webdriverio/wdio-sync/blob/master/index.js#L17.

webdriverio-boneyard / wdio-sync Goto Github PK

wdio-sync's People

Contributors

Stargazers

Watchers

Forkers

wdio-sync's Issues

Version 4.7.1 of eslint just got published.

Version 4.0.1 of sinon just got published.

Version 3.5.3 of mocha just got published.

3.5.3 / 2017-09-11

🐛 Fixes

Version 13.1.3 of should was just published.

Version 4.9.0 of eslint was just published.

Version 4.7.0 of eslint just got published.

The problem

Actual

Expected

assert

throw

webdriverio api

Environment

Code To Reproduce Issue

Version 4.0.1 of mocha was just published.

4.0.1 / 2017-10-05

🐛 Fixes

Version 3.5.1 of mocha just got published.

3.5.1 / 2017-09-09

📰 News

🐛 Fixes

🔩 Other

Version 5.2.1 of eslint-plugin-node was just published.

Version 5.2.0 of eslint-plugin-node just got published.

Bug fixes

Version 4.10.0 of eslint was just published.

Version 3.6.0 of eslint-plugin-promise was just published.

Version 2.16.1 of np was just published.

Context

Stactrace

The problem

Environment

Details

Version 2.8.0 of eslint-plugin-import was just published.

Version 13.1.2 of should was just published.

Version 3.5.2 of mocha just got published.

3.5.2 / 2017-09-10

🐛 Fixes

Version 4.1.0 of sinon was just published.

Version 2.4.0 of eslint-plugin-import just got published.

Reproduction steps

Debugging

Version 13.1.1 of should was just published.

Version 4.0.2 of sinon was just published.

Version 3.3.0 of sinon just got published.

Version 4.7.2 of eslint just got published.

Version 4.8.0 of eslint just got published.

Version 13.1.0 of should just got published.

New

Fixes

Version 8.0.1 of babel-eslint just got published.

v8.0.1

Recommend Projects

Recommend Topics

Recommend Org