Giter Site home page Giter Site logo

Comments (11)

FredericHeem avatar FredericHeem commented on July 16, 2024 4

The PR creates 2 issues:

  • Even if node-zopfli is not used, end users need to install python and a C++ compiler which is really annoying especially on windows.
  • Behind a corporate firewall and with github blocked, node-zopfli cannot be installed.

What's your opinion of creating a new webpack plugin that supports node-zopfli and remove it from this package ?

from compression-webpack-plugin.

DNx5 avatar DNx5 commented on July 16, 2024 2

i have a problem with node-zopfli on windows too, after downloading and installing gigs of visual studio/sdk and other things but still can't get it to work for days. in the end I just manually change the version of node-zopfli inside compression-webpack-plugin's package.json into 2.0.0 and then it works fine.

from compression-webpack-plugin.

ShaneCourtrille avatar ShaneCourtrille commented on July 16, 2024 1

Or the node-zopfli version dependency needs to be better maintained. The compiled binaries that would allow usage without python/VC++ for node v4 are only available for node-zopfli 2.x as per here

from compression-webpack-plugin.

ai avatar ai commented on July 16, 2024

@sokra https://www.npmjs.org/package/node-zopfli

from compression-webpack-plugin.

sokra avatar sokra commented on July 16, 2024

PR? "optionalDependency" as it's a native module.

from compression-webpack-plugin.

ai avatar ai commented on July 16, 2024

Yeap, I will try to make PR but only after 23 of Oct (sorry :) ).

Maybe we should use it by default? In one hand it is slow. But it is good practice.

from compression-webpack-plugin.

stephanos avatar stephanos commented on July 16, 2024

@ai still interested?

from compression-webpack-plugin.

ai avatar ai commented on July 16, 2024

Nope, I moved to Gulp.

from compression-webpack-plugin.

generalov avatar generalov commented on July 16, 2024

@DNx5 try to install VC++ and Python on Windows with https://www.npmjs.com/package/windows-build-tools (it takes about 5 minutes on my machine).

from compression-webpack-plugin.

FredericHeem avatar FredericHeem commented on July 16, 2024

Or add optional=false in your .npmrc to avoid installing unnecessary dependencies.

from compression-webpack-plugin.

michael-ciniawsky avatar michael-ciniawsky commented on July 16, 2024

@FredericHeem @DNx5 @generalov @ShaneCourtrille If one of you guys still have issues regarding this plugin and windows useage please open a new issue 😛

from compression-webpack-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.