Comments (9)
As @h4l said:
If so the reason is that 0.3.1 changed the arguments of the algorithm function. See #25. You need to change the signature to function(buf, options, cb)
So 0.3.1 of compression-webpack-plugin changed the API that the angular2-webpack-starter package relies on. The thing is, there's already an open issue that requests the change to be reversed, or at least optional (sic). I probably wouldn't go nuts changing that call on all your machines, if you can postpone it.
from compression-webpack-plugin.
Which version of compression-webpack-plugin
are you using and which options are you passing?
from compression-webpack-plugin.
version: "0.3.1"
from compression-webpack-plugin.
Are you providing your own function with the algorithm
option like this?:
module.exports = {
context: __dirname + "/app",
entry: "./entry",
output: {
path: __dirname + "/dist",
filename: "bundle.js"
},
plugins: [
new CompressionPlugin({
algorithm: function(buf, cb) {
zlib.gzip(buf, {}, cb);
}
})
]
};
// Results in:
$ webpack
zlib.js:227
callback(null, buf);
^
TypeError: object is not a function
at Gzip.onEnd (zlib.js:227:5)
at Gzip.emit (events.js:129:20)
at _stream_readable.js:908:16
at process._tickCallback (node.js:355:11)
If so the reason is that 0.3.1 changed the arguments of the algorithm function. See #25. You need to change the signature to function(buf, options, cb)
from compression-webpack-plugin.
I get this error too, on my home machine, but not at work with the same project. It must some version that is different between environments.
"If you do, this is most likely a problem with the angular2-webpack-starter package,"
`zlib.js:227
callback(err, buf);
^
TypeError: callback is not a function
at Gzip.onEnd (zlib.js:227:5)
at emitNone (events.js:85:20)
at Gzip.emit (events.js:179:7)
at endReadableNT (_stream_readable.js:913:12)
at _combinedTickCallback (node.js:383:13)
at process._tickCallback (node.js:407:11)
$ npm -v compression-webpack-plugin
3.8.3
$ node --version
v5.9.0
$ npm -version
3.8.3
from compression-webpack-plugin.
I can confirm a signature change will fix the problem with angular2-webpack-starter package. You need to edit helper.js
from this:
function gzipMaxLevel(buffer, callback) {
return zlib['gzip'](buffer, {level: 9}, callback)
}
to this:
function gzipMaxLevel(buffer, option, callback) {
return zlib['gzip'](buffer, {level: 9}, callback)
}
from compression-webpack-plugin.
Thanks, I made this change on the machine where "build:prod" was failing and verified it was fixed. What library version caused the need for this change? Is this a breaking change for the machines that were working? I assuming I'll need to bring all our machines to some minimum version of that library.
from compression-webpack-plugin.
This error also occurs when using compression-webpack-plugin with node 0.10, which doesn't support the options parameter for gzip.
As a workaround I used the following code:
plugins: [
new CompressionPlugin({
algorithm: function(buffer, options, callback){
zlib.gzip(buffer, callback);
}
})
]
from compression-webpack-plugin.
Will be fixed by either #26 , #27 discussion moved to the respective PR's, feedback highly welcome 😛 . Vote with 👍 / 👎 on the opening post of the PR you prefer
from compression-webpack-plugin.
Related Issues (20)
- Getting error TS1005: '?' expected HOT 2
- Always 404, I don't know why, HOT 2
- gzipped css not updated in html file HOT 19
- compress images not work HOT 2
- TypeError: Cannot read properties of undefined (reading 'tapPromise') HOT 1
- Allow usage of 6.x version without md4 HOT 4
- ERROR in Conflict: Multiple assets emit different content to the same filename css/.gz HOT 1
- Restoring failed for CompressionWebpackPlugin; HookWebpackError: this._obj.updateHash is not a function HOT 5
- Some of the files ignored during build compression HOT 10
- How to do this compression from express? HOT 1
- How to use deleteOriginalAssets is true ? HOT 2
- Compressed build now working on browser HOT 6
- Version 6 (for Webpack 4) does not work on Node 18+ HOT 10
- Let users exclude files or folder from deleting original assets. HOT 1
- Compression-webpack-plugin running before HtmlCriticalWebpackPlugin completes. HOT 2
- Ability to exclude files from deletion after zipping. HOT 1
- Type definition `BasePluginOptions` property `test` should use `Rules`, not `Rule`
- compression-webpack-plugin .woff compression is not supported HOT 3
- Bug: `deleteOriginalAssets: true` removes the `.js.LICENSE.txt` files HOT 3
- Bug: `deleteOrigianlAssets: true` breaks the build badly... HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from compression-webpack-plugin.