webrtc-rs/sctp-proto

SCTP in Rust with Sans-IO

A pure Rust implementation of SCTP in Sans-IO style

sctp-proto's Issues

attempt to add with overflow

0.1.7/src/queue/reassembly_queue.rs:337:17:
attempt to add with overflow
stack backtrace:
0: rust_begin_unwind
at ./rustc/b51b6e8215aff52b3bb5afa74b3b4e8358600ca0/library/std/src/panicking.rs:645:5
1: core::panicking::panic_fmt
at ./rustc/b51b6e8215aff52b3bb5afa74b3b4e8358600ca0/library/core/src/panicking.rs:72:14
2: core::panicking::panic
at ./rustc/b51b6e8215aff52b3bb5afa74b3b4e8358600ca0/library/core/src/panicking.rs:144:5
3: sctp_proto::queue::reassembly_queue::ReassemblyQueue::read
4: sctp_proto::association::stream::Stream::read
5: str0m::sctp::RtcSctp::do_poll
6: str0m::sctp::RtcSctp::poll

add with overflow stream.rs:456:13

Hitting a panic here:

thread 'tokio-runtime-worker' panicked at 'attempt to add with overflow', /secret_path_here/d5cf6c4d7dd7baa0/sctp-proto-0.1.4/src/association/stream.rs:456:13

   // RFC 4960 Sec 6.6
    // Note: When transmitting ordered and unordered data, an endpoint does
    // not increment its Stream Sequence Number when transmitting a DATA
    // chunk with U flag set to 1.
    if !unordered {
        self.sequence_number += 1;
    }

This should probably be a wrapping add?