Comments (3)
kraftner
commented on August 11, 2024
Okay I take that "flawlessly" back because using one of those other hooks ends up with nested <form> tags. Maybe this was the reason it was done like this in the first place.
from wcm-avatar.
franz-josef-kaiser
commented on August 11, 2024
@kraftner Yes, that was the reason – which I forgot, but now that you mention it …
Maybe a quick PR with a note for the README? Documenting "design decisions" in the form of a note to our later selfs might not be too stupid. Helped me in some cases with other projects.
from wcm-avatar.
kraftner
commented on August 11, 2024
Yeah for now adding this to the docs probably is fine.
But it should still be possible to switch the position, it just means we need to piggyback on the main form instead of rolling our own.
from wcm-avatar.
Related Issues (20)
- Add better labels for GitHub
- Default/Fallback avatar HOT 1
- Disable Multi-Selection HOT 1
- Multi Uploader breaks when Upload fails HOT 3
- Helpers for common checks HOT 4
- Create *.pot file HOT 4
- Use correct text domain
- AvatarScriptsService lacks check for permissions HOT 1
- Reconsider using file_get_contents() in UnderscoreTemplateScripts HOT 11
- Make Plugin work for users without `upload_files` permission HOT 2
- Remove (apparently) unused AdminStylesService HOT 3
- Avatar Settings Page ends up weird HOT 3
- As a user who uploaded a custom avatar, I do not want to get fooled about using Gravatar HOT 6
- Uploader broken HOT 3
- AvatarBrowserUploaderSaveService breaks on non-english locale HOT 2
- AvatarMIMELimitService limits mime types for all uploads, but only for the browser-uploader HOT 3
- AvatarUploadSizeLimit only affects multi-uploader (plupload)
- AvatarBrowserUploaderSaveService nests errors one level to deep HOT 1
- AvatarDimensionLimitService and AvatarExistsLimitService only affect Multi-Uploader
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wcm-avatar.