Reconsider using file_get_contents() in UnderscoreTemplateScripts

[wecodemore]

Reconsider using file_get_contents() in UnderscoreTemplateScripts

[gmazzap]

My proposal here: dev...UnderscoreTemplateEnqueuer

Completely untested...

[gmazzap]

@franz-josef-kaiser will hate me for this... but maybe sitting on top of wp_enqueue_script is the wrong thing to do...

allow_url_fopen to off is a thing that make sense IMO, I would set it like that on my server, and doing that file_get_contents with URL will fail anyway.

Surely we could use HTTP API, but honestly there should be a better approach...

[kraftner]

So I gave this a short test run - seems like it's working as intended. Thanks again @Giuseppe-Mazzapica !

[kraftner]

The more I think about it we probably can't easily get rid of going via the URL as we're sitting on top of wp_enqueue_script.

The issue I mentioned probably can and should be fixed with properly configuring the Server...

Anyway I think we should be trying to get the file earlier in that method and do something more graceful than outputting empty templates and a bunch of Warnings.

[franz-josef-kaiser]

@Giuseppe-Mazzapica It's just code and I am not married to it. Every input that makes things better or closes a gap is appreciated. Setting allow_url_fopen to off is a more than valid approach.

Added both labels now as I am not sure how to treat this and there are no alternatives so far. I need some time and brain to work on it, but currently I am mostly brain dead after work.

[franz-josef-kaiser]

@kraftner can you elaborate this?

Reason why I'm asking is that I've just run into an issue while working on a dev site with a self-signed certificate where this fails as the server (somewhat ironically) isn't aware of his own self-signed certificate.

[franz-josef-kaiser]

@Giuseppe-Mazzapica LGTM! Can you make that a PR?

[gmazzap]

@franz-josef-kaiser Did you take the time to test it? Maybe @kraftner can do it? Also, I think some love on code style is needed...

[kraftner]

First of all: Thanks @Giuseppe-Mazzapica !

Okay so I gave this a quick look: First of all have you been too scared of the hate of @franz-josef-kaiser to stick with wp_enqueue_script? 😉

Secondly I just pushed some changes to actually make that code run. 😉

[franz-josef-kaiser]

The last reference above this message here is wrong. I merged the wrong branches (which is fixed and reverted).

[kraftner]

already fixed by #46