wei2912/pe

Hello! I'm Wei En, a recent graduate from the National University of Singapore with a bachelor's degree in Computer Science and Mathematics. My current interests lie towards building robust and efficient machine learning methods, especially in limited data regimes, as well as integrating aspects of deep learning theory into practice.

Outside of research, I take an avid interest in open source software engineering and am also passionate in education initiatives targeted at improving access to opportunities for the less privileged. In my free time, I like to brew a fresh cup of coffee/tea and listen to music!

pe's Issues

View: Command help message specifies that multiple indexes are allowed

The help message displayed by the View command specifies that multiple indexes are allowed:

The use of a ... is stated as such in the UG:

Items with … after them can be used multiple times including zero times.

However, this contradicts the actual functionality of the command which only allows a single index.

Help message for Framework input validation allows spaces

The help message for the input validation of Frameworks allows for spaces, as stated below:

Frameworks should only contain alphanumeric characters and spaces, and the '.' character (but not start with '.').

However, this behaviour does not match up with the actual functionality of the command and the UG (which disallows spaces).

Steps to Reproduce:

1. Start the app. Ensure app is populated with contacts.
2. Run append 1 fr/React JS. Observe error message.

Contact list display does not clearly indicate faculty and major

The contact list display does not distinguish between the "faculty" and "major" of each user. As a result, it may be difficult for new users to distinguish between both in certain cases, e.g. faculty "computing" and major "computing", and may impede their user experience when they are trying to learn how to use the interface.

Columns are cut off when app is horizontally shrunk

When the app is resized horizontally to a smaller width, the three columns of the app may be cut off, as shown below. As a result, the "Detailed Person View" and the "Organisation List" cannot be seen in their entirety.

Steps to Reproduce:

1. Start application.
2. Resize screen horizontally to the smallest possible width.

Expected:

1. The app does not allow resizing beyond a specific width which ensures that all three columns can be seen in their entirety.

Actual:

1. The app allows resizing to a width that is too small to display all three columns in their entirety.

UG: Edit command explanation contains an invalid field

In the UG, the following explanation is provided for the Edit command:

However, this explanation uses the int/ field which is not a valid field, to my knowledge.

Addtoorg/Deletetoorg: Difficult to input organisations with long names

The command design of addtoorg requires an input organisation name. However, for organisations with long names, it may be difficult for users to add people to such organisations due to screen width limitations. Since addtoorg requires the full input of an organisation name, users have no way of adding a contact to the organisation without checking the full name through other methods outside of the organisations list display.

This issue also applies to deletefromorg.

Steps to Reproduce:

1. Start the app.
2. Run addorg n/The Very Long Corporation Name Pte Ltd Exceeding Screen Width e/[email protected]. Verify that the organisation has been added.
3. Note that the organisation name is cut off on certain widths. (A less extreme input would be "The Very Long Corporation Name Pte Ltd" which is of reasonable length.)

Add/Edit: No error message is displayed when an invalid compatibility is specified

When adding/editing a person with an invalid compatibility, the command result output does not change and no error message is shown to the user after pressing "Enter". This gives the impression that the command was successfully executed, which can cause confusion.

Steps to Reproduce:

1. Start application.
2. Run the command add n/Bob e/[email protected] f/law m/Law compat/200. (Other possible inputs: -1, -400. Also reproducible with edit.)

Expected:

1. An appropriate error message is displayed to indicate that the inputted compatibility is invalid.

Actual:

1. The command result does not change and no error message is displayed. The contact list does not change.

dummy

saasd

dewedwe

Append: Accepts empty data fields with no error message

The append command accepts empty data fields without outputting an error message or making any modifications to the contact. This behaviour may be confusing to users.

Steps to Reproduce:

1. Start the app.
2. Ensure the app is populated with contacts.
3. Run append 1 l/.

Expected:

1. An error message is displayed explaining that the data field should not be empty.

Actual:

1. No error message is displayed. The command result output indicates that the data field was successfully appended, which is misleading to users.

App state after running command:

Append: Message indicates successful appending even for duplicate fields

When an existing field is appended onto a person, the error message reflected indicates that the data field has been successfully appended, when in fact no change was made to the person. This may be confusing to users.

Steps to Reproduce:

1. Start the app.
2. Run clear.
3. Run add n/Tom e/[email protected] f/computing m/computer science. Verify that Tom has been added correctly.
4. Run append 1 l/java. Verify that java has been added to Tom's languages.
5. Run append 1 l/java again.

Expected:

1. An error message is displayed indicating that Tom already has the language java.

Actual:

1. The command result outputs that the data field has been successfully appended.

Duplicate fields in different case allowed

When adding fields to a person, it is possible to add multiple fields which have different cases but are the same otherwise, e.g. Java vs java. This behaviour may be confusing to users.

Steps to Reproduce:

1. Start the app.
2. Run clear.
3. Run add n/Tom e/[email protected] f/computing m/computer science. Verify that Tom has been added correctly.
4. Run append 1 l/java. Verify that java has been added to Tom's languages.
5. Now run append 1 l/JaVa.

Expected:

1. The app recognises that java and JaVa represent the same inputs. An error message is displayed indicating that Tom already has the language java.

Actual:

1. The command result outputs that the data field has been successfully appended.

UG: Filter command does not explain OR match behaviour

The filter command explains that multiple fields can be used in this manner:

Also, an example was provided specifying that only users with the t/staff tag and t/computing tag are shown.

However, this contradicts the actual behaviour of the command, which performs an OR match on the fields. The UG should be reflected to explain this OR match behaviour, with examples corrected.

Steps to Reproduce:

1. Start the app.
2. Run clear.
3. Run add n/Person1 e/[email protected] f/law m/Law s/teamwork s/research. Verify that the person is added.
4. Run add n/Person2 e/[email protected] f/law m/Law s/teamwork s/writing. Verify that the person is added.
5. Run filter s/research s/writing. Verify that both persons are still displayed, even though they do not possess both tags.