weitieda/bottom-sheet

⬆️ A SwiftUI view component sliding in from bottom

I'm Tieda.

🎯 👨‍💻 📱 🖥

bottom-sheet's Issues

Pod spec dependency on this package

Hello. I am in the process of publishing a framework to cocoa pods. I have two dependencies, this package and kingfisher. I am able to add the dependency to kingfisher no problem in the podspec file. But this package seems to be have it specs hosted in a private repository. I am not able to use it as a dependency. I was wondering if anyone knew the url that the spec is hosted at or if anyone knew how i could handle this.

Thank you very much!

Cocoapod support

Could you also make this available with Cocoapods?

Layout with Margin after add Bottom Sheet

Hello authors,

I have a simple cart list. After add Bottom sheet to my project, I have unespected margin:

https://user-images.githubusercontent.com/7614148/109086117-bde08e80-76e9-11eb-9460-9281139417e4.png

Before add BottomSheet:

https://user-images.githubusercontent.com/7614148/109086184-e49ec500-76e9-11eb-8e2f-96dd4b1446cf.png

CartView source code: https://gist.github.com/MarcusAdriano/9affed479cd7b47cbedb5d9d940628aa

Error

...

Keyboard overlaps bottomSheet

Thanks for creating this library

I am trying to use TextEditor inside .bottomSheet. UI works as expected

However, as soon as I tap inside TextEditor, keyboard pops up and covers the bottom sheet

What can be done to readjust the bottom sheet?

This is beautiful

👏👏👏

When content is ScrollView, glitch behaviour

In full_content_draggable branch, instead of only the top bar is draggable, I've been able to make the complete content view draggable. But when content is ScrollView and scroll the content list, there's a random glitch. Haven't figured out yet.

If you have a solution, feel free to create PR.

Thanks :)

Dragging inner scroll

Hey, is there a way to move the outer view by dragging only the inner scroll?
(like in Apple Maps app, Find My by Apple, Google Maps)

for example UIKit solutions:
UBottomSheet - https://github.com/OfTheWolf/UBottomSheet
ClassPass app - https://medium.com/classpass-engineering/creating-a-fluid-scroll-experience-on-ios-faeb29be3bdb

Broken 1.0.9

Here the param geometry in: should be just geometry:

bottom-sheet/Sources/BottomSheet/BottomSheet.swift

Line 73 in 72b1809

fileprivate func sheetHeight(geometry in: GeometryProxy) -> CGFloat {

Can't dismiss bottomsheet

I found couple of issues,

1. Bottom sheet not dismiss when tap on the NavigationBar.
2. NavigationBarButton is active while present bottom sheet.

horizontal scrollView as content doesn't work

When my horizontal scrollView is longer than the bottomSheet width, we didn't see extra items:
https://user-images.githubusercontent.com/29228517/121769865-47677f80-cb66-11eb-87a9-0962f55db6d8.mp4

Flicker when using bottom sheet starting with isPresented == false

The way to reproduce is to put a simple Rectangle in the BottomSheet and start with isPresented = false. While the GeometryReader is loading, the offset is incorrect and creates a flicker.

Unable to mimic .sheet usage for project.

Forgive me please, as this is my first attempt at an issue and I'm new to programming. I am trying to utilize your wonderful SPM project in my own application.

@State var presentedLocation: Location?
           
 .sheet(item: $presentedLocation) { place in
    SelectedBusinessSheet(selectedBusiness: place)
}

Above is how I would call this sheet and display the data. the presentedLocation is an identifiable struct that is used to create an array of data. This method displays the sheet as desired but it looks poorly and would look better in a BottomSheet.

I am unable to mimic this method however, as displayed below, I get the following errors.

.bottomSheet(isPresented: $presentedLocation, height: 700, content: { place in
   SelectedBusinessSheet(selectedBusiness: place)
})

• Cannot convert value of type 'Binding<Location?>' to expected argument type 'Binding'
• Contextual closure type '() -> SelectedBusinessSheet' expects 0 arguments, but 1 was used in closure body

I apologize if these are obvious errors that can be easily rectified. Any help is appreciated!

Can’t use scrollview,

The scrollview cannot be used in the view, and the offset will be set after use