werebus / moretticamp Goto Github PK
View Code? Open in Web Editor NEWRails app for moretti.camp
License: MIT License
Rails app for moretti.camp
License: MIT License
Good to get some sort of indication that people are having trouble with the site.
This is pretty much a browser limitation, but most browsers won't display background
s on prints. Theres a work-around that works for Chrome which I used, but Firefox, Opera, and IE all won't respect that.
There may be some sort of hack involving solid images, drop-shadows or somesuch, but I couldn't think of it.
They're medium-vertical, so small icons make a horizontal icon-bar. Now with the added icons, though, the menu is too wide for the layout.
Rails 6.1 has a more robust errors API. The view needs to be adjusted a bit.
Also, minor sub-issue: this error was actually while editing an old Event
, not creating one.
Looks a little off. Double-check that the view looks pretty similar to the login screen.
Maybe show the event notes when you hover over the event?
Interestingly, the Google Calendar fetcher appears to respect the robots.txt
that I added in #3 That prevents the calendar from updating
I think I'd prefer a female voice. I should try out the others.
The invitation interface allows you to invite a user with no name. This user is invalid but persisted.
When the nameless person tries to accept the invitation, the update and sign-in fail.
Most "Back" links just go to the #index
. Would be better to go back with a fallback. Related to #30.
They're fine, but they could also be customized a bit. Modify the style a bit, provide a contact email?
When a user's session is expired, the calendar stops showing events, but the buttons will keep working. I should check for 401s in the js and redirect to login when that happens.
Then you could delegate e.g. looking it up by symbol:
moretticamp/app/mailers/user_mailer.rb
Lines 9 to 11 in 2ed5f2c
to a class method.
Can't be that bad, right?
I should spend a bit of time making the printout of the calendar look OK.
There may be PDFs other than the LaTeX ones in campdocs, maybe a generic document store would be better?
For added professionalism, it might be nice if the Github pages branch of @werebus/camp-docs had a CNAME pointing to it. Something like docs.moretti.camp?
Simple matter of nil
checking and saying "There are no more events"
The new version is way more suitable to Webpack
I don't send password resets to users who don't have a password. It would still be nice to send them something, though.
[This line][1] doesn't do what I intended. The default behavior of find a template and try to render it still happens, but there isn't a "pdf" template.
Desired behavior with no defined Season
Noticed that events weren't updating. This might have broken in 925fa61 because of a misunderstanding in #37 about what a DTSTAMP
is.
See https://stackoverflow.com/a/37348467 but essentially the DTSTAMP
is when the VEVENT
message is created, not the event internally in the application. For dynamic feeds, it should probably be "now".
I was thinking that it would be nice to email people occasionally about camp-related news. But that perhaps people who are in another state, or who only really visit on the three weekends won't care. Maybe a per-user setting, and an interface to generate messages?
The following is a little unpleasant:
Is it a good idea to allow people to unlink their account? What should the flow be? We don't want to allow users to end up in a state where they have no oauth credentails nor a password. Because updating your password requires you to enter your "existing" password.
Re-invite perhaps?
This method isn't at all secure. We have a method in the User
model that is, we should be using that.
I added the content_for stuff:
But it's never used.
With 8ce4e87, I punted and agreed to just pretend that my CSS is actually Javascript.
This results in some pretty noticeable FOUC on every page load. Webpacker insists that it can emit regular CSS...
ActionView::Template::Error (undefined method `>' for nil:NilClass):
9: = link_to new_event_path do
10: = icon 'calendar'
11: %span New Event
12: - if current_user.invitation_limit > 0
13: %li
14: = link_to new_user_invitation_path do
15: = icon 'user-plus'
app/views/events/index.html.haml:12:in `_app_views_events_index_html_haml___2717908256454509502_70230142408120'
invitation_limit
defaults to nil
. This breaks for all non-admins.
It looks like a Fullcalendar theme isn't too tough to implement: here's the bootstrap 4 one.
It might be a lot cleaner than all the CSS overriding.
For email good-citizen purposes, we should include the un-rendered markdown as a text/plain part.
Be good to use Rails assets instead of vendor/assets
for foundation-datepicker
Look into something like Stripe. Camp has a maintenance account, I think its possible to deposit into it.
I'm pretty excited; this should be a great upgrade.
Ran my feed through a validator and found some errors and warnings:
CRLF
DTSTAMP
property โ Essentially, updated_at
.If your invitation is expired, you just get a silent redirect when you try to accept. Also the symptom of #38.
It'd be interesting to play with Active Job. The notification think might be a place to experiment.
The only way to add new users at the moment is the rake task, but it'd be good to have something in the web ui. I think devise invitable can just do this, might have to make a few tweaks and construct a view.
Might be fun to experiment with https://github.com/twitter/secure_headers Not very high stakes, and we're already doing HSTS, CSP.
We need one. It's a private site, so we don't need anything indexed.
I think browser support for clipboard.js is good enough that we could lose the flash dependency of zero-clipboard.
Not free anymore. Try SES?
Default scopes are confusing and bad. There's probably very few places we have a alphabetic list of all users. just add an order.
Not only is there #6, but on many browsers the printout still features a stretched Saturday column because the FullCalendar js hasn't finished reacting to the change in size by the time the browser calls the page rendered. Would a 1 or 2 second delay fix it? Sounds hackey, but...
Alternate solutions:
When creating new events, the default in the drop-down should still be the current user.
Created a test user and realized that neither first nor last name are required, which makes the site a little tough to use -- no link to profile in header, etc
You can see an event note by hovering over it, but it isn't visually indicated whether a particular event has a note.
This is especially a problem on mobile where "hovering" isn't a thing, so you have to tap on the event to see if it has a note โ a wasted trip if it doesn't.
Probably, some sort of unicode hackery can be used here.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.