weseek/growi

:anchor: GROWI - Team collaboration software using markdown

growi's Issues

Bug(Derived from the official): Tabs(a[data-toggle="tab"][href="#..."]) push browser history twice

Environment

• [crowi-plus] 1.2.13
• [node.js] 6.10.0
• [browser] Firefox 52.2.1

How to reproduce? (再現手順)

1. Goto /admin/customize and enable "タブ変更をブラウザ履歴に保存" option
2. Access to any wiki page
3. Click "Edit" tab ("#edit-form" hash will be added to url)
4. Click "History" tab ("#revision-history hash will be added to url)
5. Click "Edit" tab again ("#edit-form" hash will be added to url)
6. Browser back x N times

What happens? (症状)

• 1st back: "#revision-history" is shown
• 2nd back: "#revision-history" is still shown
• 3rd back: "#edit-form" is shown
• 4th back: "#edit-form" is still shown
• 5th back: the page without hash is shown

What is the expected result? (期待される動作)

• 1st back: "#revision-history" is shown
• 2nd back: "#edit-form" is shown
• 3rd back: the page without hash is shown

Note

• This is a bug from official Crowi

Bug(Derived from the official): Couldn't refresh slack token

Environment

• [crowi-plus] 1.2.16

How to reproduce? (再現手順)

1. Setup Slack App
2. Configure integration to Slack in http://localhost:3000/admin/notification
3. Remove Slack App
4. Setup Slack App 2
5. Configure integration to Slack in http://localhost:3000/admin/notification
   1. Update clientId and clientSecret
   2. Click Reconnect to Slack button

What happens? (症状)

• Doesn't work
• Failed to auth

  info: ** API CALL: https://slack.com/api/chat.postMessage
  POST /_/edit 302 23.891 ms - 64
  GET /Life/hoge 200 57.057 ms - 27094
    crowi:util:slack Post error invalid_auth { ok: false, error: 'invalid_auth' } +529ms
    crowi:util:slack Sent data to slack is: { channel: '#botkit-test',
    username: 'Crowi',
    text: ':up: yuki updated /Life/hoge',
    attachments: '[{"color":"#263a3c","author_name":"@yuki","author_link":"http://localhost:3000/    user/yuki","title":"/Life/hoge","title_link":"http://    localhost:3000/5966686e54aff4518cac1d31","text":":pencil2:     ...\\naaabbbcccddd","mrkdwn_in":["text"]}]',
    token: 'xoxop-...' } +1ms
  

  • token: 'xoxop-...' is old.

What is the expected result? (期待される動作)

• The variable bot of lib/util/slack.js refresh when reconnect to Slack

Note

• This bug is derived from the official

Imprv: impl useful buttons

TODO

• add the button to edit page on header
• add the buttons to edit page and scroll to section headers
  • click to scroll to the line of the section header

Imprv: Browsing articles without account

Refer to: crowi/crowi#155

Bug: Top menu is not shown properly

From #79

Environment

• [OS] iOS 10.3(iPhone SE)
• [crowi-plus] 1.1.10
• [node.js] 6.10.3
• [browser] Google Chrome for iOS

How to reproduce? (再現手順)

See #79

What's happen? (症状)

What is the expected result? (期待される動作)

See #79

Note

Bag: Path including round bracket makes something bad

Environment

• [OS]
• [crowi-plus] 2.0.6
• [node.js] 6.10.3
• [browser] 52.3.0 (32 ビット)

How to reproduce? (再現手順) Case 1

1. create /hoge(fuga)
2. go to /hoge(fuga)/

What happens? (症状) Case

• page list doesn't show any pages

What is the expected result? (期待される動作)

• page list show list of pages correctly

Note

• Round bracket ( ) seems samething bad

Bug(Derived from the official): Firefoxで開いた編集画面からCtrl+(Shift+)Tabでブラウザタブを切り替えるとインデントが増減する

Environment

• [OS] サーバ: Alpine Linux on Docker 17.06 on Ubuntu 16.04
• [crowi-plus] 1.1.12
• [node.js] 6.10.3 (Docker付属)
• [browser] Firefox 54.0.1 (Chrome 59・IE11では再現なし)

How to reproduce? (再現手順)

1. Firefoxで複数のタブを開く
2. タブの1つでWikiにアクセスし、適当なページの編集画面に入る
3. 編集画面のエディタをアクティブにする (エディタにフォーカスを合わせる)
4. Ctrl+Tab・Ctrl+Shift+Tabで前後のタブに切り替える (マウスクリックによるタブ切り替えでは再現しません)

What happens? (症状)

• Ctrl+Tabで次のタブに切り替えるとインデントが増える
• Ctrl+Shift+Tabで前のタブに切り替えるとインデントが減る

What is the expected result? (期待される動作)

• Ctrl+(Shift+)Tabでタブを切り替えてもインデントの増減が起こらない

Note

恐らくフロントエンドの仕様とFirefoxの仕様が噛み合わずに起こった結果だと思います。よろしくお願いします。

Imprv: Integrated Blank Page

Current Behavior

• '/*/$' is routing to page.pageListShow
• '/*' is routing to page.pageShow
• Edit screen is displayed when a user accesses to blank page

Improved Behavior

• '/*/$' and '/*' is routing to same page (based on page.pageListShow)
• New edit screen is displayed when a user accesses to blank page (based on page.pageListShow)

Bug: Top menu is not shown properly

Environment

• [OS] iOS 10.3(iPhone SE)
• [crowi-plus] 1.1.9
• [node.js] 6.10.3
• [browser] Google Chrome for iOS

How to reproduce? (再現手順)

Access the top page

What's happen? (症状)

Search bar and the hamburger menu are unexpectedly merged

Stack Trace

What is the expected result? (期待される動作)

Note

Feature: delete comment

refs crowi/crowi#178

Bug(Derived from the official): An Input linker breaks the adjacent linker

Angle bracket linker

* </aaa/bbb
* </aaa/bbb/ccc>

outputs

・<a href="/aaa/bbb
・</aaa/bbb/ccc">/aaa/bbb
・

Square bracket linker

* [/aaa/bbb
* [/aaa/bbb/ccc]

outputs

・<a href="/aaa/bbb
・[/aaa/bbb/ccc">/aaa/bbb
・[/aaa/bbb/ccc

Imprv: detach code blocks before preProcess

What happens?

crowi/crowi #201

What is the expected result?

Every code blocks are not processed by preProcessors.

Bug: all strings appear on presentation mode

Environment

• [OS] Win10/Mac
• [crowi-plus] 1.1.10
• [node.js] 6.10.3
• [browser] Firefox 50.1.0/Chrome 58.0

How to reproduce? (再現手順)

1. create a new page and save
2. go to presentation mode

What happens? (症状)

• all strings appear in the page

What is the expected result? (期待される動作)

• only strings of the first header appear

Note

• This issue occurs only when the first time switching to presentation mode after page has loaded.
• When focusing presentation screen and pressing Esc twice, presentation screen is displayed as expected.

Imprv: Move/Delete recursively

TODO

• recursively option for Move operation
• recursively option for Delete operation
• recursively option for Put back / Delete completely operations

Imprv: replace inline-attachment with Dropzone.js

Feature: save with Ctrl+S

Imprv: Page title to copy

TODO

• add spaces with css to before and after '/'
  • use React Component
• add button to copy to clipboard
• show tooltip when copy has successed

Feature: LDAP support

社内でLDAP認証によってユーザーの管理をしている場合、crowi-plus側で新しくユーザー情報を登録するのは二度手間になってしまいます。
そのため、crowi-plus側でLDAPに対応していただくことはできませんでしょうか。

ご検討よろしくお願いいたします。

Support: notify to Slack

use https://github.com/wantedly/step-pretty-slack-notify

Imprv: Switch paularmstrong/swig to node-swig/swig-templates

https://github.com/node-swig/swig-templates

paularmstrong/swig is no longer maintained.

Imprv: delete page and redirect functions

Purpose

resolve crowi/crowi #121 #200

TODO

• add completely remove option to wrench(pulldown) menu
• add completely remove button to trash page
• add remove redirect button
• add link to the existing page when unportalizing failed

Bug: `npm run server:dev:watch` doesn't work on Google Chrome

Environment

• Win 10
• node.js 6.10.0
• npm 4.5.0
• Google Chrome 57.0.2987.133

How to reproduce?

1. run server with watch option

   npm run server:dev:watch

2. open locahost:3000/login.html

3. edit and save /lib/views/login.html

What's happen?

server crash with following error

Error: read ECONNRESET
    at exports._errnoException (util.js:1022:11)
    at TCP.onread (net.js:569:26)

What is the expected result?

doesn't crash

Imprv: replace marked

https://github.com/markdown-it/markdown-it
https://github.com/jonschlinkert/remarkable

Feature: duplicate page

• レンチメニューの「移動」の下あたりに「コピーして新規作成」を作る
• クリックでモーダル表示、タイトルを入力してOK
• 編集画面へ
  • 先に保存して編集画面に行くか、もしくは保存せず編集画面に行って textarea に中身だけ入れた状態にするかは要検討
  • 実装が早いほうでいいかな

Imprv: Search Stage 1

TODO

• resolve warnings
• ICU Normalization
• Ngram Tokenizer
• make suggestion box more handy

Imprv: refactor comments and ensure to using React component

Code syntax highting feature does not work

I wrote a SQL code snippet like below. But the code syntax highting feature is not working.

```sql
SELECT *
FROM some_table
LIMIT 0 , 30
```

Support: write the document for developing plugins

Bug: Couldn't create page when using 'debug' module

Environment

• [crowi-plus] 1.2.15

How to reproduce? (再現手順)

1. set the environment variable DEBUG=crowi:*
2. Go to http://localhost:3000/admin/customize and set crowi-plus Simplified Behavior
   • It will have already been set if crowi-plus 1.2.15 is cleanly installed
3. Go to /
4. Create page

What happens? (症状)

• Couldn't create page

(node:14956) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 2): ReferenceError: page is not defined

What is the expected result? (期待される動作)

• Create page successfully

Imprv: setup pino

Branch

support/use-pino2

Conclusion

• use morgan in development
  • useful colored log, show time taken
• use pino-clf in production
  • faster

Imprv: Slack Incoming Webhooks

TODO

• Admin page for input WebhookURL and checkbox for isPrioritized
• Use Incoming Webhooks when Slack App is not configured or it is prioritized

Imprv: Ensure to select Mode

TODO

• Ensure to be able to select whether use #72
• Ensure to be able to disable Timeline feature

Imprv: Selective batch deletion in search result page

Target Page

https://demo.crowi-plus.org/_search?q=Sandbox

Flow

1. change mode to batch deletion
2. check (by user)
3. click delete button (by user)
   1. confirm on modal window
4. call API
5. reload search result page

Support: IE11 (Experimental)

refs crowi/crowi#187

Bug: Child pages under `/trash` are not shown when applying crowi-plus Simplified Behavior

Environment

• [crowi-plus] 1.12.14
• [node.js] 6.10.0
• [browser] Firefox 52.2.1

How to reproduce? (再現手順)

1. set 'crowi-plus Simplified Behavior' at http://localhost:3000/admin/customize
2. create /foo and /foo/bar
3. delete (but not completely) /foo and /foo/bar
4. go to /trash/foo

What happens? (症状)

• /trash/foo/bar is not shown in /trash/foo

What is the expected result? (期待される動作)

• /trash/foo/bar is shown correctly in /trash/foo

Bug: TypeError: Cannot read property 'buildIndex' of null

Environment

• [OS] CentOS 7.3
• [crowi-plus] 1.2.0-RC
• [node.js] 6.10.3
• [browser] ?.?.?

How to reproduce? (再現手順)

1. データベース用意

   systemctl start mongod
   mongo

   use crowidb
   db.createUser({user: "crowi", pwd: "DB-PASSWD", roles: [{role: "readWrite", db: "crowidb"}]})
   

2. インストール

   cd /var/lib
   git clone --depth=1 https://github.com/weseek/crowi-plus
   
   cd crowi-plus
   npm install -g {npm,yarn} && npm upgrade -g {npm,yarn}
   yarn

3. 起動

   MONGO_URI="mongodb://crowi:DB-PASSWD@localhost/crowidb" npm start

What's happen? (症状)

以下のエラーが出力されます。

TypeError: Cannot read property 'buildIndex' of null
    at /var/lib/crowi-plus/lib/util/middlewares.js:266:13
    at Layer.handle [as handle_request] (/var/lib/crowi-plus/node_modules/express/lib/router/layer.js:95:5)
    at next (/var/lib/crowi-plus/node_modules/express/lib/router/route.js:137:13)
    at /var/lib/crowi-plus/lib/util/middlewares.js:258:12
    at Layer.handle [as handle_request] (/var/lib/crowi-plus/node_modules/express/lib/router/layer.js:95:5)
    at next (/var/lib/crowi-plus/node_modules/express/lib/router/route.js:137:13)
    at Route.dispatch (/var/lib/crowi-plus/node_modules/express/lib/router/route.js:112:3)
    at Layer.handle [as handle_request] (/var/lib/crowi-plus/node_modules/express/lib/router/layer.js:95:5)
    at /var/lib/crowi-plus/node_modules/express/lib/router/index.js:281:22
    at Function.process_params (/var/lib/crowi-plus/node_modules/express/lib/router/index.js:335:12)
    at next (/var/lib/crowi-plus/node_modules/express/lib/router/index.js:275:10)
    at logger (/var/lib/crowi-plus/node_modules/morgan/index.js:144:5)
    at Layer.handle [as handle_request] (/var/lib/crowi-plus/node_modules/express/lib/router/layer.js:95:5)
    at trim_prefix (/var/lib/crowi-plus/node_modules/express/lib/router/index.js:317:13)
    at /var/lib/crowi-plus/node_modules/express/lib/router/index.js:284:7
    at Function.process_params (/var/lib/crowi-plus/node_modules/express/lib/router/index.js:335:12)
    at next (/var/lib/crowi-plus/node_modules/express/lib/router/index.js:275:10)
    at Layer.handle [as handle_request] (/var/lib/crowi-plus/node_modules/express/lib/router/layer.js:91:12)
    at trim_prefix (/var/lib/crowi-plus/node_modules/express/lib/router/index.js:317:13)
    at /var/lib/crowi-plus/node_modules/express/lib/router/index.js:284:7
    at Function.process_params (/var/lib/crowi-plus/node_modules/express/lib/router/index.js:335:12)
    at next (/var/lib/crowi-plus/node_modules/express/lib/router/index.js:275:10)
    at /var/lib/crowi-plus/node_modules/i18next-express-middleware/lib/index.js:80:7
    at I18n.loadLanguages (/var/lib/crowi-plus/node_modules/i18next/dist/commonjs/i18next.js:357:33)
    at /var/lib/crowi-plus/node_modules/i18next-express-middleware/lib/index.js:79:13
    at Layer.handle [as handle_request] (/var/lib/crowi-plus/node_modules/express/lib/router/layer.js:95:5)
    at trim_prefix (/var/lib/crowi-plus/node_modules/express/lib/router/index.js:317:13)
    at /var/lib/crowi-plus/node_modules/express/lib/router/index.js:284:7
GET /installer 500 5.767 ms - 3027

どうかよろしくお願いいたします。

Imprv: ensure to be able to create top level page from root

Form layout is skewed when direct access with `#edit-form` hash

Environment

v1.0.0-RC11

What steps will reproduce the problem?

1. goto /anywhere/page/#edit-form

What happens?

• Layout is skewed

What is the expected result?

The same page as the is displayed when clicking the 'edit' tab is displayed.

Bug: Calling `$lsx` with no argument on CJK page will be outputted nothing

How to reproduce?

1. create a page that includes CJK strings in the path
   ex: /資料/foo
2. goto the page created now
3. write $lsx()

What is the expected result?

Output the links of child pages correctly.

Feature: Custom Script

TODO

• Add config
  • transpile and uglify
• Add editor

store images for web

Bug: Can't upload profile image

Environment

• [OS] Mac OSX
• [crowi-plus] 1.2.9-RC
• [node.js] 6.7.0
• [browser] Chrome 60.0.3112.40

How to reproduce? (再現手順)

1. move /me
2. choose image file

What happens? (症状)

• can't upload image file

What is the expected result? (期待される動作)

• image can be uploaded

Imprv: Search Stage 2

TODO

• divide resource/search/mappings.json
  • minimum, full
• ensure to select mappings from Admin page
• readingform_index_analyzer/readingform_search_analyzer
  • https://medium.com/hello-elasticsearch/elasticsearch-%E3%82%AD%E3%83%BC%E3%83%AF%E3%83%BC%E3%83%89%E3%82%B5%E3%82%B8%E3%82%A7%E3%82%B9%E3%83%88%E6%97%A5%E6%9C%AC%E8%AA%9E%E3%81%AE%E3%81%9F%E3%82%81%E3%81%AE%E8%A8%AD%E8%A8%88-352a230030dd

Bug(Derived from the official): depth of dropdown-menu

Imprv: enhanced layout

サイドバー解体

基本 esa.io 風に

• 作成者・作成日・更新日時、いいね、みた人
  • ページ内ヘッダに移動
• コメント
  • ページ最下部に展開
  • 

Bug: Redirect doesn't work when using 'crowi-plus Simplified Behavior'

Environment

• [crowi-plus] 1.2.6
• [node.js] 6.10.3
• [browser] Firefox 52.2.0

How to reproduce? (再現手順)

1. create /page1
2. move /page1 to /page2 with creating redirect
3. goto /page1

What happens? (症状)

• /page1 is shown

What is the expected result? (期待される動作)

• /page2?redirectFrom=/page1 is shown

Imprv: /admin/users

TODO

• Arrange table layout
• Show last logged in date

BugFix: delete user

Environment

• Win 10
• [crowi-plus] 1.0.5
• [node.js] 6.9.5
• [npm] 4.5.0
• [browser] Firefox 52.1.0

How to reproduce? (再現手順)

1. go to /admin/users
2. suspend any account
3. delete any account

What's happen? (症状)

• nothing happened

What is the expected result? (期待される動作)

• delete selected user account successfully

Bug: ページ新規作成時に、Ctrl+S を押してもページを保存できない

Environment

• [crowi-plus] 1.1.6
• [node.js] 6.10.3

How to reproduce? (再現手順)

1. 右上の「作成」ボタンを押し、適当なページを作成する
2. 編集画面で、「Ctrl+S」を押す

What's happen? (症状)

• 以下の Toastr が表示され、ページを保存できない

Error occured on saveing
page_id and body are required.

What is the expected result? (期待される動作)

• 正常にページを保存できる

Imprv: Ensure to be able to disable to push states with History API when tabs changes

TODO

• add an option to Admin Page
• disable codes such like window.history.pushState(...) according to the option value