Remove confusion about SP and MP saves of hybrid campaigns having the same names

[Discontinuum]

Remove confusion about SP and MP saves of hybrid campaigns having the same names

[knyghtmare]

I wonder if this is viable as a solution:

[campaign]
    #ifdef MULTIPLAYER
    id=Campaign_ID_MP
    abbrev="Campaign_MP"
    #else
    id=Campaign_ID_SP
    abbrev="Campaign"
    #endif
    type=hybrid
[/campaign]

[soliton-]

That's pretty much what they said they did as a workaround. That should not be necessary. Also we should move away from more reliance on the preprocessor.

[Discontinuum]

I made a bit different way

#define MY_CAMPAIGN TYPE ABBR
[campaign]
id=my_campaign_{TYPE}
type={TYPE}
abbrev={ABBR}
...
[/campaign]
#enddef
{MY_CAMPAIGN sp "ABBR"}
{MY_CAMPAIGN mp "ABBR MP"}

the workaround by knyghtmare seems much less reliable to me. It feels suspicious that a campaign will define itself differently depending on the preprocessor's state.

Maybe we can add an optional parameter abbrev_mp to the [campaign] tag that will apply if it's a hybrid campaign run in MP

[soliton-]

I think adding a fixed string like the "MP" you mentioned after the abbreviation is enough. If someone wants an entirely different abbreviation then they can make multiple campaigns like you showed. I don't think abbrev_mp is desirable.

[Discontinuum]

I thought at first hardcoding the "MP" prefix isn't desirable but prolly it makes sense. As you say, people may define two distinct non-hybrid campaigns if they want to