wetneb/pynif

A small Python library for NLP Interchange Format (NIF) for NER(D) systems

pynif's Issues

nif:OffsetBasedString option is missing

On the current version of pynif, any URI for Contexts and Phrases is represented as a nif:OffsetBasedString . It would be great to also cover the nif:ContextHashBasedString .

I think it can be done ensuring backguard compatibility by adding an optional argument like:

• NIFContext( hash_uri )
• NIFPhrase( hash_uri )

Then, their respective def triples(self) functions could have something like:

        if self.hash_uri:
            yield (self.uri, RDF.type, NIF.ContextHashBasedString)
        else:
            yield (self.uri, RDF.type, NIF.OffsetBasedString)

And both NIFContext and NIFPhrase def __init__ could be changed with something like this:

 def __init__( ... , hash_uri = None):
      slef.original_uri = uri if not hash_uri else hash_uri

Order of NIF contexts is random

I have a function that looks something like this:

def print_nif_contexts(filepath: str):
    with open(filepath, "r", encoding="utf8") as file:
        file_content = file.readlines()
        nif_content = "".join(file_content)
        nif_doc = NIFCollection.loads(nif_content)
        for context in nif_doc.contexts:
            print(context.uri)

The order of the contexts is random and differs from run to run.

I would expect the sort order to be the same as in the file from which the contexts are read.

Having the same order in every run would already help, but sorted(nif_doc.contexts) is not supported (TypeError: '<' not supported between instances of 'NIFContext' and 'NIFContext').

Other than that I find the package really useful so far, thanks for making this opensource :)