wework/eslint-config-wework

eslint-config-wework's Issues

Unmet peer dependencies

The problem

Eslint-config-wework has unmet peer dependencies. I am on yarn 1.0, and npm v5.4.2

Environment

• Package version: @3.0.0
• Node.js version: v8.4.0
• Browser versions:

Details

running yarn causes the following errors:

warning "[email protected]" has unmet peer dependency "[email protected]". warning "[email protected]" has unmet peer dependency "[email protected]". warning "[email protected]" has unmet peer dependency "[email protected]". warning "[email protected]" has unmet peer dependency "[email protected]". warning "[email protected]" has unmet peer dependency "[email protected]". warning "[email protected]" has unmet peer dependency "[email protected]". warning "[email protected]" has unmet peer dependency "[email protected]". warning "[email protected]" has incorrect peer dependency "[email protected]". warning "[email protected]" has unmet peer dependency "[email protected]".

Code or Steps To Demonstrate

Examples can be very helpful, but are not always necessary.

Lodash imports

The problem

@GLosch and others have made the case that import _ from 'lodash' is preferable to import { foo } from 'lodash'. Opening this to capture that concern and to open a channel for discussion.

https://github.com/eslint-plugins/eslint-plugin-lodash/blob/master/docs/rules/import.md is a nice way to enfore the named-import approach. I'm sure something exists for the whole lib approach, or we could make a custom rule.

This is also app specific and relates to things like https://github.com/lodash/babel-plugin-lodash, and https://github.com/lodash/lodash-webpack-plugin, but I agree some degree of consistency across apps here would be 💯

Prefer Lodash get

The problem

In code reviews, a common request is to use Lodash _.get in place of referencing deeply nested data structures like foo.bar.moreFoo.moreBar to avoid potential JavaScript errors that would break the page. Implementing the prefer-get rule here would take care of this.