Giter Site home page Giter Site logo

wfyson / opendatabutton Goto Github PK

View Code? Open in Web Editor NEW
3.0 3.0 1.0 1.29 MB

Initial work on an Open Data button, to identify and highlight datasets which are not accessible.

License: MIT License

JavaScript 14.99% Shell 0.29% Python 18.36% CSS 32.19% HTML 34.17%

opendatabutton's People

Contributors

loleg avatar wfyson avatar

Stargazers

 avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

Forkers

loleg

opendatabutton's Issues

Landing page for clicks

I've added a simple filter for the Twitter links (e.g. /entry/1), but clearly we had more in mind when we talked about this. Let's start putting together a clearer sketch of what users should be able to see when they click on a link.

Button gives javascript error in Firefox 26.0

Timestamp: 13/01/14 14:16:58
I've just tried to use the button in Firefox 26.0 and it gives this error.

Error: SyntaxError: return not in function
Source File: javascript:if(location.protocol=='https:'){return%20window.alert('Sorry,%20HTTPS%20websites%20are%20not%20yet%20supported%20by%20the%20Open%20Data%20Button%20:(');}%20var%20o=document.getElementById('odb-bkmlt');%20if(o!=null){o.parentNode.removeChild(o);}%20document.getElementsByTagName('body')[0].appendChild(document.createElement('script')).setAttribute('id','odb-bkmlt');document.getElementById('odb-bkmlt').setAttribute('src','http://button.datalets.ch/bookmarklet');
Line: 1, Column: 32
Source Code:
if(location.protocol=='https:'){return window.alert('Sorry, HTTPS websites are not yet suppo

This error is consistently reproducible.
This firefox is running on a 64-bit Linux installation.

Bookmarklet weighty & broken

Do we really need jQuery UI? I'm quite sure a bit of CSS would do the trick, the bookmarklet would be faster.. and it would work. Right now I'm getting .dialog() is undefined errors.

No action after clicking on the button

After drag and dropping the button to my Safary and Firefox bookmarks bars, it does not work. Regardless of what page I'm on, after clicking nothing happens.

Not sure how to figure out what is going on here. There are no warnings, no error messages. When I open the "Show All Bookmarks" window, I can see the button's address is:

javascript:document.getElementsByTagName('body')%5B0%5D.appendChild(document.createElement('script')).setAttribute('id','odb-bkmlt');document.getElementById('odb-bkmlt').setAttribute('src','http://button.datalets.ch/bookmarklet');

When I click on this "address" in the "Show All Bookmarks" window than it works.

Secure sites cannot be bookmarked

Secure websites do not allow script injection, so the button does not work. We need to figure out how to detect this and offer an explanation to the user (alert box or so).

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.