whamcloud/flow-highland

flow type files for highland.js

flow-highland's Issues

Importing stream types still causing problems

Importing Readable, Writable, and Duplex stream types is still causing flow to not work correctly. Instead of importing these types, we should use the following internal types:
stream$Readable
stream$Writable
stream$Duplex

Add `concat` method

Can you add the concat method to HighlandStream<T> class?

    concat(ys: HighlandStream<T> | Array<T>): HighlandStream<T>,

.parallel should return T

.parallel is currently returning HighlandStream, but it should return T. For example:

var readFile = _.wrapCallback(fs.readFile);
var filenames = _(['foo.txt', 'bar.txt', 'baz.txt']);

// read from up to 10 files at once
filenames.map(readFile)
   .parallel(3)
   .map((x:HighlandStreamT<Buffer>) => x.toString('utf8'))

Should be:

var readFile = _.wrapCallback(fs.readFile);
var filenames = _(['foo.txt', 'bar.txt', 'baz.txt']);

// read from up to 10 files at once
filenames.map(readFile)
   .parallel(3)
   .map((x:Buffer) => x.toString('utf8'))

Make highland readable constructor use

Stream imports are being lost

We are doing:

import type { Writable, Readable, Duplex } from 'stream';

outside of the module declaration. This causes these types to be lost. For example, say I add the following line in the .flowconfig file of a different repo:

[libs]
node_modules/@mfl/flow-highland/flow-typed

Now, I add the following line in a source file:

import { Readable, Writable } from 'stream';

I will now receive the following flow error:'

Named import from module `stream`. This module has no named export called `Readable`.

To avoid this problem we can instead import these types within the module declaration.

Add type for through with a Duplex stream

Add a type for through with a Duplex stream.

Also fixup tests and add them + eslint travis check.

Update module function overload

Update the module function overloads to add a case for stream handling.

Also, add a type for the invoke method.

Finally, Update consume so that what is pushed becomes the new return type.

Add "otherwise" method

The otherwise method needs to be added.