whatwedo/corebundle

Reusable components used by other bundles of whatwedo

corebundle's Issues

OptionsResolver should be requerd.

I get the following errors while indexing:

In AbstractFormatter.php line 46:

  Attempted to load class "OptionsResolver" from namespace "Symfony\Component\OptionsResolver".
  Did you forget a "use" statement for another namespace?

Add a twig function with possible use of formatters

Modal Action 'confirmation' option

The option "confirmation" does not exist. Defined options are: "block_prefix", "label", "attr", "icon", "route", "route_parameters", "voter_attribute", "priority", "visibility".

CoreBundle/src/Action/ModalAction.php

Lines 30 to 41 in 872512d

	namespace whatwedo\CoreBundle\Action;
	class ModalAction extends Action
	{
	/**
	* @param array<string, mixed> $options
	*/
	public function __construct(string $acronym, array $options)
	{
	unset($this->defaultOptions['confirmation']);
	parent::__construct($acronym, $options);
	}

CoreBundle/src/Action/Action.php

Lines 15 to 24 in 872512d

	protected array $defaultOptions = [
	'label' => null,
	'attr' => [],
	'icon' => null,
	'route' => null,
	'route_parameters' => [],
	'voter_attribute' => null,
	'priority' => 0,
	'confirmation' => null,
	];

Symfony4 compatibility

See: http://symfony.com/blog/helping-prepare-for-symfony-4-bundle-support

• Make bundle Symfony4 compitable
• Create a receipt for Flex
• Mark it as done on the Symfony4 Bundle Compatibility List

Implementierung CollectionFormatter

Der CollectionFormatter vebindet aktuell ohne Leerzeichen und nur mit Komma. Ich schlage vor das Verhalten von implode(',', $value) nach implode(', ', $value) anzupassen. Ziel ist eine bessere Lesbarkeit. Was meint ihr?

make whatwedo\CoreBundle\Form\Extension\ChoiceTypeExtension only work for definition context

when using a ChoiceType out of the crud definition context there should not be a data-controller attribute added automatically.