The crudbundle from whatwedo

Alias automatisch generieren

basierend auf Klassennamen

indexAction: Request Objekt ergänzen

Wird aktuell bei allen Actions ausser der indexActions mitgegeben

Form Type für preselect definitions

Wenn per Query-Parameter Informationen zu einer Entity erwartet werden, wird normalerweise als Form Type EntityHiddenType verwendet. Dies funktioniert jedoch nicht, wenn es nicht sicher ist, ob eine mitgegeben wird. In diesem Fall muss ein AjaxSelectFormType genommen werden.

Aktuell muss dies mit Konditionen programmiert werden. Mittels einer Kreuzung der beiden (PreselectEntityFormType) könnte eine einfachere Lösung umgesetzt werden.

getChildRouteAddition() entfernen

Konsequent durch den Alias ersetzen

Update DOC for EntityHiddenType

            ->addContent('trainer', null, [
                'label' => 'Trainer',
                'preselect_definition' => TrainerDefinition::class, // to know which parameter is the preselected user
                'form_type' => EntityHiddenType::class,
                'form_options' => [
                    'class' => TrainerDefinition::getEntity(),
                ],
            ])

Fehler bei aktiviertem WhiteOctoberBreadcrumbsBundle

Sobald das WhiteOctoberBreadcrumbsBundle aktiviert wird, tritt der nachfolgende Fehler auf:

make 'help' translateble

Clear cache automatically

Clear route cache automatically

remove __toString() Method in Entities

since PHP can be written typesafe, adding a __toString() Method to the Entities is bad.

here is a Sample Issue found in a project:

  
/**
 * @ORM\Entity
 */
class Locale
{
...
      public function __toString(): string
    {
        return (string)$this->getName();
    }
}
   
class Translator {
   /*
    * @param string $locale The locale (en, ru, fr) | null If null, will try with current locale
    */
    public function translate(?string $locale = null): TranslationInterface
    {
        return $this->doTranslate($locale);
    }
}

$locale = new Locale();
$locale->setName('German');
$locale->setLocale('de');

$translator = new Translator()

// works, but is wrong
$translator->translate($locale);

// should be
$translator->translate($locale->getLocale());

Possible Solution:

Move the "__toString()" Method to the Definition
introduce a TwigFilter for calling the "toString()" Definition

Require true if not nullable

Automatically add require=true to form input if entity value is not nullable and require is not already set

Handle Inheritance Mapping

how can we better handle Inheritance Mapping?

remove DefinitionView::linkIt() use Formatter instead

instead of using the LinkIt() method to link the Entity use a "EntityLinkFormatter" instead

Formatter as service

Easily possible when we inject the container into Content.php

Simplify Security

getQueryAlias() => getAlias()

Als getQueryAlias den generierten Alias von #30 verwenden

Optimizing AJAX

Optimizing and simplifying AJAX integration

Varianten:

AjaxListenExtension (o.ä.)
Form Type wrappen

Bundle without whatwedo/search-bundle broken

Bundle installation fails if the whatwedo/search-bundle is not installed:

/var/www $ composer require whatwedo/crud-bundle
Using version ^0.4.5 for whatwedo/crud-bundle
./composer.json has been updated
Running composer update whatwedo/crud-bundle
Loading composer repositories with package information
Updating dependencies
Lock file operations: 3 installs, 0 updates, 0 removals
  - Locking whatwedo/core-bundle (v0.4.0)
  - Locking whatwedo/crud-bundle (v0.4.5)
  - Locking whatwedo/table-bundle (v0.4.7)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 3 installs, 0 updates, 0 removals
  - Downloading whatwedo/core-bundle (v0.4.0)
  - Downloading whatwedo/table-bundle (v0.4.7)
  - Downloading whatwedo/crud-bundle (v0.4.5)
  - Installing whatwedo/core-bundle (v0.4.0): Extracting archive
  - Installing whatwedo/table-bundle (v0.4.7): Extracting archive
  - Installing whatwedo/crud-bundle (v0.4.5): Extracting archive
Generating optimized autoload files
composer/package-versions-deprecated: Generating version class...
composer/package-versions-deprecated: ...done generating version class
109 packages you are using are looking for funding.
Use the `composer fund` command to find out more!

Symfony operations: 3 recipes (63010ebfeaa3ff87c890bec156fcfc37)
  - Configuring whatwedo/core-bundle (>=v0.4.0): From auto-generated recipe
  - Configuring whatwedo/table-bundle (>=v0.4.7): From auto-generated recipe
  - Configuring whatwedo/crud-bundle (>=v0.4.5): From auto-generated recipe
Executing script cache:clear [KO]
 [KO]
Script cache:clear returned with error code 1
!!
!!  In DefinitionErrorExceptionPass.php line 54:
!!
!!    Cannot autowire service "whatwedo\TableBundle\EventListener\AjaxFilterSearc
!!    hListener": argument "$indexRepository" of method "__construct()" has type
!!    "whatwedo\SearchBundle\Repository\IndexRepository" but this class was not f
!!    ound.
!!
!!
!!
Script @auto-scripts was called via post-update-cmd

Installation failed, reverting ./composer.json and ./composer.lock to their original content.

Update documentation for routing

If you overwrite the default Crud-controller to add an Action, the definition on the Parent-controller is null.

To overcome this you have to set ,defaults={ "_resource"=XXXDefinition::class } inside the Route annotation; eg

@Route("/feature/xxx", name="whatwedo_feature_xxx",defaults={ "_resource"=XXXDefinition::class })

This should be updated in the documentation.

Filter entfernen

Es soll möglich sein den letzten Filter zu entfernen. Beim entfernen des letzten Filter, wird das Filter Formular ausgeblendet

Add sortable capability/extension

Allow sort Entity.

using https://github.com/Atlantic18/DoctrineExtensions

Verbesserungsideen

Ideen

Relationen müssen immer eigenständig mit Filterungen programmiert werden

Anpassungen

indexAction benötigt das Request-Objekt

Update DOC about EntityAjaxType

RelationContent Voter

the RelationContent needs a security voter to hide or show the add button => add_voter_attribute

Index: Change Title to entityTitle

Currently it's used "Übersicht". On the index page it should display the entityTitle by default

getRepository aus DefinitionInterface entfernen

getRepository() muss komplett aus dem DefinitionInterface entfernt werden, damit nur der QueryBuilder der Definition genutzt wird
CrudController muss via QueryBuilder die aktuelle Entity holen, nicht via Repository->find()

Make request parameters globally available

Make request parameters globally available (in CRUD classes)

configureView => configure

Um mehr Daten an einer Stelle zu konfigurieren, welche unabhängig vom View sind

CSV Export auslagern

Alle Infos aus dem DefinitionBuilder nehmen
Als Extension
ähnlich wie FilterExtension: allow add / remove of content / columns

Filter mit Relationen per AJAX laden

Alle automatischen Filter, welche eine Relation durchsuchen (z.B. Gruppen -> Personen oder umgekehrt) sollen per AJAX geladen werden. Bei grösseren Tabellen (> 10'000 Einträge) werden die Ladezeiten ansonsten unzumutbar oder wir laufen in Timeouts / Memory Limits

Gleiches in Ticket #2 für Formularfelder

auto-configure relations

how can we auto-configure relation's?

Usage of deprecated whatwedoCrudBundle:Relation:ajax

Referencing controllers with whatwedoCrudBundle:Relation:ajax is deprecated since Symfony 4.1, use "whatwedo\CrudBundle\Controller\RelationController::ajaxAction" instead.
1x in DefinitionTest::testDefinitions from App\Tests\Common
1x in DefinitionTest::testOrdering from App\Tests\Common

DefinitionView and CrudController are using different ways to check for existing Template Directory

Make them use the same method:

https://github.com/whatwedo/CrudBundle/blob/master/Controller/CrudController.php#L378

and

https://github.com/whatwedo/CrudBundle/blob/master/View/DefinitionView.php#L475

Box Templates mit Twig Blöcken erweitern.

Mit commit e161ea0 wurde es Möglich die box Templates zu überschreiben. Zurzeit gibt es erst einen Twig Block (show.html.twig - add_button):

Überall wo es Sinn gibt einen Block hinzufügen.

Namespace

CrudBundle/Form/EntityAjaxType.php

Line 28 in 97694f2

namespace whatwedo\CrudBundle\Form\Type;

sollte das nicht 'namespace whatwedo\CrudBundle\Form;' sein?

Content::getFormOptions() overwrite 'attr' Defaults

if a FormType has set the attr Option as default. For example a Custom DateTime Picker. The attr option will be overwritten be the Content::getFormOptions() function

Because the function sets the help in the attr array.

[
  'attr' => [
    'help' => 'my help'
  ]
]

The correct way to set the Help on an FormType is to use the help option.

For to achive this Content::getFormOptions(), edit.html.twig and create.html.twig must be changed and the

RelationContent: sortable

getDoctrine aus DefinitionInterface entferenn

Gehört nicht in die Definition
in AbstractDefinition als protected definieren

Read Symfony Validation Contraints

Build the form according to the Asserts defined in the Entity

Symfony4 compatibility

See: http://symfony.com/blog/helping-prepare-for-symfony-4-bundle-support

Make bundle Symfony4 compatible
Create a recipe for Flex
Mark it as done on the Symfony4 Bundle Compatibility List

Relationen in Formularfelder per AJAX laden

Formulare, welche eine Relation zu einer anderen Tabelle haben, sollen per AJAX durchsucht werden, statt select-Felder mit (schlimmstenfalls) mehreren tausend Einträgen vorzuladen. Siehe #1

Dazu ein eigener Form-Type erstellen, damit es optional ist

Request object globally

Make request object globally available (in CRUD classes)

Filter speichern

Es soll möglich sein, die Filter zu speichern. Aktuell ist zwar das Formular aber keine Aktion verfügbar.

Filter nach ID

Der Filter soll auch für die ID funktionieren.

CrudController:deleteAction

There is not a single event fired. needs to be added

Internationalization

it would be nice to use the translator for the labeling of fields, titles, ...

http://symfony.com/doc/current/translation.html

TBD

Routen aus der Definition generieren

die möglichen Routen müssen direkt aus der Definition generiert werden können, um solche Workarounds zu vermeiden:

$definitionObject::getRoutePrefix().'_'.RouteEnum::INDEX

Use whatwedo Table in RelationContent

Use whatwedo Table in RelationContent instead of jQuery Datatables

unintuitive parameter for content callable

CrudBundle/Content/AbstractContent.php

Line 149 in ef8aefc

return call_user_func($this->options['callable'], [$row]);

Is it necessary to wrap the $row parameter into an array?

CrudController:: denyAccessUnlessGranted overriding final method

Method CrudController:: denyAccessUnlessGranted is overriding final method Symfony\Bundle\FrameworkBundle\Controller\AbstractController::denyAccessUnlessGranted(). Symfony\Bundle\FrameworkBundle\Controller\AbstractController::denyAccessUnlessGranted() will crash if CrudBundle is used with disabled firewall authentication.

@lukasluecke @xarem do you have any idea how to implement this beautifully?

whatwedo / crudbundle Goto Github PK

crudbundle's People

Contributors

Stargazers

Watchers

Forkers

crudbundle's Issues

Ideen

Anpassungen

Recommend Projects

Recommend Topics

Recommend Org