WHS.ResizeModule does not play nicely with WHS.PostProcessorModule

[antoniocapelo]

WHS.ResizeModule does not play nicely with WHS.PostProcessorModule

[sasha240100]

Hi @antoniocapelo !

Any PRs are welcome! :D
PostProcessorModule creates a new renderTarget. Typically there are only inputBuffer and outputBuffer, but some advanced passes may require more which makes this thing unpredictable.

What you can do is to try to update them manually with this pseudo-code:

// WARNING: Not tested

const {composer} = app.use('postprocessing');

app.use('resize').addCallback((width, height) => {
  // Update buffer sizes
  composer.inputBuffer.setSize(width, height);
  composer.outputBuffer.setSize(width, height);
});

[antoniocapelo]

Hi @sasha240100, I'm willing to help :D Just point me to the better option, would be it be something inside the codebase? A note on the docs?

What I've done was create a ResponsivePostprocessorModule (ignore the name) that does the following:

class ResponsiveEffectComposerModule {
    manager(manager) {
        manager.define('effectComposerResizeHandler');
        const resizeModule = manager.use('resize');

        this.postprocessorModule = manager.use('postprocessor');

        if (!resizeModule) {
            throw new Error('ResizeModule dependency not met. Make sure that ResizeModule is listed as a dependecy of App.');
        }

        if (!this.postprocessorModule) {
            throw new Error('PostProcessorModule dependency not met. Make sure that PostProcessorModule is listed as a dependecy of App.');
        }

        resizeModule.addCallback(this.updateRendererSize.bind(this));
        this.updateRendererSize(window.innerWidth, window.innerHeight);
    }

    updateRendererSize = (windowWidth, windowHeight) => {
        this.postprocessorModule.composer.setSize(windowWidth, windowHeight);
    }
}

I just add this module to the App's module list (in the correct order) and now when I resize the window everything stays sharp.

Probably what you suggested would be needed if my problem persisted?

[sasha240100]

Looks nice and useful! @antoniocapelo You may even drop !resizeModule checks as they should be already done by ModuleSystem.

We're now working more on https://github.com/WhitestormJS/nextgl , which should become a Three.js replacement for Whitestorm.js v3.x, so most of out time & skills are going to that project. Contact me if you are willing to contribute to that one! :)

[antoniocapelo]

@sasha240100 check your twitter DM's (: