whiztim/ubjsoncpp

A high performance C++14 library for effortlessly reading and writing UBJSON

ubjsoncpp's Issues

Add support for High-Precision Numbers

If I readf the code correctly then support for High-Precision Numbers missing, or did I miss something?

remove incompatible binary support

This badly needs binary support for the streams

Binary read+write support. How many days is this out? If I don't have it soon I may have to write it myself

//else if(v.isBinary()) // k = append_binary(v); //currently not supported

rvalue reference qualified conversion operator induces a potential bug

Given this code

using namespace ubjson;
    Value m;
    m = "Hello UBJSON"
    static_cast<std::string>(std::move(m))
    //or
    //static_cast<std::string&&)(m)

    ASSERT(m.type() == Type::String); //this assertion fires

Given, that no object recieved the rvalue conversion, this object is still a string

Add support for strongly typed arrays.

The support for homogeneous arrays is missing. see StreamWriter<StreamType>::append_array

    //! \todo TODO... detect homogeneous arrays and treat accordingly
    //! WORK in progress

I think you made this difficult because you got the binary type wrong. I.E there is not one binary type, but all the strong typed arrays are different binary types. One should be able to write something like:

std::vector<int> ints = foo();
ubjson::Value value;
value["ints"] = ints;

and that should serialize into

[{][i][4][ints][[][$][I][#][i][5][1][2][3][4][5]

Note the [$][I]. The type of the array should be kept as passed in so that it is received that way.

Add support for No-Op Value

If I read the source code correctly then the No-Op value is not considered. This is especially important for the streams.

Support for systems without <endian.h>

Many operating systems do not have an <endian.h> file. This is used in stream_helpers.hpp. Consider adding a portable <endian.h> file

Doesn't build or work at all on MSVC

I thought this was supposed to be a portable library.

Json parsing

Is it possible to use this library to convert between plain text json (stored as std::string) and ubjson?

Problems with unsigned int and unsigned long

The test code

unsigned int ui = 42u;
unsigned long ul = 42u;

value["unsigned int"] = ui;
value["unsigned long"] = ul;

does not compile because of ambiguity. To remove the ambiguity, additional constructors must be added.