wibsonorg/batchpayments

A gas conscious batch payment implementation

batchpayments's Issues

Hash or Lock?

Shouldn't this be the stored lock ? I'm testing a few things with it already and I think we're using hash as kind of a "checksum" of the data and lock as the hashed master key.

BatchPayments/contracts/BatPay.sol

Line 204 in c58358e

if (h == payments[payId].hash)

Migrate to truffle v5, solc v0.5 and web3 v1.0

Typo in challenge 3 revert message

There is a typo in the revert message of challenge_3, line 337.
It says "only challenger can call challenge_2"
It should say "only challenger can call challenge_3"

Use OpenZeppelin's ECDSA.recover

Requires #35

Import and use OpenZeppelin's ECDSA.recover instead of the homemade Challenge.recoverHelper.

IMO, there's no point in making this change before #35, because we would be using an old OZ release that won't be updated (and won't have some important fixes).