Giter Site home page Giter Site logo

wildsideuk / laravel-mailguneu Goto Github PK

View Code? Open in Web Editor NEW
13.0 13.0 3.0 8 KB

Allow customising the Mailgun server URL to use EU servers.

Home Page: https://wildside.uk

License: MIT License

PHP 100.00%
eu gdpr laravel laravel-package mailgun php

laravel-mailguneu's People

Contributors

mattmcdonald-uk avatar tarasovych avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

laravel-mailguneu's Issues

Wrong URL with latest version of laravel 5.5

I did a composer update earlier today on my server and suddenly no mails were being sent. No errors, no logs... and no mail. Locally everything worked until I did the composer update. I'm not sure which package is at fault.

In any case, I did some digging into the MailgunTransporter and I saw that there is now an endpoint-parameter in the construct-function. This is used to build the url for the request.

Because of this, this package (WildSideUK/Laravel-MailgunEu), doesn't work any longer with the latest version of laravel 5.5 (at least 5.5.45, perhaps earlier).

Good news is, you can add an 'endpoint'-paramter in your services-config with the value eu.api.mailgun.net and everything will work out of the box.

PS: This is an already resolved issue (not really an issue at all) - but I didn't know where else to post it. I just wanted to spare my fellow humans the debug-hell I went through. Maybe put it in the readme?

Readme is inconsistent with implementation

The readme instructs users to provide a full url in the domain setting, but the actual implementation is hard-coding the EU endoint prefix to the domain value.

If the intent of this package is simply to allow drop-in replacement of the API endpoint, I suggest rewording the readme to be clear that this is all it does and doesn't offer any further configuration options, nor does it require the config values to be changed.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.