will-stone/hash-source

A hash router source for @reach/router

hash-source's Issues

Problem when using with Gatsbyjs/Webpack

I'm trying to use hash-routes with Gatsbyjs. While developying, I get no errors, when compiling I receive a WebpackError: ReferenceError: window is not defined.

This is a know problem.

Missing Types

Hi, I'm trying to incorporate this into a Typescript project that uses reach-router, however, it seems that there is no type declarations for this module, is there one (none found under @types/hash-source)? It would be pretty useful, otherwise I cant really use it.

TypeScript error with reach-router 1.2.1

Hi, thanks for providing the hash source for react router. Came across a TypeScript problem while incorporating it in my project:

TypeScript error: Argument of type '{ readonly location: { pathname: string; search: string; }; addEventListener(name: any, fn: (this: Window, ev: any) => any): void; removeEventListener(name: any, fn: (this: Window, ev: any) => any): void; history: { ...; }; }' is not assignable to parameter of type 'HistorySource'.
  Types of property 'location' are incompatible.
    Type '{ pathname: string; search: string; }' is not assignable to type 'WindowLocation'.
      Type '{ pathname: string; search: string; }' is missing the following properties from type 'Location': ancestorOrigins, hash, host, hostname, and 7 more.  TS2345

    24 | import ErrorBoundary from "./ErrorBoundary"
    25 | 
  > 26 | const history = createHistory(createHashSource())

Any idea? Using reach-router 1.2.1 right now.

Using hash routing with reach-router navigate API

Hi,

I have just integrated your lib in my project, and Links are working fine, but navigating programatically is not working (ie, navigate("/projects");).

Is this known? Are there any workarounds?

Thanks!

Location State Doesn't Provided

Location State doesn't pass throught props.navigate. Its always the same {pathname: string, search: string}.

Incompatible React versions

First of all, thank you for this little package that I've been using for a moment.
Sadly, I've met an issue with this package.
With newer React version, this package doesn't seems to work properly : the URL get updated but the page doesn't reload / change.

I've been using it with React 16.5.2, but few month ago when I've tried to upgrade to React 16.6 I got this issue that I'm having now trying to upgrade to React 16.7.0.alpha.2.

Doesn't seems to work with the latest stable version of React too

CTRL CLICK EVENT + Link break the URL

Hi,

I m using hash-source for hash based routing in @reach/router, but i found issue when i want to open a Link in other window using ctrl click.
<Button component={Link} to="/home">Home</Button>
With simple click i get this url: http://localhost:3001/#/home
With ctrl click i get this url: http://localhost:3001/home#/

Any Help!
Thanks.

Refreshing the browser causes the route to fail

such as

1. localhost:8080/#/
2. turn to localhost:8080/#/otherpath
3. refresh browser
4. the browser show localhost:8080/#/ but url is localhost:8080/#/otherpath

Using reach router navigate function or Link component does not use relative url and removes hash

Everything is working fine except navigate function or Link component.

For example if I am on a url example.com/#/organiser/company

and I call navigate('seminar')

it will redirect me to example.com/company

So relative path is not respected and hash is completely removed.

Here is the code example:

https://codesandbox.io/s/zwmrrq3vy3