FR: Provide a way to configure inputs at the module level

[willmendesneto]

FR: Provide a way to configure inputs at the module level

[willmendesneto]

Hi @HunteRoi. Thanks for help on that, mate!

One approach that might be used here is by creating a service and adding it to be used on service constructor. E.G. https://angular.io/guide/dependency-injection

So we can have a service like NgxSkeletonLoaderServiceConfig when we are adding all the information added via forRoot

NgxSkeletonLoaderModule.forRoot({
  loadingText: 'Please wait, content is loading...',
  animation: 'pulse',
})

And adding it on NgxSkeletonLoaderComponent, checking and overriding in case there's no default value being passed to the component.

So, based on this rule and example, we can assume:

• If there's no animation value, we should set animation with pulse value as default
• If there's animation value, the given value should be used since that means it was added intentionally.

Happy to help on the review or in any other way I can, mate!

[willmendesneto]

@rafaelss95 Yeah, that makes sense to me. Thanks for the feature request, you're welcome to create a PR.

[HunteRoi]

This seems like a reasonable request. I'm willing to participate. Although I don't quite know how this could be implemented as the parameters are actually component's attributes with @Input.

Anyone to guide and review once the PR is done ?

[HunteRoi]

Is it worth creating types ? eg

// types
export type Appearance = 'circle' | 'line' | '';

export type Animation = 'progress' | 'progress-dark' | 'pulse' | 'false' | false;

export type Theme = {
  // This is required since ngStyle is using `any` as well
  // More details in https://angular.io/api/common/NgStyle
  // tslint:disable-next-line: no-any
  [k: string]: any;
};

export class NgxSkeletonLoaderConfig {
  appearance: Appearance = 'line';
  animation: Animation = 'progress';
  theme: Theme = {};
  loadingText: string = 'Loading...';
  count: number = 1;
}

export const defaultConfig = new NgxSkeletonLoaderConfig();

//service
@Injectable({ providedIn: 'root' })
export class NgxSkeletonLoaderConfigService {
  readonly config: NgxSkeletonLoaderConfig = defaultConfig;

  constructor(@Optional() config: NgxSkeletonLoaderConfig) {
    if (config) this.config = config;
  }
}

This would mean that the changes on the library are more important though.

[willmendesneto]

If NgxSkeletonLoaderConfig is something used in a single spot, perhaps there's no need of it. We can live on NgxSkeletonLoaderConfigService for better maintenance. Also, there's no need to have NgxSkeletonLoaderConfig as a class since a const can do the trick.

const defaultConfig =  {
  appearance: 'line',
  animation: 'progress',
  theme: {},
  loadingText: 'Loading...',
  count: 1,
} as NgxSkeletonLoaderConfig;
// ...

For the types, I would say we can apply that in a different matter, but the idea is exactly that!

export type NgxSkeletonLoaderConfig = {
  appearance: 'circle' | '';
  animation: 'progress' | 'progress-dark' | 'pulse' | 'false' | false;
  theme: {
    // This is required since ngStyle is using `any` as well
    // More details in https://angular.io/api/common/NgStyle
    // tslint:disable-next-line: no-any
    [k: string]: any;
  };
};

And, it can reuse it on the component itself. E.G.

export class NgxSkeletonLoaderComponent implements OnInit, AfterViewInit, OnDestroy, OnChanges {
  // ...
  @Input()
  appearance: NgxSkeletonLoaderConfig['appearance'] = '';
  // ...
}

Don't worry if some of the things I mentioned at the moment are not totally clear. Also, I would encourage you to raise a pull request with the changes, thoughts and suggestions. So we can have some even better discussions there.

PS: Nice initiative @HunteRoi