Comments (25)
Should be fixed by wintercms/winter@23ba829 now; ran into this issue myself and got suitably annoyed by it to find a solution 😂
from wn-pages-plugin.
Not in the short term but is on my todo. My guess and gut feeling is that there is some js event that is triggering because of a too broad element selector.
from wn-pages-plugin.
Not sure how / if I can help you with that @AIC-BV, if it's not happening with any of the core plugins or the core itself I can't help.
It was fixed in the plugin by the developer :)
from wn-pages-plugin.
I can confirm this behavior, and I notice that when hitting the "save" button the page is saved, the flash message appears, but in the left column, the page icon still had an "unsaved" badge.
from wn-pages-plugin.
@damsfx are you able to test if this behaviour exists in v2.0.3?
from wn-pages-plugin.
@damsfx are you able to test if this behaviour exists in v2.0.3?
@LukeTowers I've just test the v2.0.3 and the behavior is the one expected.
In v2.1.2, I can't add more than two images, the third time I hint the insert image icon, the related modal disappear after 1~2s.
In the same time, when the modal disappear, a unsaved badge is added to the left page icon.
The unsaved badge is added each time a modal related to an editor icon is pressed, event if nothing is done.
from wn-pages-plugin.
@jaxwilko can you take a look at this? I'm thinking this might be because of the new live preview functionality
from wn-pages-plugin.
Have a same problem after upgrade to 2.1.2
Winter CMS Build: 1.2.1
Pages Plugin Version: 2.1.2
PHP Version: 8.1.0
from wn-pages-plugin.
I have a similar problem also with the "insert file" feature.
If I click on the first icon on the left (the black one in the screenshot), nothing happen, the media widget is not shown anymore.
(WinterCMS and Pages updated at the latest versions available)
from wn-pages-plugin.
Hi @LukeTowers and @jaxwilko, sorry I don't wanna push but is there some timeline about the solving of this issue?
and btw, always related to the WYSIWYG editor I probably found another bug. When I'm in the html mode if I insert a <form>
tag, it is removed when I save even if it is in the "allowed tags" list (backend editor settings). Does it happen only on my side?
thank you for your time
Ivan
from wn-pages-plugin.
@ivang76 the fastest way for the issue to be solved is for you to submit a PR fixing it. While we appreciate issue reports and try to take care of any reported issues whenever we can the simple fact of the matter is that we have a limited amount of time to accomplish everything on our todo lists, and if we're not running into the issue ourselves or getting a lot of complaints about it there's simply too many other high priority tasks to deal with before we get to this.
from wn-pages-plugin.
Hi Luke, yes I understand the situation... the problem is that at the moment I haven't yet find a solution for both the issues I reported (do you have some inputs or ideas maybe?).
But if I'll find something before of you, for sure I'll try to help and will submit a PR.
from wn-pages-plugin.
It looks like it's happening because froala is triggering a change event on an input element inside of the popup ($popup.find('input.fr-link-attr').trigger('change');
) when attempting to refresh it with _refreshInsertPopup()
. This change event then propagates to the richeditor field itself, which triggers the dependsOn logic on the preview field / tab which then somehow triggers the richeditor field to partially refresh.
from wn-pages-plugin.
ok, thanks that you pointed out me with that details...
and in your opinion what could be the reason (or where I can investigate) of the removing of <form>
tag in the code editor even if is listed as allowed?
from wn-pages-plugin.
Why are you trying to put a <form>
tag in the code editor?
from wn-pages-plugin.
Becasue I need to insert a form
that let a user to login on another remote system, showing input fields and submit button in a section of a wintercms static page. Normally I would insert these elements via "html" mode of the rich text editor.
from wn-pages-plugin.
Same issue here with the closing popups when adding text color or a link. Surprised it hasn't been fixed yet. I got like 10 clients suffering this bug. Searching a quick fix for now. Any update on this?
Edit: I disabled the preview functionality in Plugin.php
below the comment "Add the Preview tab". This works as a temporary solution.
from wn-pages-plugin.
@mauserrifle do you have any time to look a bit further into why the preview tab updating is causing the richeditor to partially refresh?
from wn-pages-plugin.
@bennothommo if you'd care to review it that would be appreciated
from wn-pages-plugin.
@LukeTowers LGTM 👍
from wn-pages-plugin.
Great stuff! 😃
from wn-pages-plugin.
Had this issue too, thanks for the fix!
@LukeTowers I added your changes to my files but its not working (not even after hard refresh or open JS console). Am I missing something?
Test is being logged but box is still being closed in my richeditor field
this.editor.$box.on('change',function(e){console.log('----test');e.stopPropagation()});if(this.options.readOnly){this.editor.edit.off()}this.$el.on('keydown','.fr-view figure',this.proxy(this.onFigureKeydown))
- Create a grouped repeater
- Add a block with a richeditor
- Try adding a link to the richeditor text
=> Popup keeps closing.
from wn-pages-plugin.
Hmm, I'm not sure @AIC-BV. Are you able to replicate the issue on a fresh install of the winter develop branch?
from wn-pages-plugin.
Hmm, I'm not sure @AIC-BV. Are you able to replicate the issue on a fresh install of the winter develop branch?
It works perfectly fine on StaticPages, it does not work in custom plugin
OK I found it... Plugin from someone else is doing post requests, every time the post request happens, the popup closes
window.setInterval(function () {
$(form).request('onLockRecord');
}, 5000);
from wn-pages-plugin.
Not sure how / if I can help you with that @AIC-BV, if it's not happening with any of the core plugins or the core itself I can't help.
from wn-pages-plugin.
Related Issues (17)
- Snippet properties not updating HOT 1
- Two snippets of the same type share the same values HOT 1
- Cannot install plugin via composer HOT 3
- Template not recognized HOT 2
- Missing keywords field HOT 1
- Can't translate the pages HOT 25
- isActive marker for / url HOT 3
- WYSIWYG can't translate internal links HOT 4
- How to show "Last Modified" date on frontend HOT 7
- Unable to insert link in richeditor HOT 4
- How too add support for Hindi language HOT 2
- wrong "Unsaved changes" notification after duplication HOT 5
- Translated content not duplicated HOT 3
- Feature request: Static links HOT 6
- Automatic generated slug not detected when saving new page HOT 3
- Froala Editor - Unlicensed copy of the Froala Editor. Use it legally by purchasing a license. HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wn-pages-plugin.