Comments (5)
I've noticed that the change indicator has seemed a bit buggy in general for the past while, mostly when you have multiple tabs open. Do you think you could dig further into it and submit a PR to fix the issue?
from wn-pages-plugin.
@ericp-mrel is this something you'd be willing to take a look at?
from wn-pages-plugin.
Here's what I've found so far.
If you have multiple tabs open and you make changes to one of them, then all of the open tabs are being marked as modified.
It seems like something is causing the change event to be re-triggered after the original change event is fired since there is a slight delay between the first tab's close button is changed and when the others change.
There's also another issue related to the markup that's being added to the page when duplicating a page that's causing an issue with the modified counter not updating correctly. It seems like some of the form's hidden fields are being added as children inside a div, rather than being direct children to the actual form element itself.
This is problematic because of the following selector:
wn-pages-plugin/assets/js/pages-page.js
Line 148 in 728d2f0
I haven't been able to figure out why this is happening yet.
from wn-pages-plugin.
This is what I've found after digging around with the JS debugger a little bit.
It seems like what's happening is when you make a change to an input field, the initial change event correctly fires and marks the active tab as modified. But then after that the FormWidget.onRefreshDependants
function gets run and then triggers the change event during the refresh process and as a result of that every tab is marked as modified.
from wn-pages-plugin.
@bennothommo @jaxwilko @mjauvin any thoughts?
from wn-pages-plugin.
Related Issues (17)
- Feature request: Static links HOT 6
- Automatic generated slug not detected when saving new page HOT 3
- Froala Editor - Unlicensed copy of the Froala Editor. Use it legally by purchasing a license. HOT 3
- Snippet properties not updating HOT 1
- Two snippets of the same type share the same values HOT 1
- Cannot install plugin via composer HOT 3
- Template not recognized HOT 2
- Missing keywords field HOT 1
- Can't translate the pages HOT 25
- isActive marker for / url HOT 3
- WYSIWYG Insert Link, Insert Image, and Insert Audio Menus Close Too Quickly HOT 25
- WYSIWYG can't translate internal links HOT 4
- How to show "Last Modified" date on frontend HOT 7
- Unable to insert link in richeditor HOT 4
- How too add support for Hindi language HOT 2
- Translated content not duplicated HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wn-pages-plugin.