wireapp/generic-message-proto

Protocol definition for generic messages.

generic-message-proto's Issues

Protocol Buffers Version 3 — Investigation

It looks like we are using Protocol Buffers syntax version 2:

• https://github.com/wireapp/generic-message-proto/blob/master/proto/messages.proto#L1

There is already a Protocol Buffers Version 3 Language Specification, so we might want to update our spec.

@basine, @deanrobertcook & @marcoconti83: Do you see any conflicts in updating to v3?

I guess we might need to change:

// syntax = "proto2";
option java_package = "com.waz.model";

Into:

package com.waz.model;
syntax = "proto3";

Group message content

In our ProtocolBuffer spec we have things like:

message Ephemeral {
  required int64 expire_after_millis = 1;
  oneof content {
    Text text = 2;
    ImageAsset image = 3;
    Knock knock = 4;
    Asset asset = 5;
    Location location = 6;
  }
}

Can we group Text, ImageAsset, Knock & Co., so that we only need to list one type in oneof content?