wisvch/website

WordPress Docker image based on the official docker-library/wordpress image.

Website

Thanks for checking out the W.I.S.V. 'Christiaan Huygens' website repository! This repository is used to generate our internal Docker image, but also functions as issue tracker.

Please report any issues you might find with the website here.

Development

To get started, please follow the instructions to setup WordPress, the ReCHallenge theme and accompanying plugin.

Docker

(todo)

Manually

1. Download and install WordPress.
2. Clone WISVCH/rechallenge in wp-content/themes.
3. Clone WISVCH/wisvch-wordpress-plugin in wp-content/plugins
4. Activate the theme and plugin.
5. Install the WordPress importer plugin and dwnload and import (todo) this demo data.
6. (optional) Go to Appearance > Theme Settings and configure configure CHoice and Google Analytics.

website's Issues

Webshop knop verbergen bij book sale

Momenteel kan iedereen die de book sale website opent bij de webshop. Voorheen moest je eerst inloggen voordat je de knop 'webshop' kon zien. Aangezien wij boeken met korting willen leveren voor alleen onze leden, zou ik graag willen zien dat deze knop weer verborgen wordt voor niet-leden.

Search feature

[Portal] Show personal committee history

Remove Google Tag Manager

https://github.com/WISVCH/rechallenge/blob/caf8697096d7cad77b290eb801a4346fc3e0f94c/lib/SEO.php#L23-L41

Phone numbers in contact tab

Not all phone numbers in the contact tab are clickable. In the footer all phone numbers are click to dail.

Button background blur

Has now 50% white background so the (hollow) button is still visible on hover.

Maybe a blur filter on the background looks better.

Add support for the new Gutenberg editor

Sure looks nice!

https://wordpress.org/gutenberg/

Style checkboxes and radio buttons

[Events] Show event categories in calendar

News article content overflow

https://ch.tudelft.nl/association/news/department-symposium/

Add k8s liveness probe

Move WordPress install to Dockerfile

Move WordPress core, theme and plugin installation (downloads) from entrypoint script to Dockerfile for stability and robustness. Activate plug-ins with WP-CLI at container start to fire the required activation hooks.

Also: only map /uploads to the persistent storage instead of the entire /wp-content directory and wait for database connection when booting a container.

[Portal] Allow changing mailing preferences

Review image size used for partners, news thumbnails (and possibly more)

Error inloggen CHConnect

Navigation menu issues

• Sub menu's display all children, not just the children defined in the menu structure
• Sub menu's work on the level of the page instead of only the second level. Meaning, on a triple-nested page the second-level page is never shown.
• Sub menu's should be shown on hover
• Mobile menu can be improved using a drilldown or sth.

Slider enhancements

• Add setting for slide duration
• Add setting for color overlay (incl. opacity)

Profile > change address is broken

Calendar layout on homepage

(Chrome 61 on macOS 10.13)

Page shrink has no top whitespace

The whitespace between the nav and the main is gone, see example:

Prev / next buttons or arrows at boards, committees, honorary members, etc.

Clean up transient `openid-connect-generic` rows in options table

The options table is filled with hundreds of thousands of _transient_openid-connect-generic-state--* and _transient_timeout_openid-connect-generic-state--* rows.

Fixed in oidc-wp/openid-connect-generic#184.

[Slider] Swipe on desktop

[WP] Remove unused / unnecessary rewrite rules

See https://wordpress.org/plugins/rewrite-rules-inspector/.

Upgrade to Foundation 6.4

[Events] Push notifications for upcoming events

See: https://developer.mozilla.org/en-US/docs/Web/API/Notifications_API/Using_the_Notifications_API

[Events] Allow subscribing to events

Support WordPress'<!--nextpage--> tag in page content

Online member registration form

Improve website performance as audited by LightHouse

I ran a LightHouse audit on the new website and the results are a definitive improvement over the old website! However, there are still some areas for improvement.

See the following JSON file for the full audit ch.tudelft.nl-20171125T151003.log (it is named a .log, but it is actually .json. You will need to rename the file back. See isaacs/github#1130 for more details). You can view a more friendly HTML format by uploading this file to https://googlechrome.github.io/lighthouse/viewer/

• Most notably, images are a big factor, which is already tracked in #16, as 2.1 out of 2.3MB is just images. It seems that user-uploaded content does not properly go through a minification pipeline. A very quick Google resulted in https://nl.wordpress.org/plugins/ewww-image-optimizer/ which might be a solution? (I have no experience with Wordpress, so this is probably better your call)
• Images are not lazy-loaded. Impact is less big than the previous point, but lazy-loading might still be a good thing to do.
• Images that are uploaded are also too big for their actual usage. This means that potentially a 4K image is uploaded which is rendered in a 100x200 box. I know that imagemagick has an option to resize, so maybe that Wordpress plugin has an option as well?
• The website seems heavily depended on jQuery as well as heavy bundling of all assets. This means that the full load is blocked on all JS and CSS before it can render any content. See the Critical Request Chain in the report for more information. Ideally this should be as close to 1 as possible.
  • It seems that the jQuery is loaded by wp_head()? Is it an integral part of the theme or can it be lazy-loaded?
  • The version of jQuery (1.12.4) is also more than 1,5 year old (https://en.wikipedia.org/wiki/JQuery#Release_history) while 3.0 has been out for while. However, you are also loading https://github.com/jquery/jquery-migrate which only seems necessary if you are actually using jQuery 3.x. I think that either jquery-migrate can be removed, or that jQuery should be updated to 3.0 (if it can't be removed)
  • There are 3 woff2 fonts that are being loaded. Is this something we can control? It seems that only 1 woff and 1 woff2 are required
• There are some small Accessibility issues, seems rather straightforward to add.
• A lot of the buttons and text violate the color contrast check (which seems the case throughout the theme). While this issue is not the most important one for now, it might be nice to update the theme to make it accessible to everyone.
• When loading on mobile, it seems that the background color of all sessions is rendered first, only then the images pop in. I think this is related to the issue of not specifying the image size, so probably you can fix this issue when you are working on the performance stuff anyways.

All in all I think the new theme is a huge improvement, especially on mobile. With these last points, the website is blazingly fast on probably every network. Congrats!

Feel free to poke me if you have any more questions. I am also happy to contribute PRs with fixes, if I can figure out how this Wordpress thingy works 😄

Enable customizer for custom post types

[Build Chain] Migrate to yarn + webpack

Add template for education updates

.. containing the three most recent updates and a link to the education update archive. Currently, there are no updates showing at the education update page.

[iCal] Add URL to event on website in description, fix htmlentities in titles

Limit amount of partnerlinks to the nearest multiple of 5

--> Bestuur

Wrongful height items photo gallery

See Image down below.

The albums and photos at the overview on the Flitcie site have the height wrongfully set which makes them overlap. When disabling the height setting in the element style in the li elements hovering over and off the item would correctly set the height.

Don't know where this code is located so placed the issue in the website repo.

[Navigation] Show sub menu on hover

Page numbering incorrect

Page numbering on machazine page seems incorrect

PHP error on CHoice page

https://ch.tudelft.nl/education/choice-old-exams/

Warning: count(): Parameter must be an array or an object that implements Countable in /var/www/html/wp-includes/post-template.php on line 284

Committee page is empty

Allow partnerlink without company profile

So be able to add just a partnerlink, or a partnerlink and job opening. Currently, partnerlinks are linked to company profiles.

Add analytics

Maybe I missed it, but I couldn't find any analytics on the website. It would be great to know what the devices and browser versions of our users are. This makes decisions about browser support and thus potential features a lot easier.

Upgrade to PHP 7.2

Tag wordpress:7.2-apache.