wizard97/simplyatomic

Simple Arduino portable atomic macros

simplyatomic's Issues

MKR1000

Hello,
Does your library support the arduino MKR1000?
Thank you very much for the information.
Regards,
Jose

Conflicts with AVR `util/atomic.h`

If, in a single sketch, both util/atomic.h and SimplyAtomic.h are included, compilation fails:

In file included from mjs_firmware.ino:26:0:
.../avr/include/util/atomic.h: In function 'uint8_t __iSeiRetVal()':
.../avr/include/util/atomic.h:42:27: error: redefinition of 'uint8_t __iSeiRetVal()'
 static __inline__ uint8_t __iSeiRetVal(void)
			   ^
In file included from .../SimplyAtomic/SimplyAtomic.h:9:0,
		 from mjs_firmware.ino:24:
.../SimplyAtomic/avr.h:15:27: note: 'uint8_t __iSeiRetVal()' previously defined here
 static __inline__ uint8_t __iSeiRetVal(void)

Similar errors appear for __iCliRetVal and __iRestore. Fixing this
should be a matter of adding a "SimplyAtomic" prefix to all these helper
functions (also, I think __iSeiRetVal is not used, and could be
removed?).

It would also be good to add a prefix to the ATOMIC_RESTORESTATE macro,
or remove it altogether and just inline it. I would expect an error
about this macro too, but somehow that doesn't happen here.

On an unrelated note, I see that this code is based on AVR's
util/atomic.h, but the license notice is not preserved, which violates
the license of that code. One could argue that this code is too simple
to apply copyright to, but just keeping the license wouldn't hurt. Now,
there is no license attached at all, which would prevent people from
redistributing (binaries containing) this code.

Error: unknown opcode cli

I try to use SimplyAtomic on Arduino using ESP8266 board.
On compiling I get the message: Error: unknown opcode or format name 'cli'.
How can I solve this?

Thanks for your help.

Best regards,

Ton