wizhaoredhat/ocp-traffic-flow-tests

ocp-traffic-flow-tests's Issues

We need a more reliable way to determine "Cluster Type"

Currently, we simply inspect the name of the kubeconfig files that exist to determine what sort of cluster we are deploying in (NIC mode versus DPU mode etc).

We should have something more robust, just because a tenant cluster config exists doesn't necessarily mean we are using a DPU mode cluster.

Eval config needs more granularity

Although for most tests the reverse and not reverse tests are rough the same, there are several tests with a significant difference between the two.
The current eval-config.yaml is not granular enough to distinguish between these fields.
For example:

• POD_TO_HOST_SAME_NODE
• POD_TO_CLUSTER_IP_TO_HOST_SAME_NODE
• HOST_TO_CLUSTER_IP_TO_POD_TO_SAME_NODE
• HOST_TO_CLUSTER_IP_TO_HOST_SAME_NODE
• HOST_TO_NODE_PORT_TO_HOST_SAME_NODE
• POD_TO_EXTERNAL
• HOST_TO_EXTERNAL

This causes POD_TO_EXTERNAL and HOST_TO_EXTERNAL to be marked as failing, when in reality they are supposed to be especially slow.

Threads use "duration" to synchronize instead of Events

Threads currently synchronize their readings with a "duration".
Instead, all of the threads should be able to signal that they are ready. Maybe we can even ditch the duration all together and have the client also signal when it ends.

I put this as an issue because I am leaving this team soon, and this may be a better task for someone more familiar with multithreading in python.

This first came to my attention with ValidateOffload. It

1. Runs a command to get the initial state (no guarantee on when this is happening)
2. Sleeps for duration
3. Runs the same command again to get the final state (no guarantee on when this is happening)

One solution could be to use a "Barrier" https://docs.python.org/3/library/threading.html
We can make a Barrier of size len(montiors+servers+clients). All threads are blocked until each one calls barrier.wait, and they'll start simultaneously.

Use kubectl instead of OC

Then we can rename this repo from ocp-traffic-flow-tests to k8s-traffic-flow-tests

validate hwol plugin fails to run after iperf traffic concludes on a handful of flows

2024-05-10 16:30:23 ERROR: Validate offload plugin is missing expected ethtool data in TestCaseType.POD_TO_CLUSTER_IP_TO_HOST_SAME_NODE
2024-05-10 16:30:23 ERROR: Validate offload plugin is missing expected ethtool data in TestCaseType.POD_TO_CLUSTER_IP_TO_HOST_SAME_NODE
2024-05-10 16:30:23 ERROR: Validate offload plugin is missing expected ethtool data in TestCaseType.POD_TO_CLUSTER_IP_TO_HOST_DIFF_NODE
2024-05-10 16:30:23 ERROR: Validate offload plugin is missing expected ethtool data in TestCaseType.POD_TO_CLUSTER_IP_TO_HOST_DIFF_NODE
2024-05-10 16:30:23 ERROR: Validate offload plugin is missing expected ethtool data in TestCaseType.HOST_TO_CLUSTER_IP_TO_HOST_SAME_NODE
2024-05-10 16:30:23 ERROR: Validate offload plugin is missing expected ethtool data in TestCaseType.HOST_TO_CLUSTER_IP_TO_HOST_SAME_NODE
2024-05-10 16:30:23 ERROR: Validate offload plugin is missing expected ethtool data in TestCaseType.HOST_TO_CLUSTER_IP_TO_HOST_DIFF_NODE
2024-05-10 16:30:23 ERROR: Validate offload plugin is missing expected ethtool data in TestCaseType.HOST_TO_CLUSTER_IP_TO_HOST_DIFF_NODE
2024-05-10 16:30:23 ERROR: Validate offload plugin is missing expected ethtool data in TestCaseType.HOST_TO_NODE_PORT_TO_HOST_SAME_NODE
2024-05-10 16:30:23 ERROR: Validate offload plugin is missing expected ethtool data in TestCaseType.HOST_TO_NODE_PORT_TO_HOST_SAME_NODE
2024-05-10 16:30:23 ERROR: Validate offload plugin is missing expected ethtool data in TestCaseType.HOST_TO_NODE_PORT_TO_HOST_DIFF_NODE
2024-05-10 16:30:23 ERROR: Validate offload plugin is missing expected ethtool data in TestCaseType.HOST_TO_NODE_PORT_TO_HOST_DIFF_NODE
2024-05-10 16:30:23 ERROR: Validate offload plugin is missing expected ethtool data in TestCaseType.POD_TO_EXTERNAL
2024-05-10 16:30:23 ERROR: Validate offload plugin is missing expected ethtool data in TestCaseType.POD_TO_EXTERNAL
2024-05-10 16:30:23 ERROR: Validate offload plugin is missing expected ethtool data in TestCaseType.HOST_TO_EXTERNAL
2024-05-10 16:30:23 ERROR: Validate offload plugin is missing expected ethtool data in TestCaseType.HOST_TO_EXTERNAL
2024-05-10 16:30:23 ERROR: Validate offload plugin is missing expected ethtool data in TestCaseType.HOST_TO_EXTERNAL
2024-05-10 16:30:23 ERROR: Validate offload plugin is missing expected ethtool data in TestCaseType.HOST_TO_EXTERNAL