wlgq2/uvnsq

Async C++ client library for NSQ

uvnsq's Issues

uvnsq API

First of all many thanks for you work!

I've been trying to hack around uvnsq and would like to share some feedback.

First of all NsqConsumer API might need some restructuring as according to nsq docs:

A consumer subscribes to a topic on a channel over a TCP connection to nsqd instance(s). You can only subscribe to one topic per connection so multiple topic consumption needs to be structured accordingly.

Real life usage is similar - one NSQ topic, but many nsqd connections. So I'm wondering if appendSub method can add new nsqd connection rather than topic ?

hostname resolution

When playing locally and subscribing to nsqd running on localhost, the name localhost resolves successfully and consumer can connect. However when I've tested with docker-compose names of the services are not resolved (however connecting using IP works).
I there a way uvnsq can work with hostnames? or only IPs are supported?

Error when compiling with uv-cpp 1.4.5

Trying to compile latest version.

I'm getting:

uvnsq/NsqLookupd.cpp:64:21: error: non-const lvalue reference to type 'uv::SocketAddr' cannot bind to a temporary of type 'uv::SocketAddr'
client->Req((uv::SocketAddr)addr, req);

Seems related to HttpClient.cpp#L41.

Changing signature to Req(uv::SocketAddr addr, Request& req) solves the problem.

Would be nice to add to the README.md a version number of uv-cpp which works with uvnsq.

Timestamp decoding

It seems there is some bug when decoding timestamps. I'm getting nanoseconds close to 2**64( I've just added message.Timestamp() print to the example):

18446744073709534504
18446744073126297668