wmcalliance/royalcommands

1.21 compatible Server Management Plugin (Essentials alternative) with commands for player management, teleportation, homes, and much more.

royalcommands's Issues

Recipe command broke again in 1.12.2

After adding some fixes in for 1.12.1 06581cb it seems 1.12.2 completely broke most of the recipe functionality. I'm curious if maybe we can hook into the new recipe book rather than a custom recipe window.

Add a test for nodes in config

Similar idea to that of the TestAliases test

Nickname command doesn't work from console

[16:26:09 WARN]: java.lang.ClassCastException: org.bukkit.craftbukkit.v1_13_R2.command.ColouredConsoleSender cannot be cast to org.bukkit.OfflinePlayer
[16:26:09 WARN]:        at org.royaldev.royalcommands.rcommands.CmdNick.runCommand(CmdNick.java:99)
[16:26:09 WARN]:        at org.royaldev.royalcommands.rcommands.CACommand.runCommand(CACommand.java:23)
[16:26:09 WARN]:        at org.royaldev.royalcommands.rcommands.BaseCommand.onCommand(BaseCommand.java:282)
[16:26:09 WARN]:        at org.bukkit.command.PluginCommand.execute(PluginCommand.java:44)
[16:26:09 WARN]:        at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:139)
[16:26:09 WARN]:        at org.bukkit.craftbukkit.v1_13_R2.CraftServer.dispatchCommand(CraftServer.java:699)
[16:26:09 WARN]:        at org.bukkit.craftbukkit.v1_13_R2.CraftServer.dispatchServerCommand(CraftServer.java:684)
[16:26:09 WARN]:        at net.minecraft.server.v1_13_R2.DedicatedServer.aU(DedicatedServer.java:459)
[16:26:09 WARN]:        at net.minecraft.server.v1_13_R2.DedicatedServer.b(DedicatedServer.java:418)
[16:26:09 WARN]:        at net.minecraft.server.v1_13_R2.MinecraftServer.a(MinecraftServer.java:835)
[16:26:09 WARN]:        at net.minecraft.server.v1_13_R2.MinecraftServer.run(MinecraftServer.java:733)
[16:26:09 WARN]:        at java.lang.Thread.run(Unknown Source)

Plugin Manager Update Checker Fails

Best bet would be overhauling this system to instead use SpigotMC's Resources section.

Currently this method uses a .rss file that no longer exists on BukkitDev.

https://github.com/WMCAlliance/RoyalCommands/blob/master/modules/RoyalCommands/src/main/java/org/royaldev/royalcommands/rcommands/CmdPluginManager.java#L237

Automate Testing using Client

Use the plugin.yml file to know what commands to run, will need updates to file to clearly indicate what each command does
Test Permissions by adding and removing them
Ideally something that can be ran automatically via Jenkins

https://www.vultr.com/docs/how-to-setup-a-basic-mineflayer-bot-on-ubuntu-20-04
https://github.com/PrismarineJS/mineflayer

Signs now have multiple faces; make necessary adjustments

Both the /signedit command and event handlers should calculate which face/direction the player clicked and perform the necessary action on that side.

Repro steps:

1. Place sign on the ground
2. Right click on the sign
3. Set the text to something
4. Save
5. Walk around to the other side of the sign
6. Right click on the sign
7. Set the text to something different
8. Save the text
9. While pointing at the back of the sign, type /signedit
10. Notice the text is from the front, not the back

Code to look for:
.openSign(
.setLine(

https://hub.spigotmc.org/javadocs/bukkit/org/bukkit/block/sign/SignSide.html

Migrate away from flag-based commands to autocomplete

While the flag-based command system is neat, it ends up being more confusing than anything. With autocomplete it's much easier to have a better idea of what a command's parameters are and to submit them.

Remove Hastebin support for error printing

If we need an alternative, we could use github gists or something. But it's probably not needed anymore.

Map/MapAdjust broken

Currently seems to do nothing. hopefully it's something small
Errors out when item name is MAP, changed it to FILLED_MAP and no longer errors but commands have no impact on the map

java.lang.NullPointerException: Cannot invoke "org.bukkit.map.MapView.setCenterX(int)" because "mv" is null
	at org.royaldev.royalcommands.rcommands.CmdMap.runCommand(CmdMap.java:167)
	at org.royaldev.royalcommands.rcommands.CACommand.runCommand(CACommand.java:23)
	at org.royaldev.royalcommands.rcommands.BaseCommand.onCommand(BaseCommand.java:279)
	at org.bukkit.command.PluginCommand.execute(PluginCommand.java:45)
	at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:149)
	at org.bukkit.craftbukkit.v1_18_R2.CraftServer.dispatchCommand(CraftServer.java:826)
	at net.minecraft.server.network.PlayerConnection.a(PlayerConnection.java:1957)
	at net.minecraft.server.network.PlayerConnection.a(PlayerConnection.java:1796)
	at net.minecraft.server.network.PlayerConnection.a(PlayerConnection.java:1777)
	at net.minecraft.network.protocol.game.PacketPlayInChat.a(PacketPlayInChat.java:46)
	at net.minecraft.network.protocol.game.PacketPlayInChat.a(PacketPlayInChat.java:1)
	at net.minecraft.network.protocol.PlayerConnectionUtils.lambda$0(PlayerConnectionUtils.java:31)
	at net.minecraft.server.TickTask.run(SourceFile:18)
	at net.minecraft.util.thread.IAsyncTaskHandler.d(SourceFile:157)
	at net.minecraft.util.thread.IAsyncTaskHandlerReentrant.d(SourceFile:23)
	at net.minecraft.server.MinecraftServer.b(MinecraftServer.java:1190)
	at net.minecraft.server.MinecraftServer.d(MinecraftServer.java:1)
	at net.minecraft.util.thread.IAsyncTaskHandler.y(SourceFile:131)
	at net.minecraft.server.MinecraftServer.be(MinecraftServer.java:1169)
	at net.minecraft.server.MinecraftServer.y(MinecraftServer.java:1162)
	at net.minecraft.util.thread.IAsyncTaskHandler.c(SourceFile:140)
	at net.minecraft.server.MinecraftServer.x(MinecraftServer.java:1146)
	at net.minecraft.server.MinecraftServer.w(MinecraftServer.java:1051)
	at net.minecraft.server.MinecraftServer.lambda$0(MinecraftServer.java:304)
	at java.base/java.lang.Thread.run(Thread.java:833)

Sub-Command Completions not loading for Parent Commands

Completions not loading for Sub Commands that use Parent Commands

The three found are
/whitelist
/worldmanager
/pluginmanger

Move to bStats

https://bstats.org/

Look into a new way for getting server versions

Github Actions support

Investigate using Github actions to test and package builds

As a backup/replacement to using Jenkins

5.0.0 Release

Dark mode for the docs pages

ParentCommand doesn't properly support autocomplete on the top level

While the code seems to be written to support this, it doesn't seem to work.

Child parameter autocomplete seems to work fine.

Commands to test with:
/worldmanager
/pluginmanager