wolfy64/sjparks

A Text Notification Service for San Jose Parks and Recreations Department for subscribed users.

sjparks's Issues

messageOutgoing

Looks like it has all the components. Does it need to be connected to the dashboard and tested?

Clean it up the file `app.js`

To keep the backend as simple as possible I commented some lines of codes.
Please kindly review it

Need endpoint for UsersPage

For UsersPage I need a endpoint POST api/users ?
To create a new user into database

data = {
  access: String,
  fullName: String,
  phone: String,
  email: String,
  password: String,
};

🚧[BA] Subscribe a phone to a list of parks

Need to finish this feature for the Home Page

Add Tests for Home Page

Add Tests for Home Page

index.js in models

What is this index for?

User.js

1. Create Virtual Fields for optimization
2. Add 'Unique' validation to UserSchema
   Do we need anything else there? If this is going to be implemented with a mobile app, we'll need to connect lists of parks>issues our user is subscribed to.

messageIncoming

1. Unsubscribe [parkID] handling
2. [parkID] subscription handling (ROSE, DM & BH)

Need endpoint for updatesPage

For UpdatesPage I need a endpoint GET api/updates ?
To retrieve a array of posts

posts = [ post, ... ]

post = {
  author: { fullName },
  parks: [ parkID, ... ],
  createdAt,
  message
}

formatResponse

On the request /api/parks when I retrieve parks we don't have the success attribute to true/false

(2) [{…}, {…}]
0:
active: true
code: "001"
createdAt: "2019-02-16T00:58:59.315Z"
messageLogs: []
name: "Park Name B"
subscriptionLogs: []
updatedAt: "2019-02-16T00:58:59.315Z"
__v: 0
_id: "5c75da5c17d8ea58f7ce528e"
__proto__: Object
1: {active: true, subscriptionLogs: Array(0), messageLogs: Array(0), _id: "5c67605324ba7b4862af14e6", name: "Park Name A", …}
length: 2
__proto__: Array(0)

Home Page

For the field Search by Park Name it search by code

Front-end: UI/UX design & development

1. User interface research for modern implementation.
2. Wireframes and features for the About page, adminDashboard, login page, and error pages.
3. React Components
4. Styling
5. Functionality

Need to update phone Image

We should update the phone picture that shows a Samsung phone with a Iphone screen

login.js

What needs to get done here?
`
//register: storing name, email and password and redirecting to home page after signup
exports.newUser = function (request, response) {

// bcrypt.hash(request.body.psw + request.body.uname, saltRounds, function (err, hash) {
//     user.findOne({
//         Username: request.body.uname,
//         Password: hash,
//         admin: request.body.isAdmin
//         },  { runValidators: true, context: 'query' }, function (err, user) {
//         //  I'm not sure exactly what happens if it finds NO users are found, as such I will assume a "NULL"might be returned
//         if (err || !user) {
//             user.create({
//                 username: request.body.usname,
//                 password: hash,
//                 admin: request.body.isAdmin,
//                 notes: request.body.eNts
//             }).then(() => {
//                 console.log('PASS: created new user')
//             //  TODO not sure what to do in here
//             });
//             return response.redirect('/admin');
//         }
//     });
// });

}
`

Backend Review

• Delete comments with everything on Github you can always get the code back
• have the initial server js file that runs the backend in the root then a directory with the rest of the server needed files like routes
• Backend structure needs the most refactor, routes should be grouped by what they accomplish. Make the routes with the functions so you know exactly what they do.
• Too much redirection and abstraction and lots of dead code, if you're not using it now, delete. Do not try to predict the future.

Check if phone number is valid

Add a new function that check the phone number is a US valid phone number and return an boolean