wolox/async-requests

async-requests's Issues

Job name

Right now the sidekiq console shows 'AsyncRequest::JobProcessor' and you cannot see which worker failed

Don't create a new migration if it already exists

When you run rails g async_request it does not validate if the migration already exists and it creates a repeated one, which breaks the migrations.

Availability to use Rails symbols for HTTP status codes

Add exponential backoff JS

We could add a JS that handles Exponential Backoff as an util.

Add secure compare to job id

In the endpoint that shows a job's status, the id should be compared using a comparison method that prevents a timing attack.

Delete finished job in show action

Currently, the async_request_jobs table gets bigger and bigger with each async request. Since the client stops asking for a job once it is finished, it would be nice to have an automatic depuration in the table.

Another issue with the current behavior is that when you queue a job with a sensible parameter (like a password) it remains accessible for anyone that query the table.

I believe that this whole issue could be solved by performing a job destroy inside JobsController#show --> render_finished_job(job)

Increase Rails version support

Allow at least Rails 5.1

Add configurable job path

Currently the job path is /async_request/jobs/:id, will be great to be able to configure that

Confusing README

There are a couple of problems with the README file:

• It says to simple call async_request but on the code example it does call for execute_async.
• I needed to add include AsyncRequest::ApplicationHelper to my root controller.
• It says that the second component of the array we are returning must respond to to_json. A simple String does that and it doesn't work.
• it says status: 202 I would change that for status: :accepted
• it uses MyComputeHeavyWorker and it says that uses Sidekiq to enqueue it, but actually MyComputeHeavyWorker its just a simple class and not a sidekiq worker.

Schedule a task that deletes old jobs

We should schedule a task that deletes Jobs that are older than X days/hours. This value should be configurable

Add support to nil response

When you use async_requests for making requests that depend on an external service’s response, you maybe want to do something like this:

class MyWorker
  def execute
    response = HTTParty.get('http://some-url.com/some_resource')

    [response.code, response.parsed_response]
  end
end

Here, you can expect that if the response code is 200, the response body will have data. But if the response code is 404, maybe the body will be empty.

It would be nice if the library can handle this kind of scenario, and replace a nil response with an empty hash {}. This way, it prevents from returning an Internal Server Error when the response body is empty.

Also, it would be nice if the README was corrected. In this case, a nil response responds to to_json.

Add retry and queue config options in README

Add support for Rails 6

Create a CHANGELOG.md