workinkeith/jsembed

A quick tool for embedding HTML5 (and other JS) applications onto pages.

jsembed's Issues

Safari complains the deprecated meta minimal-ui

Hi @workinKeith ,

I started to have a look at JSEmbed recently and I found a small thing that could be improved.

Observation:
Safari console complains that "minimal-ui" is not recognized. And this meta is added via embedMetaTags function.

Quick Study:

• The minimal-ui viewport property is no longer supported in iOS 8 (see Webkit section in iOS 8 Release Notes).
• If the deprecated meta minimal-ui presents in head, major browsers just ignore it, but Safari complains.
• The following screenshot, which was taken from https://developer.apple.com/support/app-store/, showed the iOS version usage worldwide, which means the percentage earlier than iOS 8 is much smaller than 7%.
  

So, I was wondering if the minimal-ui could be removed from embedMetaTags function. If you're ok with this solution, I can easily remove it and open a quick PR.

If you don't want to lose the 'earlier-than-iOS8' support, it could be added according to the iOS version.

Additional reading material:
https://stackoverflow.com/questions/24889100/ios-8-removed-minimal-ui-viewport-property-are-there-other-soft-fullscreen

Thanks for your time. :)

Undefined parameter `fn` is used in function `addDomLoadListeners`

Hi @workinKeith ,

I noticed that the undefined parameter fn is used in function addDomLoadListeners.

Line numbers are indicated in the following:

JSEmbed/jsembed.js

Line 399 in 4ee52f9

win.onload = fn;

and

JSEmbed/jsembed104b.js

Line 403 in 4ee52f9

win.onload = fn;

Thanks!