workiva/dart_to_js_script_rewriter

A pub transformer that Rewrites Dart script tags to JavaScript script tags, eliminating 404s and speeding up initial loads. Use when building for deployment.

dart_to_js_script_rewriter's Issues

Query strings in script urls aren't handled well

.js is added to the end of script URLs when they are rewritten, even when the URLs contain query strings.

For example:

Input:

<script type="application/dart" src="entrypoint.dart?cache_busting_query"></script>

Expected output:

<script src="entrypoint.dart.js?cache_busting_query"></script>

Actual output:

<script src="entrypoint.dart?cache_busting_query.js"></script>

Update dependencies to work with version 0.13.0 of the html package

There has been a new release of the html package (version 0.13.0).

The dependency on html version "^0.12.2+1" prevents projects from using that newer version of the html package.

Conflicts with Angular Transformer

Hard to identify if this is a dart to js script rewriter or an angular transformer problem but I thought I would start here.

If I have the dart_to_js_script_rewriter transformer first and then the angular transformer, the release pub build version causes errors at run time. The error is always that a method is missing in an angular controller, but it only happens when this transformer is first.

I have it happening in 2 fairly simple projects.

Support subresource integrity (SRI)

Since dart_to_js_script_rewriter is already rewriting the <script> tag it would be great if it automatically included a subresource integrity hash as well.

Support swapping dev and deploy React scripts.

As a React developer,
I want a tool to automatically switch between prod and dev React scripts,
So that I can maintain error messages locally and deploy minified code seamlessly.
This seems like it'd be an apt place to put this functionality since it performs identical functionality for Dart scripts and I'm not sure many people are using Dart without React.

Acceptance criteria:

1. <script src="packages/react/react_with_react_dom_prod.js"></script> Used for deploys.
2. <script src="packages/react/react.js"></script> <script src="packages/react/react_dom.js"></script> Used for development.

automatically add `defer` to script tags

This would help prevent that code is loaded synchronously, when the original program loaded the code after DOM Content loaded.

See dart-lang/sdk#24694 for an example.

Feature Request: autoload webcomponents.js and dart_support.js for non-chrome browsers

test.dart.js could detect whether the browser supports the ShadowDom and if not, include the following scripts:

<script async src="packages/web_components/webcomponents.min.js"></script>
<script async src="packages/web_components/dart_support.js"></script>

The scripts would then be skipped in browsers supporting ShadowDom, which should speed up load time.

Let me know if this sounds like a reasonable idea.

" zero or multiple dart scripts" error

Even though I have reference to a single dart script, I get the following error on "release" build.

[Error from ScriptCompactor on Project|web/index.html]:
Found either zero or multiple dart scripts in the entry point `web/index.html`. Exactly one was expected.

I do have references to two other JavaScript scripts in the same index.html.

I am not sure if I am doing something wrong, or this is a bug.

Release a 1.0

transformer also transforms html files in lib

The transformer also transforms html files in lib, this can give problems together with angular2 for example. It would be better I think if this would only transform files in web, and also only change the html if there is a match.

it now adds html/body tags to angular templates for example:

Transfer to Workiva

Just added @greglittlefield-wf as a collaborator.

Head's up, we might want to help land #17 before the transfer?

If transfers keep PR's, then we can transfer at any time

Update GitHub description and web site - point to pub site

https://pub.dartlang.org/packages/dart_to_js_script_rewriter

Makes it easy to see what's deployed, etc

don't think the csp option is needed anymore

With a ~recent change, dart2js no longer generates both the regular and the csp JS. We user need to specify which type to generate (and the output file name). So, I think generally the csp file will no longer be call precompiled.

https://github.com/sethladd/dart_to_js_script_rewriter/blob/master/lib/dart_to_js_script_rewriter.dart#L52

corner case behavior when trying to debug javascript

I ran into a corner case behavior when trying to debug the compiled javascript app. It was optimized - which is super hard to debug. So I built the app with --mode=debug. It no longer started up, because the index.html file was not re-written by this transformer.

Note that I am not using the browser packages dart.js file; I use this transformer instead.

Not sure what a fix would be -

Update pubspec to point to new home

https://github.com/Workiva/dart_to_js_script_rewriter

Description on pub is malformatted

Maybe this is a change in https://pub.dartlang.org/packages/markdown, but when I go to https://pub.dartlang.org/packages/dart_to_js_script_rewriter, the first paragraph of the README appears to be raw HTML: