wowpin/dumserver

A modern MU* engine re-imagined, actively developed and properly tracked.

dumserver's Issues

Server crash when logging with newly created player

What whatever mysterious reason, freshly cloned server (running on Raspberry Pi 3 with Raspbian) crashes when logging in with freshly created new player.

Need to replicate this and try to understand further.

Developer Tools

It would be awesome if we had some user friendly front-end for designing the game world.

E.g. I want to add 2 new monsters in this room here. Lemme click this button instead of manually modifying JSONs.

Password hashing logic causing server server crash on @quit

When invoking @quit command, the .player file corresponding to player who invoked it gets deleted and server crashes @ChrisByrd14

Following trace log has been captured:

26/11/2019 07:42:06 [info] Client ID: 0 has disconnected (wowpin)
26/11/2019 07:42:06 [info] Player disconnected, saving state
Traceback (most recent call last):
File "dumserver.py", line 822, in
saveState(players[id], playersDB)
File "/var/www/webdav/dumserver/functions.py", line 138, in saveState
savePlayer(player, masterDB)
File "/var/www/webdav/dumserver/functions.py", line 125, in savePlayer
newPlayer[key] = hash_password(player[key])
File "/var/www/webdav/dumserver/password.py", line 28, in hash_password
_hash = hashlib.pbkdf2_hmac('sha512', pwd.encode('utf-8'), salt, 100000)
AttributeError: 'int' object has no attribute 'encode'

Looks like an issue in player state saving procedure, gotta read through that commit again when I'm less tired.

Obsolete version of NPM causing installation problems

NPCs only ever dropping the first item from their loot table

NPCs are ignoring any other items in their loot table after they have dropped the first one. Should be relatively straightforward to fix.

Targetting an NPC with non-existetnt ID throws an unhandled exception.

Doesn't crash the server, but throws
'Unknown command 'NoneType' object is not subscriptable!'

Easy to fix me thinks.

Combat with NPC does not persist in certain scenario

Scenario:

1. Attack NPC
2. Leave area (target is lost, fight where player is the aggressor is removed)
3. Return to the area (at this point NPC's aggro has not expired yet, it resumes attacking the player)
4. Re-target NPC
5. Re-attack NPC

Result:
Players hits the NPC once, then ceases to attack, fight gets deleted.

NPCs not coming out of combat after killing a player.

Considering scenario:

1. Player initiates combat with an NPC
2. Player is killed
3. After combat ends, NPC continues to say phrases from the combat vocabulary.

'@serverlog show' crashes the server if grapevine is disabled via config.ini

Lol.

Need to collect trace - it's an issue with gsocket being passed to an AT command.

Channel name length is unrestricted

No restriction is imposed on channel names when subscribing.

Duplicate NPC fight retaliation

It appears that NPCs retaliate fights with the same player multiple times (e.g. after player has left and returned to the room before aggro expired).

Need to look at the retaliation logic and make sure it doesn't happen if NPC fight with the same target already is in progress.

Not handling the "#" character in user password.

Including a hash signe (#) in your password will break the server on next server boot :)

Due to the fact I'm using a commentjson module, hash is interpreted as beginning of a comment. Same is likely to happen if one includes a double slash (//) in user password.

Players are unable to authenticate after they `@quit`

In a following scenario:

1. Create new player account
2. Log in with newly created player account
3. Invoke @quit

Upon reconnecting, player is unable to authenticate, receiving password incorrect message.

NPC's not respawning with full health

Probably a silly mistake somewhere in NPC respawn loop in dumserver.py.

Player's current target persists through player's death

This should be cleared when player dies.

Players can get disconnected due to inactivity during ongoing fights

In a scenario where a player is in a fight, but hasn't typed a command in a while, it is possible for him to get disconnected due to hitting the idle timer. This leads to a server crash while processing combat actions of a non-existent player.

Combat actions must reset idle timer.

Issue with targetting NPC in crowded room

Scenario:
0. Server reboot

1. Move Player A into a room with NPC in it.
2. Move Player B to the same room
3. Move player C to the same room
4. Player A targets the NPC

Result:
"You cannot see anywhere"

WFTF?

Random server crashes

I cannot exactly pinpoint the exact moment those crashes occur - I have a feeling they coincide with multiple user logons.

Need to setup some method of capturing python tracebacks.

Players respawn with 4HP rather than their max HP

dumserver.py line 419 to be looked at.

NPC Conversation + Quest System

A system with trackable objectives is needed along with some implementation of conversation trees.

Currently little practical idea of how to implement this, although I have spent very little time thinking about it.

dum.wowpin.eu allows arbitrary telnet

I'm not sure where to report this, but allowing random people to connect to random servers with no authentication or sanity checks seems like a bit of an issue.

Multiple logins with the same character are allowed

Although no immediate crash/error occurs, this is not supported by other processes/logic and should be blocked.

Obsolete Webclient dependencies causing security issues

Webclient dependencies need updating and testing.

Chrome not handling empty chars correctly

One of the recent Chrome updates breaks how null chars are displayed (you can see empty square chars in the webclient).

Works fine in IE, EDGE, etc.

Console Spam

Whenever I log in with my character I get this spammed to console. Whether using raw telnet or Mudlet

c3RhdHVzcGFuZWwChris;1;Small Bathroom;100;100;0;100;0;[None]

Also when using raw telnet (putty) I get ghost spaces every few seconds and also the layout is all messed up.

Webclient Redesign

What I would REALLY like is a webclient where I can show health bars, exp bars, ASCII map etc in various sections...

Server crash on NPC death after leaving area.

Server crashes on NPC death during following scenario:

1. target NPC

2. attack NPC

3. go to adjacent room
   (at this point player looses target, however fight remains active - also a bug)

4. return to a room
   (at this point fight continues)

5. NPC dies and crashes the server with a following trace:

   File "dumserver.py", line 582, in
   if players[pid]['target'][4] != None and players[pid]['target'][4] == nid:
   TypeError: 'NoneType' object is not subscriptable

Crash on NPC respawn

Silly bug causing server crashes on NPC respawn. Problematic line commented out, will look into it later.

Ps. Thanks to trace tracking, I know it was caused by LiquidBeef, thanks for your help finding this dude!

No character name validation when creating new character

Some kind of validation needed to restrict name length, inclusion of special chars etc.

Combat information when entering room

It'd be useful to display some kind of summary of who is fighting in the room on entrance

@who throws 'Unknown @command must be str, not NoneType!' in some cases.

Could be happening when other clients are connected, but not authenticated?

Player's current target persists through targets death

When target dies, it stays targetted.

Targeting does not work while there are non-authenticated players

If there are connected clients which have not entered the world yet (on character creation etc.), trying to target something will throw:

Unknown command 'NoneType' object has no attribute 'lower'!

Doh!

Blank names allowed in user creation

Does not crash the server, but it's be nice to throw an appropriate message.

Combat timeout to be configurable via config.ini

Currently the 35 seconds timeout after which the fight will cease (if no combat actions are performed by either side) is hard-coded.

Would be nice to have it configurable via config.ini

Robust help system

Rather than listing every available command via the 'help' command, it would be nice to have a UNIX style MAN system.

Penny for your thought.

Combat announcements

It would be good to announce start of combat to others in the room. Makes sense, people around you would see the brawl.

No password security

No password security measures have been implemented. Do not provide any real passwords when creating user accounts.