wp-cbos-ca/b100-sci

WP 4.3 B100 LTS Scientific

b100-sci's Issues

Report a possible silent misconfiguration in your repository

In your configuration,
https://github.com/wp-cbos-ca/b100-sci/blob/1ffba85c5e90f9803ec586b03777b060fdeafa90/wp-content/plugins/wp-site-dna/https/data.php

function get_https_off_arr(){
    $arr = array( 
        '<IfModule mod_rewrite.c>',
        '  # RewriteEngine On',
        '  # RewriteCond %{HTTP_HOST} !^www\.',
        '  # RewriteRule ^(.*)$ https://www.%{HTTP_HOST}/$1 [R=301,L]',
        '  # RewriteCond %{HTTPS} off',
        '  # RewriteRule ^ https://%{HTTP_HOST}%{REQUEST_URI} [R=301,L]',
        '</IfModule>',
        );
    return $arr;
}

All lines start with a '#' contain a silent misconfiguration. This means adding it to your system will not change any system behavior.
"RewriteEngine Off" is introduced by Apache to explicitly disable all "RewriteRule" and "RewriteCond".
That is to say, if you include multiple "RewriteRule" and "RewriteCond" parameters in your configuration, then instead of commenting them all, you can explicitly set “RewriteEngine Off” to disable all "RewriteRule".

Related Apache source code snippet:

run_rewritemap_programs(server_rec *s , apr_pool_t *p){
if (conf->state == ENGINE_DISABLED) { // usage of "RewriteEngine"
  return APR_SUCCESS; // early return
rewritemap_program(...); // usage of "RewriteRule" 
}