wptt/code-examples

Code examples and snippet library

code-examples's Issues

Email and hex color sanitizers have invalid null check

The email and hex color sanitizers have return ( ! null( $varname where they should have return ( ! is_null( $

PHP notice in select sanitization

I am using function theme_slug_sanitize_select for sanitizing select control. But PHP notice is returned as below.
Notice: Trying to get property of non-object on ....

I checked setting->id and it is returning correct value. I guess PHP notice is due to $setting->manager. What may be problem here?

How to embed these settings ?

Hello.
I want to know that how to embed these customizer settings? Should i include these into themes.

Thanks

Setting defaults

Hello,

from what I have read so far, the appropriate way to call a customizer setting is by declaring its default value, for example:

get_theme_mod('my_setting', 'default_value');

When you have to call the setting in many different places, though, it might be problematic if you decide to change your default value. What I was thinking of doing was a function where I would set the customizer default values only once. For example, something like that:

if( ! function_exists('my_default') ) :
function my_default( $key = '' ) {
    $def = array(
        'setting1' => 'default_value',
        'setting2' => 'default_value'
    );
    if( isset($def[$key]) ) {
        return $def[$key];
    }
}
endif;

Then, in the customizer settings, instead of setting the default like this:

'default'  => 'my_default_value',

I would do it like this:

'default'  => my_default('setting1'),

and I would call the value in the templates like that:

get_theme_mod('my_setting', my_default('setting1'));

That way I would only need to declare my defaults in one place. Would this approach comply with WordPress' good practices or is there any other, preferred way for dealing with the issue?