wptt/customize-section-button

Customizer "button" section. Ideal for creating a pro/upsell link in the customizer.

customize-section-button's Issues

Suggestion: Default button URL should be Theme URI

Not an issue per see, but perhaps the default button URL should be the theme URI, if one exists, and if that does not exist, use Author URI, if it i exists.

Consider escaping button_url with esc_url_raw instead of esc_url for query args.

I'm planning to add an upsell in our theme and add some Google Tag Manager utm query args. Using esc_url() replaces entities for display the & in the url.

I'm not sure this is an issue with GTM, but knowing how finicky things have been in the past I'm leery to have anything but exactly what they ask for in the URL.

I have https://example.com/?utm_source=engine&utm_medium=customizer&utm_campaign=mt-plugins (via add_query_arg)

esc_url gives: https://bizbudding.com/product-category/plugins?utm_source=engine&utm_medium=customizer&utm_campaign=mt-plugins

esc_url_raw gives: https://example.com/?utm_source=engine&utm_medium=customizer&utm_campaign=mt-plugins

Change repo name to "wptrt-customize-section-button"?

Essentially, all this repo does is create a "Button Section". It doesn't technically have to be a "pro" or "upsell" link. The button text and link can literally be anything. Changing it would make it more generic and useful for a wider variety of projects.

Thoughts?

Class not Found Error

I'm always getting this error:

Fatal error: Uncaught Error: Class 'WPTRT\Customize\Section\Button' not found in...

autoload.php is working fine with other Classes and I'm using the default code from the example:

use WPTRT\Customize\Section\Button;

add_action( 'customize_register', function( $manager ) {

	$manager->register_section_type( Button::class );

	$manager->add_section(
		new Button( $manager, 'themeslug_pro', [
			'title'       => __( 'ThemeName Pro', 'themeslug' ),
			'button_text' => __( 'Go Pro',        'themeslug' ),
			'button_url'  => 'http://example.com'
		] )
	);

} );

The strange thing is that only this Button Class is having problems, not other ones.

Build Process

One thing that we should probably decide early on is what system to use for building compiling assets and so on. This project has minimal CSS and JS, so we could get by without anything. But, I'd rather have a consistent method of handling this in any project that includes CSS/JS that we do.

Personally, I'm a fan of Laravel Mix simply because it's super simple to configure: https://laravel-mix.com/ But, I'm open to anything else if someone with more JS and build experience is willing to tackle setting things up.

Goals

We have two goals:

• Provide raw files that theme authors can import into their own builds if they choose to do so.
• Provide compiled files that theme authors can simply enqueue.

File organization

Here's how I do things in my projects:

// Raw, uncompiled files:

- /resources
	/js
	/scss (or css)

// Compiled resources:

- /public 
	/js
	/css