wu-wu/plack-middleware-throttle-lite

Requests throttling for Plack

plack-middleware-throttle-lite's Issues

Abstract backend bug

Hi. I found a bug in https://github.com/Wu-Wu/Plack-Middleware-Throttle-Lite/blob/master/lib/Plack/Middleware/Throttle/Lite/Backend/Abstract.pm#L73

This will always return 'req/hour' as there is no "unit" setup for each unit in $settings href in the function above.

Possible soultions are:
a) add the corresponding "unit" to each of the units hrefs in the settings, or
b) change the line in the beginning of the bug to something like:
my $unit = $self->units || 'req/hour';

This bug is kind of critical, because currently Throttle::Lite works properly only with req/hour limits for backends that rely on expires_in

Warning when running with Gazelle

When running with Gazelle (https://github.com/kazeburo/Gazelle) I get the following warning on each request:
Use of uninitialized value in join or string at /opt/plenv/versions/5.26.0/lib/perl5/site_perl/5.26.0/Plack/Middleware/Throttle/Lite.pm line 280.

This is the code in question:

# Requester's ID
sub requester_id {
    my ($self, $env) = @_;
    join ':' => 'throttle', $env->{REMOTE_ADDR}, ($env->{REMOTE_USER} || $self->defaults->{username});
}

I believe that $env->{REMOTE_ADDR} is not set by Gazelle, which may actually be a Gazelle issue.

I am running with Gazelle like this:

/opt/plenv/versions/5.26.0/bin/start_server \
    --path /run/etd.sock \
    -- \
    /opt/plenv/versions/5.26.0/bin/plackup \
    -s Gazelle \
    --max-workers 5 \
    --max-reqs-per-child 1000 \
    --min-reqs-per-child 800 \
    --app script/etd.psgi

The default HTTP::Server::PSGI server has no such warning.