wvuweb / ur-super-theme Goto Github PK

View Code? Open in Web Editor NEW

0.0 7.0 1.0 803 KB

HTML 46.22% JavaScript 6.64% CSS 47.15%

ur-super-theme's Introduction

Super Theme

Theme Name: Super Theme

Theme Description: Theme for Super Theme.

Developers name(s): Adam Glenn

Stash repository URL: https://stash.development.wvu.edu/projects/CST/repos/ur-super-theme/browse

Dependencies necessary to work with this theme: Sass.

Gulp & Brand Patterns

Requirements

NodeJS

You will need to install Node ~0.12.2

Download and install NodeJS from https://nodejs.org/en if you haven't already.
Install Gulp globally by entering npm install -g gulp in your terminal.
Navigate to your project's directory via terminal (something like cd ~/Sites/cleanslate_themes/MY-SITE)
Install node modules by typing npm install
Run Gulp by typing gulp.

Note: the gulpfile.js in its base form will only compile your Sass.

ur-super-theme's People

Contributors

Watchers

Forkers

bokster

ur-super-theme's Issues

Profile template is always wide

Sidebar dips below.

Add comments within theme itself.

Better documentation needed to explain what you are doing in the actual theme files so others can understand.

admin hero optional paragraph not editable

Can't enter an intro paragraph with the _adminHero.html with Mercury Editor.

<r:editable_region name="so-admin-hero__p" type="simple">Optional paragraph text goes here.</r:editable_region>

Calendar Event doesn't compile on Calendar parent template

When setting up a Calendar page, giving it a child with the Calendar Event template will not output the Event on the Parent page. However, if you define the calendar_id: on another page and put the calendarManual in a pattern slot, it will render the events on that page.

https://stash.development.wvu.edu/projects/CST/repos/ur-super-theme/browse/views/calendar.html#19

It looks like the template is currently defining a page id, which would be different in every instance. I would assume that's the culprit unless that's there for some other reason dealing with something else in the theme.

Lighten transparency on hero/header vignetting...

This is too dark. Also add slight drop shadow to hero text if need be.

Fieldsets for variables are vague without examples

When defining your custom data via the given field, some field names leave a lot of ambiguity to the naming convention of the data you need to insert.

Entering $wvu-gold, wvu-gold, or gold into the field for masthead_color:

One of these yield a gold masthead, whereas one would expect a gold masthead bg to be output as if you were defining it it the pattern's variable itself in the theme files.

Edit: Might have been some server lag earlier, gold works as intended, but the point is still valid. Once we get documentation rolling I'm sure this will be an easy issue to deal with piece by piece.

Make logo path absolute instead of relative.

In the masthead.scss file under 01-base folder the variable $flying-wv-w-signature: on line 10 uses a relative file path to call the logo image.

Using a relative file path causes the image link to break as you get deeper in to the site.

Fix: Using an absolute path will allow the image to always be accessible no matter what page you're on (http://patterns.wvu.edu/images/http://patterns.wvu.edu/images/flying-wv-w-signature.png)

Make it so featurettes can be pulled into any page, like adverts

Make adverts use pull from metadata rather than advert template

Inconsistent content calls on wvu-profile-index patterns

On the wvu-profiles-index pattern, the <r:page:content name="profile__description" /> should be <r:page:content name="wvu-profile__short-description" />

On the wvu-profiles-index--anywhere pattern, there's no call for the wvu-profile__short-description at all.

Add masthead that incorporates "Apply" links...

The user should be able to choose a masthead that accommodates Apply, Give, etc. links.

Add optional complex region to page metadata

Quadtych is broken in super-nav and super-nav--sitewide patterns

Currently:

<r:page:if_has_content_for region="wvu-super-nav__body__description--4">wvu-super-nav--quadtych</r:page:if_has_content_for>

Results in only triptych property being applied to the quadtych.

Change to:

<r:page:if_has_content_for region="wvu-super-nav__body--4">wvu-super-nav--quadtych</r:page:if_has_content_for>

Results in quadtych displaying properly.

Make masthead logo show up in Edit Mode

Make it so metadata on frontpage does not conflict with backpage pattern...

... or maybe prevent people from using backpage pattern on home page? Either way, they conflict.

Make hero that has responsive video.

Start using the Wiki

Suggestion to start a wiki to document various configuration and support information for the super theme.

How to change the Masthead Style etc.

Create a directory partial...

People should be pulled in based on page label (same as slug).

Add agendaAnywhere pattern

Agenda can be dropped into editable region.

Come up with nav that can accommodate more links

Nav breaks... maybe need more breakpoints.

Add more options when pulling in profiles...

... e.g. title, second action item.

Add pattern for search (like Admissions)

Add typographic options for anytych panel...

In case you don't have a photo.

Testimonials should pull from page data not site data...

Originally I had these pulling from site data. Need to swtich like other patterns.

Social media icons should pull from site data

This would remove several editable regions from each page, improve layout in Edit Mode, and improve performance.

H3 in featurettes pattern needs to be smaller

Action Hero sitewide looks different than Action Hero...

Need to restyle.

Make text on button class for profile index not apply to all...

... not sure the best way to do this.

Style indicator in sub-nav for current page class.

Speed up featurettes pattern...

Create new pattern that pulls data from page properties/custom data rather than editable regions.

Make test version of theme that works with Hammer.

No get_page functions, and make sure to include default data in the mock data file.

Style RSS snippet...

E.g. when using in a news feed.

Make footer regions a triptych

Add option for badge above header...

e.g. to show parent (like Cole does on CPASS and I did on WVU Mag).

Social media links in nav bar

I've got the link to Twitter in the Twitter region, but it's showing a broken link to YouTube on the published side.
http://srf.sandbox.wvu.edu

Link:

Make profile index images a circle...

... at least add an optional class.

Add vignetting value as page property...

... this will add a class e.g. vignetting-10, vignetting-20, etc. that will adjust the transparency.

Limit size of hero image...

... background-size: cover should cease at a certain limit.

Breakup SCSS for nav patterns

Right now, the nav patterns are all styled in one SCSS file, even though they are distinctly different classes. Break these up and included them in separate SCSS files for better modularization. You can still call them all in initially, but the option to remove the unused files should be there to lighten the css production file.

Fix default content slots

Get an error on every page:
Could not find partial 'custom-patterns/_so-ERROR: Custom data for 'default_content_03' does not exist..html' in 'University Relations: Super Theme' theme. Could not find partial 'custom-patterns/_so-ERROR: Custom data for 'default_content_03' does not exist..html' in 'University Relations: Super Theme' theme.