wwh1004/dnlib

Reads and writes .NET assemblies and modules, with updates and supports

🎉Hello🎉

I'm wwh1004.
Focus on .NET reverse engineering and Windows security.
Also love architecture design and software development.
Programming mainly in C#, C++.

This is my new blog wwh1004.com and knowledge will be shared here.

dnlib's Issues

Error in LocalConstantSigBlobWriter from wrong TypeSig

When trying to load an assembly + pdb from:

using System;

namespace HelloWorld
{
    class Test
    {        
        static void ErrorMethod() 
        {
            const decimal decimalValue = 7922816251426433759354395033M;
        }
    }
}

dnlib loads the decimal local constant with a ClassSig instead a ValueTypeSig.

This cause a problem when trying to write the module again with the PDB, example:

                _module.Write(filePath, new ModuleWriterOptions(_module)
                {
                    WritePdb = true
                });

In this case the following exception is thrown:

dnlib.DotNet.Writer.ModuleWriterException: Expected a null constant
   at dnlib.DotNet.DummyLogger.Log(Object sender, LoggerEvent loggerEvent, String format, Object[] args)
   at dnlib.DotNet.Writer.ModuleWriterBase.dnlib.DotNet.ILogger.Log(Object sender, LoggerEvent loggerEvent, String format, Object[] args)
   at dnlib.DotNet.Writer.Metadata.Error(String message, Object[] args)
   at dnlib.DotNet.Writer.Metadata.dnlib.DotNet.Writer.IWriterError.Error(String message)
   at dnlib.DotNet.Pdb.Portable.LocalConstantSigBlobWriter.Write(DataWriter writer, TypeSig type, Object value)
   at dnlib.DotNet.Pdb.Portable.LocalConstantSigBlobWriter.Write(IWriterError helper, Metadata systemMetadata, DataWriter writer, TypeSig type, Object value)
   at dnlib.DotNet.Writer.Metadata.AddLocalConstant(PdbConstant constant)
   at dnlib.DotNet.Writer.Metadata.WriteMethodBodies()
   at dnlib.DotNet.Writer.Metadata.Create()
   at dnlib.DotNet.Writer.Metadata.CreateTables()
   at dnlib.DotNet.Writer.ModuleWriter.WriteImpl()
   at dnlib.DotNet.Writer.ModuleWriterBase.Write(Stream dest)
   at dnlib.DotNet.Writer.ModuleWriterBase.Write(String fileName)
   at dnlib.DotNet.ModuleDef.Write(String filename, ModuleWriterOptions options)

From here: https://github.com/wwh1004/dnlib/blob/master/src/DotNet/Pdb/Portable/LocalConstantSigBlobWriter.cs#L150

If the loader uses a ValueTypeSig I would expect the path to be properly handled by: https://github.com/wwh1004/dnlib/blob/master/src/DotNet/Pdb/Portable/LocalConstantSigBlobWriter.cs#L110

I´m using .NET 5.0 on my tests.