wwwlicious/servicestack-eventstore

ServiceStack Plugin for event-sourced systems using GetEventStore

servicestack-eventstore's Issues

EventHandlerException's Handle is not implemented?

when service throw an exception,I want to retry it.But scaned the code,it happenes no action when the value of DropReason enum is EventHandlerException.
code beblow:
case SubscriptionDropReason.EventHandlerException:
//Subscription dropped because an exception was thrown by one of our handlers.
log.Error($@"Subscription to {subscription.StreamId} was dropped in response to a handler exception.
{message}");

Use Embedded Client for Integration Tests

Currently, the integration tests require a running instance of EventStore. This can be improved by switching to running an embedded EventStore node or cluster.

Support .Net Core 2.0

Can we expect port for .Net Core 2.0?

Transaction Rollback?

Hi,

is there any reason why you don't rollback the transaction and rethrow if an exception occures while saving multiple events at once?

try
{
    await transaction.WriteAsync(pageEvents);
}
catch (Exception e) when (e.Message.Contains("WrongExpectedVersion"))
{
    log.Error(e);
    // todo: throw appropriate exception e.g. AggregateVersionException
}
catch (Exception e)
{
    log.Error(e);
}

Need to Pass in EventStoreConnectionSettings?

Previously, the EventStoreConnectionSettings class was supplied to the ServiceStack.EventStore plugin with the connection and authentication settings. However, now these settings are being read from the app.config file of the root project.

Therefore, is there any need to pass in EventStoreConnectionSettings? Can we not just instantiate it inside the plugin itself?

I'll remove this object from the constructor signature of EventStoreFeature.

Add Validation for ReadModelStorage

A ReadModelSubscription should not be considered to be in a valid state unless a ReadModelStorage has been specified. Further, there should be (as far as I can see) only one storage type per read model.

Current project status

1. Do you think that current design (your event sourcing (EventStore) variant via ServiceStack) is still valid and can be used in production?
2. Would you like to change something in your design?
3. Have any other ideas to use SS with EventStore?
4. Will you continue this project?

Add Ability to Connect to a Cluster

At the moment, the EventStore plugin is only capable of running against a single node. Since we will be running EventStore as a cluster we need to add the ability to connect to a cluster.

Dispatcher Errors

When running the integration tests against the embedded EventStore instance in AppVeyor there have been a large number of errors for the types used in the tests:

ERROR: System.NotImplementedException: Unable to resolve service 'EDTUpdated' at ServiceStack.Host.ServiceController.GetService(Type requestType) at ServiceStack.Host.ServiceController.ExecuteAsync(Object requestDto, IRequest req) at ServiceStack.EventStore.Dispatcher.EventDispatcher.<Dispatch>d__4.MoveNext() in C:\projects\servicestack-eventstore\src\ServiceStack.EventStore\Dispatcher\EventDispatcher.cs:line 49

Although this is not failing the build it needs to be investigated and fixed.