wxwxwxwx9/pe

pe's Issues

Inappropraite use of role / label for Structure of Edit Command

Not sure why editParselDescriptor was used as a label.

Execution paths of Import Command missing condition

Missing else condition for [invalid orderType]. There should be another condition to for the alternate path.

Transaction ID is not valid when there is existing transaction ID

Not sure if I'm using the app wrongly but it seems like transaction ID may not be working correctly.

As you can see, the first on the return order list has the transaction id i'm looking for.

Insert example command under Command Summary doesn't work.

UI doesn't wrap the address

As a user, I wouldn't be able to know what address i need to send the order to, if the address is chopped off (if it is too long, which is possible)

This happens when I fullscreen the app on my MacbookPro 13 inch as well. Perhaps the team can consider wrapping the text? Because sometimes we may not be able to make the app fullscreen / have enough screen real estate.

Unusable example command in UG under "Command Summary"

The command highlighted doesn't work.

It says invalid command format.

Tried entering both:

return tid/ac17s2a n/BOBBY TAN a/123 Delta Road #3-333, Singapore S169814 p/91230456 rts/2020-12-12 1301 w/Jurong Warehouse c/NIL type/glass
return tid/ac17s2a

return tid/ac17s2a n/BOBBY TAN a/123 Delta Road #3-333, Singapore S169814 p/91230456 rts/2020-12-12 1301 w/Jurong Warehouse c/NIL type/glass

Both says invalid command.

Interface name shouldn't be italicized under (structure of insert feature)

As per the title.

Editing an entry will cause search filter to be undone

Editing an order will undo the search / filter.

For example, I entered "search -r Aaron Teo".

By editing this particular return order, as shown in the picture below, (Aaron Teo), the search result will be undone.

Not sure if this is intended, but I guess this might pose an issue if say, I'm editing the number 2 entry on the Order List after executing my edit, the search filter suddenly doesn't goes away. As a result, I won't be able to view the entry that I edited -- I have to search for it again (assuming the order list is large and search is the only feasible way to look through it).

Model Component is difficult / too small to read

Did not specify pre-requisite for the test cases for "Search an order"

For test case (b), there should be a prerequisite that states that Delino should contain "Jeremy Loh" in one of the orders.

Like wise for test case (c), there must be the appropriate transaction ID present.

But these are not listed as pre-requisites.

Activity diagram doesn't have [else] as the last condition

Not sure if this is appropriate / allowed according to the module.

Path execution of the List Command

Can be more accurate in the expected result for the invalid List command test case

It says that "An error will occur, a message will appear in the response box, indicating an invalid list command".

But it should also mention that all list orders will be shown as well (regardless of whether it is order or return).

Wrong notations for abstract class (Structure of insert feature)

We were taught to either use {abstract} or italicize to denote an abstract class.

But in this class diagram, both were used.

Complicated SD for (Interactions between objects when Return Command is executed)

I believe the sequence diagram would be considered to be bordering "being too complicated" according to the examples given in the module website.

Perhaps we can omit some self-invocation.

Command doesn't work from Quick Start

insert tid/1023456789 n/Amos Cheong a/Blk 572 Hougang st 51 #11-37 S530572 p/90010019 dts/2020-06-10 1650 w/Marsiling cod/$5 c/Leave it at the riser type/glass

Not sure if ... is a form of correct notation in sequence diagram

This was found under "5.1.5. Interaction between objects when the Insert Command is executed".

Pardon me if i'm wrong (that ... is acceptable to describe parameters, return values, etc.

Deleted "deliveryStatus" field from the ReturnBook json file but Delino starts as per normal

As per title. Delino starts without any warning message about compromised data file.

As you can see from the JSOn file, for the first entry (Aaron Teo's), the deliveryStatus is missing as i deleted it.

The app still loads as per normal.

i realised that when the address field is deleted, Delino will detect corruption but not for the deliveryStatus field.

Different notations for abstract classes in the same class diagram (Structure of Return Command)

I believe that Command class should be abstract.

It is italicized, so I think that it is indicated to be abstract already.

But we have Parcel class which uses another notation.

Try to standardize your notations, especially in the same class diagram.

Structure of Delivered Command should omit private variables to make the diagram less complicated

As per the title.

Command "nearby east" as given on command summary doesn't work

Structure of Delivered Command has both association line and attribute for the same element

Notice that deliveredParcelDescriptor is kept as an attribute.

Then we shouldn't have an association line to the class already.

Only ReturnBook.json file corrupted but Delino registers both OrderBook.json and ReturnBook.json as corrupted.

As in title. it should still load OrderBook.json as it is not corrupted. And the feedback will mislead the user (since OrderBook.json is not corrupted).

What i did was that i removed a space for the delivery status field (after the value), as seen in the ss below.

I did not tamper with OrderBook.json.

UI -- Can be hard to see the difference between a delivered order and a yet-delivered one

Perhaps we can consider using a different color to indicate that the order is delivered?

The UI is very nice, but in terms of being convenient / usable for user, I think it can be done better in this case.

This is because there might be may orders and it would be good to be able to tell easily what is delivered and what is not based on the UI, while on the list display (where both delivered and undelivered are displayed)

Can't copy transaction ID to paste into the command box

This provides quite a bit of inconvenience for the user as the user has to type in the lengthy transaction ID manually.

This can be prone to errors and cause frustration to the user.

I think there should be a way such that it makes it easier for user to accurately enter the transaction ID, so that he can execute commands easily.

Conditions for Activity Diagram (Execution Paths of Return Command) can be phrased better

Can be difficult to read the conditions.

Can consider using [else] to denote the length conditions.

Unable to open via java -jar

Can't open the file via java -jar, using Macbook Pro.

Only earnings from COD can be tracked

Perhaps consider other modes to tracking earnings also?